Hi, I've been looking into egui and wanted to try out miniquad for rendering. I was trying to update this to work with the latest miniquad and egui versions, but the app crashes immediately with:

error: process didn't exit successfully: `target\debug\examples\test_window.exe` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

I'm seeing this error with the versions used by the current master branch as well, so I'm not sure where the error is coming from.

I'm on Windows 10 2004 with Rust 1.47.0. If it helps, I've tried out the miniquad examples from the main repo, and they work fine.

Hello,

This PR is relative to this issue : https://github.com/not-fl3/egui-miniquad/issues/39.

I would like to permit modify pixels_per_point value (currently reset at each frame). I would be happy to receive your review on this PR (I don't know if my approach is good with your architecture or philosophy).

Thanks for your work, buxx.

Hello!

I noticed that if you try to use egui::Ui::image it draws the egui font image instead; and it seems like the TextureId is simply ignored here. I'm not super-happy with the unsafe API here (see my PR here: https://github.com/not-fl3/miniquad/pull/219).

Let me know if there's a better way to "smuggle" the texture handle through here.

This might be useful in egui bindings for macroquad, based on this crate.

Right now I am doing egui-macroquad crate, and found that current system with drawing right at end of the frame is doesn't fit into macroquad architecture. In macroquad it is more convenient to process input (keys, gui) in the beginning, and then to draw everything. For this reasons, there is draw_megaui function in other immediate-mode GUI that used in macroquad.

This is currently blocked on a problem with the web demo.

I updated gl.js to https://github.com/not-fl3/miniquad/blob/v0.3.12/js/gl.js yet I get this wen I try the web demo:

…
gl.js:1392 No __wbindgen_throw function in gl.js
add_missing_functions_stabs @ gl.js:1392
gl.js:1392 No __wbindgen_memory function in gl.js
add_missing_functions_stabs @ gl.js:1392
gl.js:1426 WASM failed to load, probably incompatible gl.js version
(anonymous) @ gl.js:1426
gl.js:1427 TypeError: WebAssembly.instantiate(): Import #5 module="__wbindgen_placeholder__" error: module is not an object or function
    at gl.js:1409:36

Any ideas @not-fl3 ?

Hello,

I'm trying to use Context.set_pixels_per_point don't work function, but it has no effect. Example :by modifying demo example :

[...]

        // Run the UI code:
        self.egui_mq.run(ctx, |egui_ctx| {
            egui_ctx.set_pixels_per_point(2.0);
[...]

Do you know why it has no effect and how to fix it ?

This PR fixes blending, making text look much clearer. I replaced the fragment shader code with the stuff from egui-glow, and I changed the gamma value in the texture update code to the one used in egui-glow.

I'm currently unable to install egui-macroquad with the latest macroquad because of a difference in their miniquad-alpha dependencies (see https://github.com/optozorax/egui-macroquad/issues/16)

egui-miniquad depends on miniquad-alpha 43, whereas macroquad depends on miniquad-alpha 45.

I'm happy to submit a PR to update the dependency in this repo; if so would you be happy to merge and release a new version? Thanks!

• fixes build from using the webbrowser crate, because this is only used in macos according to the cargo.toml
• adds readme with some very basic instructions

Also, I didnt include it in this PR, because i dont think Its up to me to decide, but could you add a license to this project please?

This fixes very slow scroll speed. The old comment said the scroll speed was fine for web but too slow for mac. I am on windows, and it is also too slow for me. It now checks target_arch and multiplies by 8 if not on wasm32.

Here is an example that may be useful for those who would like to render scenes into an egui image using miniquad.

See https://github.com/emilk/egui/issues/729#issuecomment-923221987 for reference

Hello, pasting into EditText causes a panic because of double mut borrow.

PanicInfo { payload: Any { .. }, message: Some(already borrowed: BorrowMutError), location: Location { file: "/Users/optozorax/.cargo/registry/src/github.com-1ecc6299db9ec823/miniquad-0.3.13/src/native/wasm.rs", line: 95, col: 35 }, can_unwind: true }

It is reproducible in the official example: https://optozorax.github.io/egui-macroquad/ (pasting anything in the demo TextEdit causes a panic).

Thank you.

cargo b --release --example demo --target i686-pc-windows-msvc

error[E0308]: mismatched types
    --> C:\Users\Admin\.cargo\registry\src\github.com-1ecc6299db9ec823\miniquad-0.3.13\src\native\windows.rs:887:47
     |
887  |         SetWindowLongPtrA(wnd, GWLP_USERDATA, &mut p as *mut _ as isize);
     |         -----------------                     ^^^^^^^^^^^^^^^^^^^^^^^^^ expected `i32`, found `isize`
     |         |
     |         arguments to this function are incorrect

For some reason, when running app on macOs or Android it is required to use double-click when using egui buttons, slider, combo-boxes or etc. But this is not happening all the time, but only time to time, so it is really strange why it can be happening.

Does anybody else is also facing this issue?

The modifier key state changes are only reaching egui on the next key event. For example, if you press and hold Ctrl and don't press any other key, egui will not know about it. If you then release it, egui will now think it is being held down, until some future key event.

As I understand it, miniquad is passing through (from X11) key up/down events whose modifier state does not include the effect of that event itself. Next, egui-miniquad stores that pre-event modifier state and discards the key event since egui doesn't care about those. It then sends that incorrect state to egui for new frames and with events where miniquad doesn't include the modifier state (e.g. mouse events).

use {egui_miniquad as egui_mq, miniquad as mq};

struct Stage {
    egui_mq: egui_mq::EguiMq,
}

impl Stage {
    pub fn new(ctx: &mut mq::Context) -> Stage {
        Stage {
            egui_mq: egui_mq::EguiMq::new(ctx),
        }
    }
}

impl mq::EventHandler for Stage {
    fn update(&mut self, _ctx: &mut mq::Context) {}

    fn draw(&mut self, ctx: &mut mq::Context) {
        self.egui_mq.run(ctx, |mq_ctx, egui_ctx| {
            egui::CentralPanel::default().show(&egui_ctx, |ui| {
                ui.label(format!("{:#?}",ui.input().modifiers));
            });
        });
        self.egui_mq.draw(ctx);
        ctx.commit_frame();
    }

    fn mouse_motion_event(&mut self, _: &mut mq::Context, x: f32, y: f32) {
        self.egui_mq.mouse_motion_event(x, y);
    }

    fn mouse_wheel_event(&mut self, _: &mut mq::Context, dx: f32, dy: f32) {
        self.egui_mq.mouse_wheel_event(dx, dy);
    }

    fn mouse_button_down_event(
        &mut self,
        ctx: &mut mq::Context,
        mb: mq::MouseButton,
        x: f32,
        y: f32,
    ) {
        self.egui_mq.mouse_button_down_event(ctx, mb, x, y);
    }

    fn mouse_button_up_event(
        &mut self,
        ctx: &mut mq::Context,
        mb: mq::MouseButton,
        x: f32,
        y: f32,
    ) {
        self.egui_mq.mouse_button_up_event(ctx, mb, x, y);
    }

    fn char_event(
        &mut self,
        _ctx: &mut mq::Context,
        character: char,
        _keymods: mq::KeyMods,
        _repeat: bool,
    ) {
        self.egui_mq.char_event(character);
    }

    fn key_down_event(
        &mut self,
        ctx: &mut mq::Context,
        keycode: mq::KeyCode,
        keymods: mq::KeyMods,
        _repeat: bool,
    ) {
        if keycode == mq::KeyCode::Q {
            std::process::exit(0);
        }
        println!("---KEY DOWN---");
        dbg!(keycode);
        dbg!(keymods);
        println!("calling egui_mq.key_down_event");
        self.egui_mq.key_down_event(ctx, keycode, keymods);
        println!("---END---");
    }

    fn key_up_event(&mut self, _ctx: &mut mq::Context, keycode: mq::KeyCode, keymods: mq::KeyMods) {
        println!("---KEY UP---");
        dbg!(keycode);
        dbg!(keymods);
        println!("calling egui_mq.key_up_event");
        self.egui_mq.key_up_event(keycode, keymods);
        println!("---END---");
    }
}

fn main() {
    mq::start(Default::default(), |mut ctx| Box::new(Stage::new(&mut ctx)));
}

I found two kinds of mouse pointer overlaped and blink one after another when the mouse point to for example, textarea, conner of one egui window on ubuntu linux. how to remove miniquad pointer when operate in area of egui?