Let's try to build kajiya on Ubuntu 16.04! :smiley:

First try:

constantine@ubuntu:~$ cd /home/constantine/Downloads/
constantine@ubuntu:~/Downloads$ git clone https://github.com/EmbarkStudios/kajiya --recursive
Cloning into 'kajiya'...
remote: Enumerating objects: 9514, done.
remote: Counting objects: 100% (5369/5369), done.
remote: Compressing objects: 100% (2503/2503), done.
remote: Total 9514 (delta 3585), reused 4505 (delta 2780), pack-reused 4145
Receiving objects: 100% (9514/9514), 103.69 MiB | 9.16 MiB/s, done.
Resolving deltas: 100% (6455/6455), done.
Checking connectivity... done.
constantine@ubuntu:~/Downloads$ cd kajiya/
constantine@ubuntu:~/Downloads/kajiya$ ./bake.sh
./bake.sh: line 1: cargo: command not found
./bake.sh: line 4: target/release/bake: No such file or directory
./bake.sh: line 5: target/release/bake: No such file or directory
./bake.sh: line 6: target/release/bake: No such file or directory
./bake.sh: line 7: target/release/bake: No such file or directory
./bake.sh: line 8: target/release/bake: No such file or directory
./bake.sh: line 9: target/release/bake: No such file or directory
./bake.sh: line 10: target/release/bake: No such file or directory
./bake.sh: line 11: target/release/bake: No such file or directory
./bake.sh: line 12: target/release/bake: No such file or directory
./bake.sh: line 13: target/release/bake: No such file or directory
./bake.sh: line 14: target/release/bake: No such file or directory
./bake.sh: line 15: target/release/bake: No such file or directory
./bake.sh: line 16: target/release/bake: No such file or directory

Yeah... :smiley: Gotta install cargo then...

Is your feature request related to a problem? Please describe.

Sending 'live' data from a DCC app (Maya, Houdini, etc.) to kajia. NSI is an open, node-based C API for DCC apps to communicate with offline renderers. It was inspired by/supersedes the RenderMan API in the 3Delight renderer.

I would be interested in working on this/contributing/helping out. There is a Rust wrapper for NSI (that I maintain) but this is not relevant here (see below).

Describe the solution you'd like

Add the NSI hooks to populate/edit the scene graph of kajia and expose these as a C binding.

This would allow sending data from DCCs to kajia via existing OSS plug-ins that use this API (see below).

Describe alternatives you've considered

There are no good alternatives. Something like USD, API wise, is a total PITA in comparison.

On a sidenote, as there is a USD Hydra delegate for NSI, adding NSI support to kajia would also mean hooking the renderer into USD via Hydra as a side-effect.

Additional context

There are OSS plug-ins that use NSI for Houdini, Maya, Katana and Cinema4D. These would require minimal changes (mostly shaders-related as NSI is built around the idea that a renderer has OSL support) to work with a 3rd party NSI implementation.

Describe the bug can't run kajiya in OSX

To Reproduce Steps to reproduce the behavior:

1. run build_and_run.sh
2. See error

  = note: ld: library not found for -luuid
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

Expected behavior the error is expected, but not sure how to get it work in OSX try to figure out how to run it in OSX

Device:

• Device: m1max
• OS: OSX

ProductName:	macOS
ProductVersion:	12.0.1
BuildVersion:	21A559

• Version master(b67eaea2272924eae053b5918afedf2a318b8bd9)

Part of https://github.com/EmbarkStudios/kajiya/issues/17

In addition to what it says on the tin, this does some folder restructuring.

• Moves assets/rust-shaders/compiled to assets/rust-shaders-compiled
• Moves assets/rust-shaders/builder to crates/bin/rust-shader-builder
• Moves assets/rust-shaders/shaders to crates/lib/rust-shaders
• Adds crates/lib/rust-shaders-shared which is a crate which may be depended on by both CPU code and shaders such that data structures can be shared directly and modified in only one place.

Describe the bug The description says that GTX 1060 and newer are supported (with slow, driver-emulated ray-tracing) but the GTX 1650 does not seem to work, with a thread panic at run-time.

To Reproduce Steps to reproduce the behavior:

1. Follow the building and running instructions
2. Type build_and_run.cmd battle

Expected behavior Demo should run successfully.

Screenshots Compilation succeeds but the following is output when running:

    sparse_properties: PhysicalDeviceSparseProperties {
        residency_standard2_d_block_shape: 1,
        residency_standard2_d_multisample_block_shape: 1,
        residency_standard3_d_block_shape: 1,
        residency_aligned_mip_size: 0,
        residency_non_resident_strict: 1,
    },
} }
thread 'main' panicked at 'Device extension not supported: VK_KHR_pipeline_library', crates\lib\kajiya-backend\src\vulkan\device.rs:220:21
stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\std\src\panicking.rs:517
   1: core::panicking::panic_fmt
             at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\/library\core\src\panicking.rs:100
   2: kajiya_backend::vulkan::device::Device::create
             at .\crates\lib\kajiya-backend\src\vulkan\device.rs:220
   3: kajiya_backend::vulkan::RenderBackend::new<winit::window::Window>
             at .\crates\lib\kajiya-backend\src\vulkan\mod.rs:89
   4: kajiya_simple::main_loop::SimpleMainLoop::build
             at .\crates\lib\kajiya-simple\src\main_loop.rs:235
   5: kajiya_simple::main_loop::SimpleMainLoopBuilder::build
             at .\crates\lib\kajiya-simple\src\main_loop.rs:154
   6: view::main
             at .\crates\bin\view\src\main.rs:112
   7: core::ops::function::FnOnce::call_once
             at /rustc/f1edd0429582dd29cccacaf50fd134b05593bd9c\library\core\src\ops\function.rs:227
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
error: process didn't exit successfully: `target\release\view.exe --scene battle --width 1920 --height 1080 --no-debug` (exit code: 101)

Device:

• OS: Windows 11 Home Insider Preview (22523.1000)
• Card: NVIDIA GeForce GTX 1650
• Driver: Latest Game Ready Driver (497.29)
• Toolchain: stable-x86_64-pc-windows-msvc (default)
• Visual Studio 2019 (16.10.4)
• rustc 1.57.0 (f1edd0429 2021-11-29)

Additional context Perhaps this graphics card is simply not supported, in which case more clarity about supported graphics cards would be useful.

i get the following error with the latest build

Compiling view v0.1.0 (c:\kajiya\crates\bin\view) error[E0308]: mismatched types --> crates\bin\view\src\main.rs:146:33 | 146 | .with(Position::new(position)) | ^^^^^^^^ expected structdolly::glam::Vec3, found structkajiya_simple::Vec3| = note: perhaps two different versions of crateglam` are being used?

error[E0308]: mismatched types --> crates\bin\view\src\main.rs:147:49 | 147 | .with(YawPitch::new().rotation_quat(rotation)) | ^^^^^^^^ expected struct dolly::glam::Quat, found struct kajiya_simple::Quat | = note: perhaps two different versions of crate glam are being used?

error[E0308]: mismatched types --> crates\bin\view\src\main.rs:195:30 | 195 | camera_position: camera.final_transform.position, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct kajiya_simple::Vec3, found struct dolly::glam::Vec3 | = note: perhaps two different versions of crate glam are being used?

error[E0308]: mismatched types --> crates\bin\view\src\main.rs:196:30 | 196 | camera_rotation: camera.final_transform.rotation, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct kajiya_simple::Quat, found struct dolly::glam::Quat | = note: perhaps two different versions of crate glam are being used?

error[E0277]: cannot multiply dolly::glam::Quat by kajiya_simple::Vec3 --> crates\bin\view\src\main.rs:236:17 | 236 | * Vec3::new(input["move_right"], input["move_up"], -input["move_fwd"]) | ^ no implementation for dolly::glam::Quat * kajiya_simple::Vec3 | = help: the trait Mul<kajiya_simple::Vec3> is not implemented for dolly::glam::Quat

error[E0308]: mismatched types --> crates\bin\view\src\main.rs:250:37 | 250 | state.camera_position = camera.final_transform.position; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct kajiya_simple::Vec3, found struct dolly::glam::Vec3 | = note: perhaps two different versions of crate glam are being used?

error[E0308]: mismatched types --> crates\bin\view\src\main.rs:251:37 | 251 | state.camera_rotation = camera.final_transform.rotation; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected struct kajiya_simple::Quat, found struct dolly::glam::Quat | = note: perhaps two different versions of crate glam are being used?

error[E0308]: mismatched types --> crates\bin\view\src\main.rs:295:44 | 295 | .set_rotation_quat(state.camera_rotation); | ^^^^^^^^^^^^^^^^^^^^^ expected struct dolly::glam::Quat, found struct kajiya_simple::Quat | = note: perhaps two different versions of crate glam are being used?

error[E0308]: mismatched types --> crates\bin\view\src\main.rs:296:64 | 296 | camera.driver_mut::().position = state.camera_position; | ^^^^^^^^^^^^^^^^^^^^^ expected struct dolly::glam::Vec3, found struct kajiya_simple::Vec3 | = note: perhaps two different versions of crate glam are being used?

error[E0599]: the method through exists for tuple (dolly::glam::Vec3, dolly::glam::Quat), but its trait bounds were not satisfied --> crates\bin\view\src\main.rs:373:22 | 373 | .through(&lens), | ^^^^^^^ method cannot be called on (dolly::glam::Vec3, dolly::glam::Quat) due to unsatisfied trait bounds | = note: the following trait bounds were not satisfied: (dolly::glam::Vec3, dolly::glam::Quat): IntoCameraBodyMatrices which is required by (dolly::glam::Vec3, dolly::glam::Quat): kajiya_simple::LookThroughCamera &(dolly::glam::Vec3, dolly::glam::Quat): IntoCameraBodyMatrices which is required by &(dolly::glam::Vec3, dolly::glam::Quat): kajiya_simple::LookThroughCamera &mut (dolly::glam::Vec3, dolly::glam::Quat): IntoCameraBodyMatrices which is required by &mut (dolly::glam::Vec3, dolly::glam::Quat): kajiya_simple::LookThroughCamera

Some errors have detailed explanations: E0277, E0308, E0599. For more information about an error, try rustc --explain E0277. error: could not compile view due to 10 previous errors`

To Reproduce Steps to reproduce the behavior:

1. download the latest build (commit [07218ed])
2. bake
3. build_and_run.cmd conference

Expected behavior To have no errors and run.

Device:

• OS: Win10 Pro x64 (v.21H2, build 19044.1526)
• Browser: chrome
• Version: 99.0.4844.51

Hello,

First thing, thanks for your awesome work! I have an issue with this glTF model. According to glTF Report app the model is valid:

Its reliefs appear:

But Kajiya seems to ignore its normal map:

Technical details:

• Kajiya (latest)
• Windows 10
• GTX 1060 6GB

On Windows 10 after a git clone, running bake.cmd:

C:\Users\mdesmedt\git\kajiya>bake.cmd
   Compiling proc-macro2 v1.0.30
   Compiling syn v1.0.80
   Compiling winapi v0.3.9
   Compiling memchr v2.4.1
   Compiling futures-core v0.3.17
   Compiling libm v0.2.1
   Compiling libc v0.2.105
   Compiling log v0.4.14
   Compiling serde_derive v1.0.130
   Compiling proc-macro-hack v0.5.19
   Compiling serde v1.0.130
   Compiling proc-macro-nested v0.1.7
   Compiling futures-task v0.3.17
   Compiling futures-channel v0.3.17
   Compiling failure_derive v0.1.8
   Compiling crc32fast v1.2.1
   Compiling ryu v1.0.5
   Compiling serde_json v1.0.68
   Compiling pin-utils v0.1.0
   Compiling com-rs v0.2.1
   Compiling convert_case v0.4.0
   Compiling async-trait v0.1.51
   Compiling weezl v0.1.5
   Compiling parking_lot_core v0.8.5
   Compiling inflections v1.1.1
   Compiling rand_core v0.6.3
   Compiling lazy_static v1.4.0
   Compiling scopeguard v1.1.0
   Compiling color_quant v1.1.0
   Compiling itoa v0.4.8
   Compiling anyhow v1.0.44
   Compiling jpeg-decoder v0.1.22
   Compiling smallvec v1.7.0
   Compiling derive_builder v0.9.0
   Compiling unicode-width v0.1.9
   Compiling scoped_threadpool v0.1.9
   Compiling nanoserde-derive v0.1.18
error: linker `lld-link.exe` not found
  |
  = note: The system cannot find the file specified. (os error 2)

note: the msvc targets depend on the msvc linker but `link.exe` was not found

note: please ensure that VS 2013, VS 2015, VS 2017 or VS 2019 was installed with the Visual C++ option

error: could not compile `com-rs` due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed

I have both VS 2019 and VS 2022 installed, both with C++ support, but something in the deps appears to be looking for lld-link.exe. Is having the LLVM toolchain required?

I am a student who is learning pbr right now, and i have an question about ggx smith implementation.

I am confused that maybe i misunderstand somthing or it is just your impletation is wrong.

In your shader brdf.hlsl, line 114, function g_smith_ggx1().

I try to change the form of this equation into the same form in https://ubm-twvideo01.s3.amazonaws.com/o1/vault/gdc2017/Presentations/Hammon_Earl_PBR_Diffuse_Lighting.pdf (On page 80). The G1(v) formular. But I realized that your implementation is (2 * ndotv) / (ndotv + sqrt(ndotv^2 + α^2 * (1 - ndotv^2))), and the fomular in GDC is (2 * ndotv) / (ndotv + sqrt(α^2 + ndotv^2 * (1 - α^2))).

It seems that term α^2 and ndotv is reversed in finding square root of some value.

Your: sqrt(ndotv^2 + α^2 * (1 - ndotv^2)). GDC: sqrt(α^2 + ndotv^2 * (1 - α^2)).

Maybe your implementation is different with the formular in GDC? But i can't understand. Thanks in advance for your help.

Your project is a really good learning material!

To Reproduce I compiled kajiya example with a command $ cargo run --bin view --release

Full output

[2022-09-24 14:43:00][winit::platform_impl::platform::x11::window][INFO] Guessed window scale factor: 1
[2022-09-24 14:43:00][kajiya_simple::main_loop][INFO] Internal rendering extent: 1920x1080
[2022-09-24 14:43:00][kajiya_backend::vulkan::instance][INFO] Created a Vulkan instance
[2022-09-24 14:43:00][kajiya_backend::vulkan][INFO] Available physical devices: [
    "NVIDIA GeForce GT 740",
    "llvmpipe (LLVM 12.0.0, 128 bits)",
]
[2022-09-24 14:43:00][kajiya_backend::vulkan][INFO] Selected physical device: PhysicalDevice { PhysicalDeviceProperties {
    api_version: 4202671,
    driver_version: 1973633216,
    vendor_id: 4318,
    device_id: 4040,
    device_type: DISCRETE_GPU,
    device_name: "NVIDIA GeForce GT 740",
    pipeline_cache_uuid: [
        152,
        226,
        37,
        134,
        81,
        32,
        191,
        211,
        161,
        61,
        162,
        219,
        162,
        110,
        202,
        51,
    ],
    limits: PhysicalDeviceLimits {
        max_image_dimension1_d: 16384,
        max_image_dimension2_d: 16384,
        max_image_dimension3_d: 2048,
        max_image_dimension_cube: 16384,
        max_image_array_layers: 2048,
        max_texel_buffer_elements: 134217728,
        max_uniform_buffer_range: 65536,
        max_storage_buffer_range: 4294967295,
        max_push_constants_size: 256,
        max_memory_allocation_count: 4294967295,
        max_sampler_allocation_count: 4000,
        buffer_image_granularity: 65536,
        sparse_address_space_size: 1099511627775,
        max_bound_descriptor_sets: 32,
        max_per_stage_descriptor_samplers: 1048576,
        max_per_stage_descriptor_uniform_buffers: 15,
        max_per_stage_descriptor_storage_buffers: 1048576,
        max_per_stage_descriptor_sampled_images: 1048576,
        max_per_stage_descriptor_storage_images: 1048576,
        max_per_stage_descriptor_input_attachments: 1048576,
        max_per_stage_resources: 4294967295,
        max_descriptor_set_samplers: 1048576,
        max_descriptor_set_uniform_buffers: 90,
        max_descriptor_set_uniform_buffers_dynamic: 15,
        max_descriptor_set_storage_buffers: 1048576,
        max_descriptor_set_storage_buffers_dynamic: 16,
        max_descriptor_set_sampled_images: 1048576,
        max_descriptor_set_storage_images: 1048576,
        max_descriptor_set_input_attachments: 1048576,
        max_vertex_input_attributes: 32,
        max_vertex_input_bindings: 32,
        max_vertex_input_attribute_offset: 2047,
        max_vertex_input_binding_stride: 2048,
        max_vertex_output_components: 128,
        max_tessellation_generation_level: 64,
        max_tessellation_patch_size: 32,
        max_tessellation_control_per_vertex_input_components: 128,
        max_tessellation_control_per_vertex_output_components: 128,
        max_tessellation_control_per_patch_output_components: 120,
        max_tessellation_control_total_output_components: 4216,
        max_tessellation_evaluation_input_components: 128,
        max_tessellation_evaluation_output_components: 128,
        max_geometry_shader_invocations: 32,
        max_geometry_input_components: 128,
        max_geometry_output_components: 128,
        max_geometry_output_vertices: 1024,
        max_geometry_total_output_components: 1024,
        max_fragment_input_components: 128,
        max_fragment_output_attachments: 8,
        max_fragment_dual_src_attachments: 1,
        max_fragment_combined_output_resources: 16,
        max_compute_shared_memory_size: 49152,
        max_compute_work_group_count: [
            2147483647,
            65535,
            65535,
        ],
        max_compute_work_group_invocations: 1536,
        max_compute_work_group_size: [
            1536,
            1024,
            64,
        ],
        sub_pixel_precision_bits: 8,
        sub_texel_precision_bits: 8,
        mipmap_precision_bits: 8,
        max_draw_indexed_index_value: 4294967295,
        max_draw_indirect_count: 4294967295,
        max_sampler_lod_bias: 15.0,
        max_sampler_anisotropy: 16.0,
        max_viewports: 16,
        max_viewport_dimensions: [
            16384,
            16384,
        ],
        viewport_bounds_range: [
            -32768.0,
            32768.0,
        ],
        viewport_sub_pixel_bits: 8,
        min_memory_map_alignment: 64,
        min_texel_buffer_offset_alignment: 256,
        min_uniform_buffer_offset_alignment: 256,
        min_storage_buffer_offset_alignment: 16,
        min_texel_offset: -8,
        max_texel_offset: 7,
        min_texel_gather_offset: -32,
        max_texel_gather_offset: 31,
        min_interpolation_offset: -0.5,
        max_interpolation_offset: 0.4375,
        sub_pixel_interpolation_offset_bits: 4,
        max_framebuffer_width: 16384,
        max_framebuffer_height: 16384,
        max_framebuffer_layers: 2048,
        framebuffer_color_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        framebuffer_depth_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        framebuffer_stencil_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        framebuffer_no_attachments_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        max_color_attachments: 8,
        sampled_image_color_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        sampled_image_integer_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        sampled_image_depth_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        sampled_image_stencil_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        storage_image_sample_counts: TYPE_1 | TYPE_2 | TYPE_4 | TYPE_8,
        max_sample_mask_words: 1,
        timestamp_compute_and_graphics: 1,
        timestamp_period: 1.0,
        max_clip_distances: 8,
        max_cull_distances: 8,
        max_combined_clip_and_cull_distances: 8,
        discrete_queue_priorities: 2,
        point_size_range: [
            1.0,
            2047.9375,
        ],
        line_width_range: [
            1.0,
            64.0,
        ],
        point_size_granularity: 0.0625,
        line_width_granularity: 0.0625,
        strict_lines: 1,
        standard_sample_locations: 1,
        optimal_buffer_copy_offset_alignment: 1,
        optimal_buffer_copy_row_pitch_alignment: 1,
        non_coherent_atom_size: 64,
    },
    sparse_properties: PhysicalDeviceSparseProperties {
        residency_standard2_d_block_shape: 1,
        residency_standard2_d_multisample_block_shape: 1,
        residency_standard3_d_block_shape: 1,
        residency_aligned_mip_size: 1,
        residency_non_resident_strict: 0,
    },
} }
[2022-09-24 14:43:00][kajiya_backend::vulkan::device][INFO] Ray tracing extension not supported: VK_KHR_vulkan_memory_model
[2022-09-24 14:43:00][kajiya_backend::vulkan::device][INFO] Created a Vulkan device
[2022-09-24 14:43:00][kajiya_backend::vulkan][INFO] Available surface formats: [
    SurfaceFormatKHR {
        format: B8G8R8A8_UNORM,
        color_space: SRGB_NONLINEAR,
    },
    SurfaceFormatKHR {
        format: B8G8R8A8_SRGB,
        color_space: SRGB_NONLINEAR,
    },
]
[2022-09-24 14:43:00][kajiya_backend::vulkan::swapchain][INFO] Swapchain image count: 3
[2022-09-24 14:43:00][kajiya_backend::vulkan::swapchain][INFO] Presentation mode: FIFO_RELAXED
Error: Allocation failed for "vertex buffer": OutOfMemory

Device:

• OS: Ubuntu 20.04
• RAM: 8GB
• CPU: Intel Xeon E5450 (4) @ 3.000GHz
• GPU: NVIDIA GeForce GT 740

Additional context Is my PC too potato to run kajiya in any way (even on the lowest settings), or am I doing smth wrong?

Describe the bug It seems that interior areas are well lit and do not match the reference at all when at different world positions.

I am attempting to render a house and at the origin it renders correctly (according to the reference - light not coming through windows is a different issue)

Walking down the house (scale is 1 unit = 1m in case that makes a difference) there is a transition area where light is coming from "somewhere"

Here is the reference of that area

Until the front rooms are fully lit

Reference:

If I move the house in the scene file (say by 10m), the lit areas move around the house

I am guessing that perhaps there is some setting where interior lighting is only performed correctly at some small distance from the origin? Or perhaps there is some world light that starts at this position?

Let me know if it would be helpful to have the sample data - I will see if I can get permission to supply a cut down version.

Device:

• OS: Windows 10
• Version: Git sysnch of 10 January 2022

Describe the bug In assets/shaders/rt/gbuffer.rchit.hlsl, you computes the texture lod by using ray cone method. In function compute_texture_lod(), parameter takes surf_normal whichi is computed by the vertices data. But notice that the lod computation take place in world space, but the surf_normal you passes in is in object space. This will produce incorrect texture sample! (I test on my own impl in my toy engine)

Fix: add float3 surf_normal_ws = normal(mul(ObjectToWorld3x4(), float4(surf_normal, 0.0))); then use surf_normal_ws as the input in compute_texture_lod();

This will produce incorrect lod and strange banding effect depends on the view direction.

This is the correct image.

Is your feature request related to a problem? Please describe. — Currently, emissive materials cause a scene to be super noisy / boil-ey as area lights are unsupported. In dark / night scenes, this becomes quite apparent. Once resolved, dark / night scenes could look potentially stunning! This is particularly crucial for sci-fi scenes, and for fantasy scenes such as those with bioluminescent foliage, etc.

Describe the solution you'd like — Implement area light support; possibly with RTXDI or some variation thereof. I leave the details to the pros, but let me know how I can help if possible. ^__^

Bumps smallvec from 1.0.0 to 1.10.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Describe the bug Kajiya does not compile on macOS Monterey on M1 Air To Reproduce Steps to reproduce the behavior:

1. Clone main branch on m1 Mac
2. Run command:

cargo run --bin view --release

3. See error: could not find native static library kernelaarch64-apple-darwin, perhaps an -L flag is missing?

Expected behavior Kajiya compiles successfully on M1 Mac

Screenshots

Device:

• OS: macOS Monterey 12.3
• CPU - Apple M1
• RAM - 8GB
• Rust - rust 1.65.0 Nov 2nd - stable-aarch64-apple-darwin toolchain

Describe the bug When looking at the sun through a reflection, the sun's center has a black pixel. After attaching Nsight, I saw that the light_gbuffer.hlsl shader outputs inf for the pixel in the center of the sun's reflection.

I 'fixed' it by clamping the shader output between zero and a large value, but I don't properly understand all the PBR shader code so I don't know a more correct way of fixing it.

To Reproduce

1. Go to this commit on main: 6145eaaa1814047cc544be53adb8eb6cc348948d (the latest at the time of submitting this bug report)
2. Load a model with a mirror-like reflective surface (I used the car.ron scene)
3. Rotate the sun so that it's visible in the reflection
4. The sun has a dark spot in the center.

Expected behavior The sun's center should not have a darker spot like that.

Screenshots

Device:

• OS: Windows 11
• OS version: 21H2 build 22000.739
• GPU: 3080 Ti
• GPU driver version: 516.59
• rust version: rustc 1.64.0-nightly (ddcbba036 2022-06-29)
• cargo version: cargo 1.64.0-nightly (dbff32b27 2022-06-24)