I started giving types to the codebase using type hinting since python3.5 supports them and python3.5 is the minimum version required by the library.

I started with serializers and compressors.

I have some doubts about the client, specifically about key, version and prefix.

Redis supports everything that can be byte encoded like stated here https://redis.io/topics/data-types-intro

Redis keys are binary safe, this means that you can use any binary sequence as a key, from a string like "foo" to the content of a JPEG file. The empty string is also a valid key.

But other caches like memcached and django own BaseCache seem to point to key and prefix being a string and version an integer.

My question is, leaving Any instead of a more specific type or to enforce the types that I just mentioned?

By the way django-stubs here https://github.com/typeddjango/django-stubs/blob/master/django-stubs/core/cache/backends/base.pyi have specific types in some methods and on some not.

• split linters
• fixed cache hash
• added cache for lint job

From the redis-py release notes:

Only bytes, strings and numbers (ints, longs and floats) are acceptable for keys and values.

See https://github.com/andymccurdy/redis-py/blob/9b03af26dc829beea232a3248768de933f4c3b67/CHANGES#L9-L15

The CacheKey class used by django-redis is no longer supported.

I'm happy to open a PR, but I wanted to ask first if it's better to drop CacheKey or to cast keys to strings right before sending them to redis-py? The latter would be more work, but retain the intended use of CacheKey:

A stub string class that we can use to check if a key was created already.

I know that there were multiple requests, and most of them were denied since the primary author was not working with sentinel. Now that this project got passed to JazzBand, would it be possible to request sentinel support for this project?

pypi name is django-redis python package is redis_cache

there is another pypi package called django-redis-cache

Changes to GitHub actions:

• The service definition was duplicated on squash
• Merge lint and test workflow files into ci.yml
• Update for Django 3.2 and only test unreleased library versions with Python 3.9 to limit permutations
• Move redis sentinel startup to a script to more easily use in local development

Changes to README:

• Fix the GitHub badge definition

Changes to tests and testing environment:

• Move tox config to setup.cfg
• Remove runtest-*.py wrappers in favor of using runtest.py --settings=<settings>
• Move test settings into their own directory
• Fix unix socket tests

x-ref: https://github.com/ymyzk/tox-gh-actions/pull/60 will remove the need for lint-dj31-redislatest

Hi,

Since this package uses redis-py under the hood, I think it would be better to support the URL notation of the redis-py package directly in LOCATION instead of defining a new notation.

For example: django-redis: unix:/path/to/socket:1 redis-py: unix:///path/to/socket?db=1

django-redis: 127.0.0.1:6379:1 redis-py: redis://127.0.0.1:6379/1

redis-py URL notation:

redis://[:password]@localhost:6379/0
rediss://[:password]@localhost:6379/0
unix://[:password]@/path/to/socket.sock?db=0

Details here: https://github.com/andymccurdy/redis-py/blob/master/redis/connection.py#L733 There is no need to develop anything, the URL can just be passed to the redis client/connection pool.

What do you think?

Thanks

Hi,

Unfortunatelly or not i'm no longer using python on my daily job and right now i dont have time to maintain this package. So for not just abandon it, i'm looking for a new maintainer.

call the method disconnect of ConnectionPool instead of modifying protected attribute

Fixes version increment of keys with no expiration, that were previously wrongly deleted

fixes: #483

Due to a poorly configured socket_timeout for the connection to the sentinels, the connection may hang for many seconds or even minutes when one ore more of the configured sentinels are down. Then the django cache hangs for the same time causing http timeouts for users. This is bad, as the purpose of using sentinels is that something can go down without the user noticing.

A workaround is setting OPTIONS["SENTINEL_KWARGS"] = {"socket_timeout": 1}.

I think we should set a better default. ( It seems the current default is somewhere around 30 seconds, which means with two offline sentinels it would be around 60 seconds of hang. According to redis-py the default is gotten from the connection_kwargs, but I do not know where that is set)

It should at least be documented.

Many times people open issues for issues not related to bugs but for knowing how to use the library, I suggest to add some disclaimers in the issue template for looking for answers elsewhere, like stackoverflow, and also add tags to the issues automatically, like question, bug and so on.

I've uploaded my project on Heroku. Settings in the settings.py are as per the docs.

CACHES = {"default": {"BACKEND": "django_redis.cache.RedisCache","LOCATION": os.environ.get('REDIS_URL'),"OPTIONS": {"CLIENT_CLASS": "django_redis.client.DefaultClient",}}}

However when I load a view function with "@cache_page" decorator, I get the error :

  Error while reading from socket: (104, 'Connection reset by peer'). The Images of error report are attached. Pictures are numbered in sequence. Same error is also displayed when I run the following in the shell

from django.core.cache import cache cache.set("foo", "value", timeout=25)

This too throws a connection error. Please suggest how to overcome this error!

Just so if there will be any issues we can tackle them and be ready for when it will be out of beta

This issue is to investigate how much config is needed to configure towncrier or a similar tool to generate the release notes instead of manually generating them.

An investigation in the form of a PR will be evaluated for its complexity, and upon approval will become part of the PR process, shifting the burden of release notes to happen during the PR review (this could still be added/adjusted by a maintainer instead of the original author, but at least the notes happen when the PR happens).

In the current version, the master name is the redis url host. This PR kept it as the default but a SERVICE_NAME configuration parameter allows specifying it.

The Sentinel part of the readme was also fixed and updated but the code block is still not displayed in the github main page. It seems to be related to the caption option as some other code blocks with caption are not displayed either.

I can't not notice how other clients do not have certain methods that are in DefaultClient I suggest to create issues for making them complaint and adding a not supported or implemented exception where needed.

@terencehonles what do you think?

Of course the question is open to everybody that wants to contribute

Hi guys,

i wanted to ask if there is the option to use an existing connection pool? I have redis-py already in place for huey and would love to pass in my SentinelConnectionPool to django-redis as well. So I need to define it once and can share it across all redis dependend clients.

e.g. this is how it looks for huey

 'connection': {
        'connection_pool': SentinelConnectionPool(service_name="mymaster",
                                         sentinel_manager=sentinel.Sentinel([("localhost",26379)],
                                                                            password="XXXXXXX",
                                                                            socket_timeout=10,
                                                                            sentinel_kwargs={"password": "XXXXX"})
                                         ),
    },

By converting unittest class base tests to pytest function based tests we can use some nifty features of pytest such as fixtures* and parameterization :tada:

See: https://docs.pytest.org/en/stable/unittest.html#pytest-features-in-unittest-testcase-subclasses

Example of what needs to be done: #520

This may be what's needed for https://github.com/jazzband/django-redis/issues/430#issuecomment-812165986 as it was cribbed from another jazzband project.

Anything more @jezdez ? Are there steps to get branch protection rules in place? Is the GitHub secret set per repo or for the org?