This shouldn't be merged yet, I'm just putting this up as a draft PR so that anyone who wants to update to bevy main can see that the work is already done.

includes #3

I have just added env_logger::init(); to the simple.rs example and I'm getting the following message every frame:

[2021-10-04T09:17:50Z ERROR gfx_backend_vulkan]
    VALIDATION [UNASSIGNED-CoreValidation-DrawState-QueueForwardProgress (-400166253)] : Validation Error: [ UNASSIGNED-CoreValidation-DrawState-QueueForwardProgress ] Object 0: handle = 0xea7170000000031, type = VK_OBJECT_TYPE_SEMAPHORE; Object 1: handle = 0x1e5f980a668, type = VK_OBJECT_TYPE_QUEUE; Object 2: handle = 0x1e5f980a668, type = VK_OBJECT_TYPE_QUEUE; | MessageID = 0xe825f293 | vkQueueSubmit(): pSubmits[0].pSignalSemaphores[0] is signaling VkQueue 0x1e5f980a668[] (VkSemaphore 0xea7170000000031[]) that was previously signaled by VkQueue 0x1e5f980a668[] but has not since been waited on by any queue.
    object info: (type: SEMAPHORE, hndl: 1055837926409109553), (type: QUEUE, hndl: 2087245096552), (type: QUEUE, hndl: 2087245096552)

Here's my setup. Dependencies:

bevy = "0.5.0"
bevy_egui = "0.7.0"
env_logger = "0.9.0"

compiler: rustc 1.57.0-nightly (9dbb26efe 2021-10-03) OS: Windows 10 GPU: GeForce GTX 1050 Ti GPU driver: NVIDIA 472.12

Let me know if I can provide any further information to help reproduce.

Today I tried updating both bevy and bevy_egui to their latest versions. Suddenly, in my UI system, I can no longer get the context for the primary window. The code looks like this:

pub fn ui(
    egui_ctx: ResMut<EguiContext>,
    // other stuff...
) {
    let ctx = egui_ctx.ctx(); // crashes
    
    // other stuff...
}

Oddly enough the example code seems to work just fine. I have no idea which interactions within the code might be causing the crash. I can upload the full code if it helps.

I would like to globally modify some egui visuals, I tried using this

fn ui_setup(egui_context: ResMut<EguiContext>) {
    egui_context.ctx().set_visuals(egui::Visuals {
        window_shadow: Default::default(),
        ..Default::default()
    });
}

as a startup system. (Just added this to the simple.rs example.) Unfortunately, this results in a panic:

thread 'main' panicked at '`EguiContext::ctx()` called before the ctx has been initialized. Consider moving your UI system to `CoreStage::Update` or run you system after `EguiSystem::BeginFrame`.'

The message here seems to be relevant to regular systems, but not to startup systems. How do I ensure that my startup system runs after the context has been initialized?

I would like to build an editor-style application with an egui-rendered panel next to a view of my in-game world. Right now, the closest example I could find to that is two_windows.rs which spawns a window on top of a bevy camera. I don't really want to use a window, I just a panel docked to one (ideally, both) sides of the screen with a bevy camera drawing the middle.

Is this even possible with egui? Do I need to install a Frame, maybe? If you can point me towards the right solution - and if I get it working - I'll contribute back an example.

I have a situation where I would like to use a Table widget. This is not built into the released version of egui right now, but seems as though a recent merge to master has provided some basic functionality. Is there a way (without forking bevy_egui) that I can get bevy_egui to use the GIT version of egui? Right now it seems as though it is hard coded.

See discussion at https://github.com/emilk/egui/issues/296 and https://github.com/emilk/egui/pull/963 for more details.

Possibly adding a feature flag for a specific git branch of egui would be nice.

Hey, not sure if this is on bevy_egui's end or if I'll have to chase it through egui. I updated https://github.com/ndarilek/bevy_egui_a11y to work on Bevy 0.6. Formerly, pressing tab moved focus once. Now it seems to move focus rapidly.

It seems like some of these events are being triggered on hold rather than just on press. Focus should only move once when I press tab.

Thanks!

This is more of a question than an issue. In my application, I currently have various parallel systems showing different windows. Most times they work just fine, but they occasionally provoke a startup crash, so I wonder if this is a limitation or a bug.

The first few lines of the startup crash error message:

thread 'main' panicked at 'already mutably borrowed', C:\Users\vi\.cargo\registry\src\github.com-1ecc6299db9ec823\atomic_refcell-0.1.7\src\lib.rs:151:23
stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53\/library\std\src\panicking.rs:493
   1: core::panicking::panic_fmt
             at /rustc/9bc8c42bb2f19e745a63f3445f1ac248fb015e53\/library\core\src\panicking.rs:92
   2: core::panicking::panic_str
             at C:\Users\vi\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\panicking.rs:57
   3: atomic_refcell::AtomicRefCell<egui::memory::Memory>::borrow_mut<egui::memory::Memory>
             at C:\Users\vi\.cargo\registry\src\github.com-1ecc6299db9ec823\atomic_refcell-0.1.7\src\lib.rs:151
   4: epaint::mutex::Mutex<egui::memory::Memory>::lock
             at C:\Users\vi\.cargo\git\checkouts\egui-5e4507fa4153be06\effd3c7\epaint\src\mutex.rs:144
   5: egui::context::Context::memory
             at C:\Users\vi\.cargo\git\checkouts\egui-5e4507fa4153be06\effd3c7\egui\src\context.rs:378
   6: egui::context::Context::style
             at C:\Users\vi\.cargo\git\checkouts\egui-5e4507fa4153be06\effd3c7\egui\src\context.rs:443
   7: egui::containers::window::{{impl}}::show_impl::{{closure}}
             at C:\Users\vi\.cargo\git\checkouts\egui-5e4507fa4153be06\effd3c7\egui\src\containers\window.rs:255
   8: core::option::Option<egui::containers::frame::Frame>::unwrap_or_else<egui::containers::frame::Frame,closure-0>
             at C:\Users\vi\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\option.rs:427
   9: egui::containers::window::Window::show_impl
             at C:\Users\vi\.cargo\git\checkouts\egui-5e4507fa4153be06\effd3c7\egui\src\containers\window.rs:255
  10: egui::containers::window::Window::show<closure-0>
             at C:\Users\vi\.cargo\git\checkouts\egui-5e4507fa4153be06\effd3c7\egui\src\containers\window.rs:236

Use EventReader directly, which was made possible by https://github.com/bevyengine/bevy/pull/1244.

This should not be merged before the release of Bevy 0.5, as it needs at least commit https://github.com/bevyengine/bevy/commit/a880b5450829411b0248e47cc066915234371d86 to work.

One test is failing, but i am not sure if it has something to do with my changes. I tested this in one of my project and it works just fine.

running 2 tests
test src\lib.rs - EguiSettings::scale_factor (line 100) ... ok
test src\lib.rs - (line 23) ... FAILED

failures:

---- src\lib.rs - (line 23) stdout ----
Test executable failed (exit code 101).

stderr:
thread 'Compute Task Pool (2)' panicked at 'assertion failed: pixels_per_point > 0.0', C:\Users\...\.cargo\registry\src\github.com-1ecc6299db9ec823\epaint-0.8.0\src\text\font.rs:76:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'task has failed', C:\Users\...\.cargo\registry\src\github.com-1ecc6299db9ec823\async-task-4.0.3\src\task.rs:368:45



failures:
    src\lib.rs - (line 23)

test result: FAILED. 1 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.15s

Added demonstration how to use egui::Window::open(self, &'open mut bool). Since I am a newcomer to rust I have been struggling with passing a mutable bool. Should be useful for other newcomers as well since closing or opening a window is such a common use case.

Hope that helps.

I currently have an app with an egui::SidePanel on the left and an egui::TopBottomPanel on the bottom. This is working great. Now if I go to Bevy and add an obj file and render it, I can see that the panels are simply drawn on top of the scene rendering context. What I would like is for the the rendering scene to fill the space that is not covered by the panels. So, shifted to the upper right area of the window, in this way, the world point (0, 0, 0) would be at the center of the un-paneled space. (does this make sense)

I am not sure how to make this adjustment, I have been going though the Bevy docs but did not see anything there. Thought it might be in one of the bevy_egui examples but it does not seem so.

Can this be done? If so, can you add some documentation to point peeps in the right direction? :).

Fixes #136.

Because of some driver quirks, Bevy will ignore swapchain timeouts on some devices, as mentioned in bevyengine/bevy#5957. When this occurs, extracted_window.swap_chain_texture will be None.

Bevy handles this by bailing out of the render node early (see here), and this fix is implemented in the same way.

bevy_egui = "0.17.1"

Though it's able to be compiled, ui.rs at line 124, Clippy report: mismatched types [E0308] expected RangeInclusive<&mut UiState>, found RangeInclusive<f64>.

This is probably because UiState.value has the same name as ResMut.value. Change UiState.value to UiState.value_1 solves the error.

I've ran into a panic on linux/gnu running cargo run --release:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/daniel/.cargo/registry/src/github.com-1ecc6299db9ec823/bevy_egui-0.17.1/src/egui_node.rs:332:79

The UI Code is pretty minimal in a fresh project:

fn ui_example(mut egui_context: ResMut<EguiContext>) {
    let gitlab_store = GitlabStore::fetch_updated();
    egui::Window::new("Event Counter")
        .resizable(true)
        .show(egui_context.ctx_mut(), |ui| {
            ui.label(format!("Builds: {}", gitlab_store.builds.len()));
            ui.label(format!("Deployments: {}", gitlab_store.deployments.len()));
            ui.label(format!("FeatureFlags: {}", gitlab_store.feature_flags.len()));
            ui.label(format!("Issues: {}", gitlab_store.issues.len()));
            ui.label(format!("MergeRequests: {}", gitlab_store.merge_requests.len()));
            ui.label(format!("Notes: {}", gitlab_store.notes.len()));
            ui.label(format!("Pipelines: {}", gitlab_store.pipelines.len()));
            ui.label(format!("Pushs: {}", gitlab_store.pushs.len()));
            ui.label(format!("Releases: {}", gitlab_store.releases.len()));
            ui.label(format!("WikiPages: {}", gitlab_store.wiki_pages.len()));
        });
}

The bevy version is "0.9" and bevy_egui is "0.17.1".

The crash happened after letting the application run for a few minutes and leaving it unattended.

The following "on update system" works well on desktop. Unfortunately, on mobile I cannot get it working properly. It seems like clicks/taps are not recognized so even I create other elements such as sliders, dropdowns, ... and try to tap them, nothing happens.

fn update_menu(mut egui_context: ResMut<EguiContext>) {
    egui::containers::Area::new("main_container").show(egui_context.ctx_mut(), |ui| {
    ui.button("click me");
...

These are my dependencies

[dependencies.bevy]
version = "0.9.0"
default-features = false
features = [
  "render",
  "bevy_asset",
  "png",
  "x11"
]

[dependencies.bevy_egui]
version = "0.17.1"
default-features = false
features = [
  "default_fonts"
]

As far as I have seen in https://github.com/rust-windowing/android-ndk-rs, egui should work on android so what am I missing here? (I'm using cargo apk to build the android package)

Hi guys, the code snippet below is not working, what should I do to make it work?

egui::Window::new("Hello").show(egui_context.ctx_mut(), |ui| {
    let response = ui.label("world");
    let response = response.interact(egui::Sense::click());
    if response.clicked() {
      println!("Click!");
    }
});