Error description When executing an invalid query there is no feedback to the user that something went wrong. The result tab just shows the result of previous query. Also in the log tab, there is no indication that something went wrong.

An invalid query can be

• a wrong SQL statement
• valid SQL but with wrong table name

Expected behavior Some kind of error message/warning. Maybe for beginning, it is possible to show the error message from DataFusion itself?

Add ~/.datafusion/table_providers/bigtable.json which stores configuration options to create TableProvider and add optional BigTable feature. Tables defined in bigtable.json are loaded at startup.

Config fields comes from the below plus a table name field.

let bigtable_datasource = BigtableDataSource::new(
    "emulator".to_owned(),                               // project
    "dev".to_owned(),                                    // instance
    "weather_balloons".to_owned(),                       // table
    "measurements".to_owned(),                           // column family
    vec!["_row_key".to_owned()],                         // table_partition_cols
    "#".to_owned(),                                      // table_partition_separator
    vec![Field::new("pressure", DataType::Utf8, false)], // qualifiers
    true,                                                // only_read_latest
).await.unwrap();

Few unit tests for testing the functionality in the editor tab. Right now, 4 tests out of (new) 8 are failing. 2 of them are related to handling of non-ascii characters. 2 are user-experience-related and are not that important (when in the beginning/end of the line, the cursor should jump to previous/next line when left/right buttons are pressed).

@seryj FYI adding page up/down and i did try shift+enter but im having trouble with it(the KeyModifier::SHIFT isnt being recognized for some reason). will need to come back to it or table for now.

First of all, thanks for creating and working on this project! A good graphical interface will definitely help a lot of people in the future!

Now, to my issues. While playing around, there were several situations when the application crashed/or behaved wrongly/not-expected in the editor window.

Crashes:

1. When using non-ascii characters (like German "umlaut" character ä, ö, ü), the application crashes when such a character is deleted. The issue is that non-ascii chars consume more then 1 byte but currently all operations in the editor directly change the bytes inside of the string (Lines) object.
2. When the editor is opened and there is no text inside, moving the cursor crashes the application.

Wrong behavior:

1. When typing a character inside a line, the character appears in the end of the line. (I think this one was already fixed)

Usability issues:

1. In the end of the line, when moving a cursor to the right, the cursor stays in the same line instead of jumping to the next one
2. In the beginning of a line, when moving a cursor to the left the cursor stays in the same line instead of jumping to the previous one
3. End/Home buttons do not work

While all issues except for non-ascii handling are not that big, handling non-ascii characters requires a re-implementation of almost all functions of the Editor object because direct changing of a byte inside the String object does not work anymore and one has to use Chars instead.

This being said, I can offer an PR where above mentioned issues are addressed and appropriate unit tests are provided. But of course only if contribution to this project is desired. Alternatively, I could provide an PR with unit tests only. Whatever you prefer.

Best regards

When entering a single line of text, creating multiple new lines with enter, and then backspace to first line. Cursor also doesnt show at right position when going back to first line.

I wonder if one needs a semicolon at all. Right now, the editor always contains a single query and unless this changes in the future, having a semicolon is only required to recognize that the user wants to execute a query. Thinking about other tools, the same problem is often solved by using another key combination e.g. "shift+enter". Could that maybe be a more user-friendly solution?

On the pro-side, if chosen carefully, this "execute query" key combination could be used in the normal and edit modes such that the users will do less mistakes.

On the contra-side, the complexity of key handling increases.

How do you see it?

Originally posted by @seryj in https://github.com/datafusion-contrib/datafusion-tui/issues/73#issuecomment-1094371360