The example listed in https://actix.rs/book/actix/sec-2-actor.html#complete-example does not build for me. I saw two problems:

• I had to update the Cargo.toml file to include a dependency on the futures crate.

• I see the following compiler error after adding the dependency on the futures crate:

  Compiling actor-ping v0.1.0 (/home/akhi/projects/actor-ping)
warning: unused import: `futures::Future`
 --> src/main.rs:2:5
  |
2 | use futures::Future;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

error[E0599]: no method named `map` found for type `actix::address::message::Request<MyActor, Ping>` in the current scope
  --> src/main.rs:52:14
   |
52 |             .map(|res| match res {
   |              ^^^ method not found in `actix::address::message::Request<MyActor, Ping>`
   |
   = note: the method `map` exists but the following trait bounds were not satisfied:
           `&mut actix::address::message::Request<MyActor, Ping> : futures::stream::Stream`
           `&mut actix::address::message::Request<MyActor, Ping> : std::iter::Iterator`
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
1  | use futures::future::Future;
   |

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
error: could not compile `actor-ping`.

To learn more, run the command again with --verbose.

The version I am using is:

$ cargo --version
cargo 1.41.0

This is the first PR towards closing #44. My goal is to update all the sections/pages of the book. After this PR is merged I'll submit different PRs for the rest of the pages.

The example in arbiter chapter does not compile.

I'm compiling on rust nightly rustc 1.43.0-nightly (8aa9d2014 2020-02-21)

warning: unused import: `futures::Future`
 --> src/main.rs:4:5
  |
4 | use futures::Future;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

error[E0599]: no method named `map_err` found for struct `actix::prelude::Request<SumActor, Value>` in the current scope
  --> src/main.rs:63:10
   |
63 |         .map_err(|e| {
   |          ^^^^^^^ method not found in `actix::prelude::Request<SumActor, Value>`
   |
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
3  | use crate::futures::TryFutureExt;
   |

error[E0599]: no method named `map` found for struct `actix::prelude::Request<DisplayActor, Display>` in the current scope
  --> src/main.rs:74:41
   |
74 |             dis_addr.send(Display(res)).map(move |_| ()).map_err(|_| ())
   |                                         ^^^ method not found in `actix::prelude::Request<DisplayActor, Display>`
   |
   = note: the method `map` exists but the following trait bounds were not satisfied:
           `&mut actix::prelude::Request<DisplayActor, Display> : std::iter::Iterator`
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
3  | use crate::futures::FutureExt;
   |

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0599`.
error: could not compile `actix-middleware-tryout`.

To learn more, run the command again with --verbose.

Tried adding suggested use statements, but no luck.

warning: unused import: `futures::Future`
 --> src/main.rs:4:5
  |
4 | use futures::Future;
  |     ^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

error[E0599]: no method named `map_err` found for struct `futures::future::Map<actix::prelude::Request<DisplayActor, Display>, [closure@src/main.rs:76:45: 76:56]>` in the current scope
  --> src/main.rs:76:58
   |
76 |             dis_addr.send(Display(res)).map(move |_| ()).map_err(|_| ())
   |                                                          ^^^^^^^ method not found in `futures::future::Map<actix::prelude::Request<DisplayActor, Display>, [closure@src/main.rs:76:45: 76:56]>`
   |
   = note: the method `map_err` exists but the following trait bounds were not satisfied:
           `&futures::future::Map<actix::prelude::Request<DisplayActor, Display>, [closure@src/main.rs:76:45: 76:56]> : futures::TryFutureExt`
           `&mut futures::future::Map<actix::prelude::Request<DisplayActor, Display>, [closure@src/main.rs:76:45: 76:56]> : futures::TryFutureExt`
           `futures::future::Map<actix::prelude::Request<DisplayActor, Display>, [closure@src/main.rs:76:45: 76:56]> : futures::TryFutureExt`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
error: could not compile `actix-middleware-tryout`.

To learn more, run the command again with --verbose.

I noticed the Getting Started section still uses Actix 0.8 and Futures but the ping example has moved on to use the newer async await standard without Futures.

I did run cargo test before committing and there's one outstanding failed test for sec-1:

test sec_1_getting_started_sect_ping_actor_line_115 ... FAILED
warning: struct is never constructed: `Ping`
 --> /tmp/rust-skeptic.Is0iZA6jfrsE/test.rs:5:1
  |
5 | struct Ping(usize);
  | ^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(dead_code)]` on by default

I'm not entirely sure, but I think this test failed due to skeptic.rs not being able to grok the new await syntax so it thinks the Ping struct wasn't used.

This is my first Rust-related PR so let me know if there's anything I missed! I would greatly appreciated the guidance!

Right now this is kind of redundant on #24 for the README. Once that's pulled, the PR will look cleaner and only one file will have changed.

Mostly this PR encompasses 2 major changes to the Arbiter page:

• Describes the event loop that Actix/arbiters use
  • I speak maybe too specifically to people who are familiar with JS because that's me and this is the way it made clearest sense to me.
  • I could be totally wrong. Part of this PR is a question: Is this the way it works?
• Make example much cleaner and more user friendly with more comments and explanation.
  • I spend perhaps too much time explaining the Futures aspect, but I think a lot of people who are new to Actix are also at least somewhat new to Futures. This is Rust: everyone's new to everything. So I erred on the side of over-explaining.

This improves the context chapter of the actix box, to have a function mailbox capacity example, and adds examples for stop and address in the context.

Author: William Brown [email protected]

As discussed in a previous actix-web thread on errors [1], it might be nice to add a little more flavor to the user guide on error handling, with some focus on recommended practices.

This patch makes a few changes:

1. Adds a "Recommended practices in error handling" section with a few more ideas on how errors might be effectively used in a real application.
2. Adds a "Compatibility with failure" section.
3. Rewrites most of the other sections for clarity/succinctness.

[1] https://github.com/actix/actix-web/issues/197

cc @fafhrd91

So these tests were disabled about a year back in 2db214f and it actually resulted in the book getting broken unnoticed (see #33). I suggest re-enabling these tests. They were apparently broken due to travis failures.

This is documentation of streams in actix, using an echo server to demonstrate their usage.

This is a WIP with the intent of @rivertam to review pending other reviews.

Today there are three review points

• How to make urls proper links?
• What are the cause of the compilation errors in cargo test of the book?
• Wording and docs review

TODO:

• Add TLS echo example

Here it shows to exactly the same code snippets saying

Same example, but returned address is thread safe and can be sent to different thread.

which is probably wrong.

This is pretty rough and incomplete, but better than nothing. Let me know if anything is incorrect or needs to change. I did my best to cross reference the latest code to make sure it's truthful.

ATTENTION maintainers: several of the examples need your expert opinion - they are currently panicking with

thread 'main' panicked at '`spawn_local` called from outside of a `task::LocalSet`', .cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.19.2/src/task/local.rs:306:18

• Update to latest Actix
• Fix build instructions
• Mark several tests as failing to avoid confusing users

Hello!

We love actix actor framework and we've been using it in our production development for an year now. We've been using the registry functionality in our code, and mostly been reading the API documentation and the code to figure out how to use the features, but it would be really nice if these features were explained by the developers in the user guide.