1. Report if any address fails to bind

::actix_web::HttpServer::bind() fails if and only if ALL the requested addresses fail to bind! an the docs require multiple calls for multiple addresses.

2. Fix: faulty bahvior when setting -i 0.0.0.0

Currrently, 0.0.0.0 address is converted into 127.0.0.1!

Closes #470

3. Fix: On Windows, miniserve binds only to localhost(127.0.0.1) by default

This is in part because of the issue mentioned above, and also because binding to :: binds only to IPv6 by default on Windows!

Closes #405 Also reported by @KaneGreen in #470.

4. cross-platform default binding addresses

Currently, miniserve by default binds to both 0.0.0.0 and :: ant the same time. This behaviour has a problem:

On some platforms (e.g. majority of linux distros and OSX?) , the :: address also accepts ipv4 connections. This makes these two addresses incompatible! See https://stackoverflow.com/questions/1618240/how-to-support-both-ipv4-and-ipv6-connections

~I currently have no idea how this should be fixed!~

5. implement #422

Closes #422

Error pages should now follow the query parameters the user had before. So, this respects the theme, but also the potential sorting parameters the user had (this is useful when using the go back to file listing link). Also, I implemented Copy for some of our enums, as it greatly reduce the boilerplate and makes the code more readable, I think.

This is my WIP for file uploading #6

I would like to clean up my error handling and discus some ideas.

• if we can upload files, maybe I should add option to delete files too
• Is it ok to override existing files?
• I think the ability to upload file should be behind CLI flag and not by default

I've tested my code only under linux, but it seems ok.

Fixes https://github.com/svenstaro/miniserve/issues/859

Suggestions are welcome, I'm only implemented the basic render for now.

Other things that might be needed:

• user flag to turn on/off readme rendering
• render html bits inside markdown (might to be fixed from markdown crate)
• other formats besides .md (.txt and , maybe .org)

Hi there!

I've been using Miniserve for a quite a bit now, and I'm really enjoying this tool. But I find it misses a feature I'd personally would love to see: video streaming.

If I go the URI of a picture for instance it will be displayed by the browser correctly. But if it's an ~~video~~ audio file (e.g. MP~~4~~3) it will be downloaded instead of being played.

Would it be possible to implement support for these formats? I have no idea if it would be complicated, just thought I'd throw the idea here :)

Currently it's not easily possible to use wget to download a folder served with miniserve because the rendered directory listing contains links for the different .tar options, themes and whatnot.

• This implements a raw view which can get accessed via http://.../somedir/foo/?raw and is a stripped down html version
• Besides this it also implements a new ui element which contains a generated wget command to download this folder via wget

This is probably a hackish attempt, but works quite well. If there's a chance of this feature getting merged, i would overhaul it, add integration tests and whatnot.

Fix https://github.com/svenstaro/miniserve/issues/85

An additional issue arises: cargo test warns me of unused items in helper module. This happens because the items are only used by test functions in test-only context. I don't know how to fix this other than #[allow(dead_code)].

This has the benefit of showing the size and modification date of the pointed-to file. Symlink to directories now respects '--dirs-first' option and broken symlinks don't show up in directory listing.

The only downside AFAIK is more syscalls when listing directories.

@svenstaro Any input on this? should it be configurable? can we abandon the symlink symbol?

This is my WIP for solving #2 (only .tar.gz at the moment).

The code isn't quite clean, the error handling needs some more work, and I have a bug on Mac OS X because user folders are wierd symlinks, and it causes the current code to fail. I'm investigating this issue.

Otherwise, it works pretty well :)

Start addressing #156

~~Do you know where I should consume this option and how to configure active-web to serve the file? I started modifying fn configure_app( but couldn't figure out how to make it serve an index.html from within a configured directory root.~~

So, here is my WIP to solve #51, and in a more general way, have different colour schemes. At the moment, I implemented 3 dark themes since I'm more comfortable designing them, but I'll eventually come up with a light theme (or multiple ones, if needed), I just have to find a nice way to make the colours fit together...

I also did several improvements to the CSS in general (padding, back to top button bigger, and only visible on small screen (I can set it back if needed), etc). Also, I prepared the moment when we'll have several compression methods available. Download buttons should fit nicely next to each-other.

I am open to any changes when it comes to the colours, or the design in general. Let's use this PR to fix everything that you don't like design-wise :)

Bumps grass from 0.12.0 to 0.12.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Hi all, I have a public-facing instance of Miniserve running at home and I've noticed that I often get flooded with requests for random files in my directories by Googlebot. (including requests for zipped download of entire directory)

I would love it if miniserve either by default, or through a switch, served a static robots.txt that disallows crawling by bots.

Google Developers has an example of how to formulate a robots.txt that disallows crawling here.

If there's some interest I don't mind trying to implement it myself but it would have to be in a few days.

Open to suggestions!

I am attempting to run miniserve as a Docker container on Apple Silicone (M1 Pro). Works fine on an x64 Mac but not on Apple Silicone.

When I run, it crashes with www exited with code 139 whether I use Docker Compose or from CLI.

services:
  www:
    container_name: www
    image: svenstaro/miniserve
    #tty: true
    #restart: always
    volumes:
      - /www:/www
    ports:
      - "8080:8080"
    command: "--dirs-first --enable-tar --title www /www"

docker run -v /www:/www -p 8080:8080  -it docker.io/svenstaro/miniserve /www

Hi, I'm using miniserve on a Windows 10 laptop

When miniserve's path to serve is on C:\ disk, upload of file a/o directory creation works fine, and is possible, at least as soon as appropriate access rights are granted on local NTFS disk.

But if the path to serve is on another local disk (eg "miniserve D:\Temp\ -u -U" ), upload of files a/o directory creation systematically fail with the error message "Insufficient permissions to create file in \?\D:\Temp", and this even if full control has been granted to everyone at OS level in this target folder. On the other hand, it works "sometimes" even on disk D: For example, if I create a new folder D:\Test (at Win10 level), then launch "miniserve D:\Test -u -U", I'm able to upload files a/o create directories... while access rights are exactly the same at OS level for D:\Test and D:\Temp....

Moreover, in case access rights are NOT granted to users in target dir, upload and directory creation are (hopefully...) not possible, but the error message is not at all the same, but rather "Failed to create mysubdir / caused by: Accès refusé. (os error 5)", or "Failed to create \?\D:\Test\P1080514.JPG / caused by: Accès refusé. (os error 5)"

Adds a small check in render.rs make_link_with_trailing_slash to do nothing if link is empty, instead of adding a slash where its not needed.

It looks like nothing calls make_link_with_trailing_slash with an empty string aside from downloading when sorting, so this should not break anything else.

You can test the fix out here if needed: https://archive.vamist.dev/

Another alternative fix is to just not include sorting options when downloading, so if you would rather this, let me know.

Fixes #967

allow users to view various file in miniserve , images like png/jpg , media files like mp3/mp4/avi , and text files like yml/py/markdown what do you think ?