First of all thanks for the great tool!

I use oh-my-zsh with a bunch of plugins and I think this will be very nice to see the current running project without having to type bartib current. This helps with remembering that I need to switch projects.

Currently, the week report looks like this:

project........ 1d 3h 12m
    Task_1    8h 35m
    Task_2   18h 37m

Total....... 1d 3h 12m

To me, a report in hours makes more sense, but maybe it can be just configurable instead of just changing it to hours, with something like --format={days,hours}.

$ touch ~/activities.bartib
$ echo $BARTIB_FILE
~/activities.bartib
$ bartib start -p "proj" -d "act"
Started activity: "act" (proj) at 2021-11-16 14:22
Error: Could not write to file: ~/activities.bartib

Caused by:
    No such file or directory (os error 2)

$ which bartib
/home/username/.cargo/bin/bartib

Context: cloned repository, used cargo install --path .

Hello Stranger from the internet,

with this pull request I propose a sanity check for the start- and endtimes of activities.

It checks for two things:

1. The endtime of an activity may not precede the starttime.
2. An activity may not start before the previous one ended.

Errors are reported in bartib check. Additionally a warning is printed whenever the list of activies is parsed.

Big thanks for the project und bis Morgen !

The current output of bartib help start makes it seem like the project and the description are optional, but they aren't. If you try to run bartib start -d "Description", bartib replies with a panic. I had to go to the source code to understand what was happening.

❯ bartib start -d "Description"                                    
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /home/italo/.cargo/registry/src/github.com-1ecc6299db9ec823/bartib-1.0.0/src/main.rs:207:58          
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace  

You can fix this by marking the arguments as required on clap, or at least print a nice message explaining the problem.

Please see the output:

$ RUST_BACKTRACE=full bartib start -d "checking some github stuff"
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', src/main.rs:207:58
stack backtrace:
   0:     0x557ece2b6580 - std::backtrace_rs::backtrace::libunwind::trace::h25e12e0d899beba0
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/../../backtrace/src/backtrace/libunwind.rs:90:5
   1:     0x557ece2b6580 - std::backtrace_rs::backtrace::trace_unsynchronized::h70e61195d6ae3df6
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x557ece2b6580 - std::sys_common::backtrace::_print_fmt::hba93ab80d779695a
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/sys_common/backtrace.rs:67:5
   3:     0x557ece2b6580 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hf092b5883b4b2e50
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/sys_common/backtrace.rs:46:22
   4:     0x557ece2d275c - core::fmt::write::hf68bc350a8f2f0dc
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/core/src/fmt/mod.rs:1078:17
   5:     0x557ece2b38a2 - std::io::Write::write_fmt::hf66811b1bc767436
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/io/mod.rs:1517:15
   6:     0x557ece2b8505 - std::sys_common::backtrace::_print::hd425a11bfe1f20f8
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/sys_common/backtrace.rs:49:5
   7:     0x557ece2b8505 - std::sys_common::backtrace::print::h6d678795c1e61e13
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/sys_common/backtrace.rs:36:9
   8:     0x557ece2b8505 - std::panicking::default_hook::{{closure}}::h78a02a4a0dee5e7e
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panicking.rs:208:50
   9:     0x557ece2b805a - std::panicking::default_hook::h56eb7eda02f355a7
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panicking.rs:225:9
  10:     0x557ece2b8ca1 - std::panicking::rust_panic_with_hook::hb27ea14285131c61
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panicking.rs:591:17
  11:     0x557ece2b87b7 - std::panicking::begin_panic_handler::{{closure}}::hc552fcee62aad17f
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panicking.rs:495:13
  12:     0x557ece2b6a3c - std::sys_common::backtrace::__rust_end_short_backtrace::hb9f0aa9a78e885a0
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/sys_common/backtrace.rs:141:18
  13:     0x557ece2b8749 - rust_begin_unwind
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panicking.rs:493:5
  14:     0x557ece2d1b31 - core::panicking::panic_fmt::h12ac4570ea43d06f
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/core/src/panicking.rs:92:14
  15:     0x557ece2d1a7d - core::panicking::panic::h72bd72f6f4a70105
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/core/src/panicking.rs:50:5
  16:     0x557ece2146f5 - bartib::main::h6a32311aa284d027
  17:     0x557ece215c33 - std::sys_common::backtrace::__rust_begin_short_backtrace::h0a40a47f68234f03
  18:     0x557ece215c4d - std::rt::lang_start::{{closure}}::h2170525524f8154e
  19:     0x557ece2b90c7 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h78040f802d89ccdc
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/core/src/ops/function.rs:259:13
  20:     0x557ece2b90c7 - std::panicking::try::do_call::h6853cad536dd09a1
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panicking.rs:379:40
  21:     0x557ece2b90c7 - std::panicking::try::h827495f03a9fbb9a
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panicking.rs:343:19
  22:     0x557ece2b90c7 - std::panic::catch_unwind::h4bdf17571090eb17
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/panic.rs:396:14
  23:     0x557ece2b90c7 - std::rt::lang_start_internal::h2f319c33bb013f29
                               at /rustc/cb75ad5db02783e8b0222fee363c5f63f7e2cf5b/library/std/src/rt.rs:51:25
  24:     0x557ece214c72 - main
  25:     0x7f3eb733ab75 - __libc_start_main
  26:     0x557ece2106ea - _start
  27:                0x0 - <unknown>
$ RUST_BACKTRACE=full bartib start -p leisure -d "checking some github stuff"
Started activity: "checking some github stuff" (leisure) at 2021-11-17 13:52
$ bartib --version
bartib 1.0.0

Problem Description

One small papercut while starting to use this tools was what arguments were really required to "start" a new task.

The current help for bartib start does not show any required arguments or flags:

bartib start -h
bartib-start
starts a new activity

USAGE:
    bartib start [OPTIONS]

FLAGS:
    -h, --help    Prints help information

OPTIONS:
    -d, --description <DESCRIPTION>    the description of the new activity
    -p, --project <PROJECT>            the project to which the new activity belongs
    -t, --time <TIME>                  the time for changing the activity status (HH:MM)

However, when I attempt to use as is, it of course needs some data to actually start an activity:

bartib start -d "test descr"
thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', ...
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Possible Solutions

Of course, there are multiple ways to help with this. Here are a few I thought of:

1. make description and project flags explicit through clap args
2. do input validation in the controller, likely around here: https://github.com/nikolassv/bartib/blob/master/src/controller/manipulation.rs#L29-L33
3. do input validation in Activity::start https://github.com/nikolassv/bartib/blob/master/src/data/activity.rs#L26
4. make only project arg required, default description to empty string (or other design related change)

I'm sure there are other ways but (1) seemed like the easiest so I sent a quick PR.

Testing

Validating new args have expected help after cargo build --release

start command help makes required args more explicit

./target/release/bartib start -h
bartib-start
starts a new activity

USAGE:
    bartib start [OPTIONS] --description <DESCRIPTION> --project <PROJECT>

FLAGS:
    -h, --help    Prints help information

OPTIONS:
    -d, --description <DESCRIPTION>    the description of the new activity
    -p, --project <PROJECT>            the project to which the new activity belongs
    -t, --time <TIME>                  the time for changing the activity status (HH:MM)

continue command args are unchanged

./target/release/bartib continue -h
bartib-continue
continues a previous activity

USAGE:
    bartib continue [OPTIONS] [NUMBER]

FLAGS:
    -h, --help    Prints help information

OPTIONS:
    -d, --description <DESCRIPTION>    the description of the new activity
    -p, --project <PROJECT>            the project to which the new activity belongs
    -t, --time <TIME>                  the time for changing the activity status (HH:MM)

ARGS:
    <NUMBER>    the number of the activity to continue (see subcommand `last`) [default: 0]

Validating required flag shows more helpful error message:

Error 1: no project provided

./target/release/bartib start -d "test"
error: The following required arguments were not provided:
    --project <PROJECT>

USAGE:
    bartib start [OPTIONS] --description <DESCRIPTION> --project <PROJECT>

For more information try --help

Error 2: no description provided

./target/release/bartib start -p "test"
error: The following required arguments were not provided:
    --description <DESCRIPTION>

USAGE:
    bartib start [OPTIONS] --description <DESCRIPTION> --project <PROJECT>

For more information try --help

Happy case: all args provided

./target/release/bartib start -p "test project" -d "test description"
Stopped activity: "write general SOP for all application levers" (availability lever SOP) started at 2021-11-16 18:17 (05m)
Started activity: "test description" (test project) at 2021-11-16 18:22

At first I thought --time, in this case, means the target time I wanted to finish the task so I set that to a time in future. Bartib (incorrectly?) accepted that. Then I stopped the task before that start time only to end up with end time earlier than start time.

Hey, could you please publish this at crates.io so installing it is as easy as cargo install bartib. Updating with cargo-update will be as easy as cargo install-update -a.

Thank you

bartib -f ~/Users/username/bartib_logger.bartib report
Error: Could not read from file: /Users/username/bartib_logger.bartib

Caused by:
    No such file or directory (os error 2)

1. I have created bartib_logger.bartib file in the home directory

Hi, I recently downloaded it from crates.io. I created the file and added the file directory to the BARTIB_FILE env variable. CMD gave me an OS Error 5 when executing

Hello everyone,

First of all thank you very much for making such a nice and simple time tracker. I only discovered bartib two days ago and have been loving it ever since. Although, it is overall quite a robust piece of software, I find myself missing two sub-commands. The first one would be an add command allowing the user to add a time entry by specifying a start and stop time. The second one is an export feature which outputs the activity log in either JSON format or CSV format. Thank you very much in advance and keep up the awesome work.