I am currently working on a create page feature to use in a program I'm writing to do more pleasant data entry.

This PR is a work in progress, I still need to write some tests (after I get my program working past the risk-of-abandonment stage).

Fairly straightforward copy of what the other code is doing, and works when used on pages with code examples.

text is a list of rich text objects, and language is an effectively unbounded list of potential languages, so string seemed preferable to an enum.

Rust newb here, Example app wasn't working because of the changes in clap. Library wasn't working too, at least part that was querying database. I also added get_page method which is minimal changes, everything for it was already read :) I also not found a way how to transfor string into DatabaseId or any other Identifier, so i modified macros a bit by adding FromStr method. Without these changes library is not currently usable.

I'm getting an error when using search():

JsonParseError {
    source: Error("missing field `format`", line: 1, column: 1425),
}

My code:

use notion::models::search::NotionSearch;
use notion::NotionApi;
use std::env;

#[tokio::main]
async fn main() {
    let notion_api = NotionApi::new(env::var("NOTION_API_TOKEN").unwrap()).unwrap();
    let query: NotionSearch = {
        NotionSearch::Query(String::from("Movie Collection"))
    };
    let result = notion_api.search(query).await;
    match result {
        Ok(resp) => println!("{:#?}", resp),
        Err(err) => println!("{:#?}", err),
    }
}

Saved JSON from curl:

{
  "object": "list",
  "results": [
    {
      "object": "database",
      "id": "58be2827-5ca0-4cc4-85a8-ff656911df67",
      "created_time": "2021-03-07T19:20:00.000Z",
      "last_edited_time": "2021-07-11T22:04:00.000Z",
      "title": [
        {
          "type": "text",
          "text": { "content": "Movie Collection", "link": null },
          "annotations": {
            "bold": false,
            "italic": false,
            "strikethrough": false,
            "underline": false,
            "code": false,
            "color": "default"
          },
          "plain_text": "Movie Collection",
          "href": null
        }
      ],
      "properties": {
        "Watched": { "id": "<dji", "type": "checkbox", "checkbox": {} },
        "Cover": { "id": "VWBk", "type": "files", "files": {} },
        "Type": {
          "id": "]iu{",
          "type": "select",
          "select": {
            "options": [
              {
                "id": "522ab335-108c-4a92-a2d6-0aeee7b946c8",
                "name": "Blu-Ray",
                "color": "blue"
              },
              {
                "id": "12f11180-47bd-4c36-abb8-c84c35ade60c",
                "name": "Digital",
                "color": "green"
              }
            ]
          }
        },
        "Year": {
          "id": "jwIv",
          "type": "number",
          "number": { "format": "number" }
        },
        "Director": {
          "id": "~psh",
          "type": "select",
          "select": {
            "options": [
              {
                "id": "d1023a7a-52af-4c2f-aabf-cac75b59e9bd",
                "name": "Hirozaku Kore-eda",
                "color": "yellow"
              },
              {
                "id": "45bd4057-eddc-4bf2-be59-a693f4f81f05",
                "name": "Hayao Miyazaki",
                "color": "pink"
              },
              {
                "id": "a1a2896b-26f0-410b-8205-fda67c9edb99",
                "name": "Doug Liman",
                "color": "orange"
              },
              {
                "id": "f9854b2d-b913-454f-b18c-ce312fa1d9e4",
                "name": "Steven Soderbergh",
                "color": "green"
              }
            ]
          }
        },
        "Title": { "id": "title", "type": "title", "title": {} }
      },
      "parent": {
        "type": "page_id",
        "page_id": "2ffcd525-17b1-4606-93ff-e367eade9e66"
      }
    }
  ],
  "next_cursor": null,
  "has_more": false
}

I'm fairly new to Rust, but it seems like there's a mismatch in the property schema versus what's returned. If I delete this line the code runs successfully (albeit without the number's format): https://github.com/jakeswenson/notion/blob/9d5b84b88ddc2b7de1bc0f03d9026eb52e8976ac/src/models/properties.rs#L133

Or if I add:

#[derive(Serialize, Deserialize, Debug, Eq, PartialEq, Clone)]
pub struct NumberFmt {
    format: String
}

and change the line to number: NumberFmt that also works, this time with the number's format as a string. I couldn't get it to work with the existing NumberFormat enum.

Uses: https://docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target

This may be a bad idea... https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

Probably best to get pull_request working which means no secrets are available...

Description

Generic implementation of retrieving block information. I have yet to enumerate different fields for specific Block types.

Fixed some visibility issues for people using this client externally. Fixed an casing issue when deserializing Url types

Hello, usually it try to fix things myself, but this issue i don't have straight way how to fix. Please take a look at json returned by notion:

        "properties": {
    "Is Subscription": {
      "id": "%3E%7Dfd",
      "type": "checkbox",
      "checkbox": false
    },
    "Base Price": {
      "id": "AuNU",
      "type": "number",
      "number": 29.95
    },
    "Product Type Code": {
      "id": "R%7Cm%3F",
      "type": "rollup",
      "rollup": {
        "type": "array",
        "array": [
          {
            "type": "rich_text",
            "rich_text": [
              {
                "type": "text",
                "text": {
                  "content": "personal",
                  "link": null
                },
                "annotations": {
                  "bold": false,
                  "italic": false,
                  "strikethrough": false,
                  "underline": false,
                  "code": false,
                  "color": "default"
                },
                "plain_text": "personal",
                "href": null
              }
            ]
          }
        ],
        "function": "show_original"
      }
    },
......
}

Rollup contains an array, which contains PropertyValue. There are two issues: RollupValue exists that probably was meant to solve this issue, but it's not used anywhere. If i create property array and make it a Option<Vec>, i will have an issue. Rich text node does not have an ID. Making this field optional is not a good idea imho.

Please suggest how to better solve this issue, and i will be happy to implement and issue PR

Hello again :) This is small change that i found is required for my code to work properly. Url property can be returned as null, here is an example json returned by notion:

There are currently unfixable issues with chrono 0.4.19 in security audits... Until these are fixable they are just showing up as build failures Splitting this into its own workflow is probably the correct thing long term anyways

Description

Generic implementation of retrieving block information. I have yet to enumerate different fields for specific Block types.

Fixed some visibility issues for people using this client externally. Fixed an casing issue when deserializing Url types

Recreating PR to be a branch instead of fork.

Description

The search endpoint is the generic way to look for a particular resource within a Notion organization. Currently, the client is returning a Result<ListResponse<Database>, NotionApiClientError>. This makes an assumption that it is a Database when it could be a Page.

Documentation

In the API Reference, there are two results in the payload. The first contains the assumed object: database but the second has object: page.

Current Response

The client gives an Error when the result contains a Page:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error("missing field `title`", line: 1, column: 545)'

Expected Behavior

That you can successfully retrieve Database and Page objects via the search endpoint.

Hello! I have the following code, in a project where I don't need full user info, just the base (without the email). If I don't have the e-mail permission granted, the code crashes with the error below, but with the permission granted it successfully queries.

// The query
let results = notion_api
    .query_database(db, DatabaseQuery::default())
    .await?;

// The error without any user info beyond ID
Error: Error parsing json response: missing field `type`

Caused by:
    missing field `type`

// The error with user info without email
Error: Error parsing json response: missing field `email`

Caused by:
    missing field `email`

IMHO, those should either be optional, or on an enum/nested struct, and not require full permissions (otherwise, could it be mentioned in the README?)

It seems that there is only one implementation of filter_by_databases. Is there any need to add an implementation for filter_by_pages?

BTW, the API list_databases is departed, I got a 400 error when I use it.

ansi_term is Unmaintained

| Details | | | ------------------- | ---------------------------------------------- | | Status | unmaintained | | Package | ansi_term | | Version | 0.12.1 | | URL | https://github.com/ogham/rust-ansi-term/issues/72 | | Date | 2021-08-18 |

The maintainer has adviced this crate is deprecated and will not receive any maintenance.

The crate does not seem to have much dependencies and may or may not be ok to use as-is.

Last release seems to have been three years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

• anstyle
• nu-ansi-term
• yansi

See advisory page for additional details.

term is looking for a new maintainer

| Details | | | ------------------- | ---------------------------------------------- | | Status | unmaintained | | Package | term | | Version | 0.6.1 | | URL | https://github.com/Stebalien/term/issues/93 | | Date | 2018-11-19 |

The author of the term crate does not have time to maintain it and is looking for a new maintainer.

Some maintained alternatives you can potentially switch to instead, depending on your needs:

• crossterm
• termcolor
• yansi

See advisory page for additional details.

stdweb is unmaintained

| Details | | | ------------------- | ---------------------------------------------- | | Status | unmaintained | | Package | stdweb | | Version | 0.4.20 | | URL | https://github.com/koute/stdweb/issues/403 | | Date | 2020-05-04 |

The author of the stdweb crate is unresponsive.

Maintained alternatives:

• wasm-bindgen
• js-sys
• web-sys

See advisory page for additional details.