@ivanceras Hi.

I love this crate more than diesel but not contains mysql support so i added it.

The big issue

r2d2-mysql wants connection as mutable for execute query but current ｓignature of Database trait expects immutable. I added Database2, DBPlatform2 and EntityManager2 for keep API for postgres and sqlite. rust-postgres next varsion will be wanted mutable connection maybe (SEE).

I cloud not implement all of function of Database trait to Database2 trait. But i think it is enough for SELECT, INSERT, UPDATE and DELETE. I hope merge this PR and then implement other function in after.

Please tell me if there are mistake in my code or thinking.

Thank you!

I can’t compile Diwata because Rustorm is using an old version of the crate openssl: https://github.com/sfackler/rust-openssl/issues/987

Would it be possible to bump up the version of openssl in the depencecies?

This PR adds two modifications:

1. Add NaiveDateTime to Value conversion
2. Use local dependencies of dao and codegen. This is important because currently rustorm depends on crate.io distributed dao & codegen. This makes depending on the git branch impossible. Thus generally considered as anti-pattern.

By the way, [replace] is not used when rustorm is introduced as a lib dependency. So it's also removed.

This could help errors from this crate work better with general error handling crates.

Currently the most suitable solution would be using the thiserror crate. Or, we could manulay implement std::error::Error for all the errors exported from rustorm.

Which is your fav? I can make a PR based on the choice.

@ivanceras Hi! Thank you for merging my PR :D. But i got new problem :(.

We have defined several custom type such as Id(i64).

It can be used as query parameter if we defined impl rustorm::ToValue for Id.

impl rustorm::ToValue for Id {
    fn to_value(&self) -> rustorm::Value {
        rustorm::Value::Bigint(self.0)
    }
}

#[derive(Debug, FromDao)]
struct R {}

let _: Vec<R> = em
    .execute_sql_with_return("SELECT id FROM table id = ?", &[&Id(99)])
    .unwrap();

It can be used as result type if we defined impl From<&rustorm::Value> for Id.

impl From<&rustorm::Value> for Id {
    fn from(v: &rustorm::Value) -> Id {
        match v {
            rustorm::Value::Bigint(v) => Id(*v),
            _ => panic!("unable to convert"),
        }
    }
}

#[derive(Debug, FromDao)]
struct R {
    e: Id,
}

let _: Vec<R> = em
    .execute_sql_with_return("SELECT id FROM table", &[])
    .unwrap();

But we can't be used if it wrapted by Option because From and ToValue are external trait, and Option is external type.

The newtype pattern such as Id(i64) is general in Rust so I think it ’s worth making it available. I think need new trait such as FromValue for instead of From. But it's will makes broken changes.

What do you think the idea?

Hi.

We want to use enum as query result and parameter so we implemented traits to enum. But it does not work when contain in Option because From<Value> for Option<Enum> does not implemented . As you know we cannot implement the trait because Value and Option are outside crate both. I make Opt<Option<T>> and avoid it, are there more happy solution?

Example.

use rustorm::codegen::{ToColumnNames, ToDao, ToTableName};

#[derive(Debug)]
enum ExampleEnum {
    A,
    B,
}

impl rustorm::ToValue for ExampleEnum {
    fn to_value(&self) -> rustorm::Value {
        self.into()
    }
}

impl From<&ExampleEnum> for rustorm::Value {
    fn from(from: &ExampleEnum) -> rustorm::Value {
        match from {
            ExampleEnum::A => "a",
            ExampleEnum::B => "b",
        }
        .into()
    }
}

impl From<&rustorm::Value> for ExampleEnum {
    fn from(value: &rustorm::Value) -> Self {
        match value {
            rustorm::Value::Text(value) => match value.as_str() {
                "a" => ExampleEnum::A,
                "b" => ExampleEnum::B,
                _ => panic!("unkonwn value"),
            },
            _ => panic!("unspported type"),
        }
    }
}

// OK!
#[derive(Debug, ToDao, ToColumnNames, ToTableName)]
struct ExampleStruct {
    value: ExampleEnum,
}

// NG...
#[derive(Debug, ToDao, ToColumnNames, ToTableName)]
struct ExampleOptionStruct {
    value: Option<ExampleEnum>,
}

@ivanceras Hi.

I want to execute SQL that does not need return value like below.

UPDATE user set name = ? where id = ?

I looked for match to the objective, but i can't found it. What should I use?

Got a conflict between this and refinery because of mismatching versions so I updated rusqlite and r2d2_sqlite to the newest versions. All the tests still pass. :)

@ivanceras Hi!

Pool::em() calls ensure(), so it calls init_pool always finally for now. I thinks it's not necessary and happens problems sometime maybe.

Add support numeric value to bool conversion

Bool value be expressed as numeric value in MySQL.

Add support ToDato, ToTableName, ToColumnNames to borrowed field contained struct

We need insert values with borrowed value because we do not want to clone String. For example.

fn insert(mut em: rustorm::EntityManagerMut, message: &str) {
    #[derive(Debug, ToDao, ToTableName, ToColumnNames)]
    struct Row<'b> {
        message: &'b str,
    };

    em.single_insert(&Row { message }).unwrap();
}

mike@DESKTOP-IU99086:~/sappworks/rustorm$ cargo build
   Compiling rustorm v0.10.7 (/home/mike/sappworks/rustorm)
error[E0599]: no method named `safe_name` found for type `dao::TableName` in the current scope
  --> src/table.rs:29:19
   |
29 |         self.name.safe_name()
   |                   ^^^^^^^^^

error[E0599]: no method named `safe_complete_name` found for type `dao::TableName` in the current scope
  --> src/table.rs:33:19
   |
33 |         self.name.safe_complete_name()
   |                   ^^^^^^^^^^^^^^^^^^
   |
   = help: did you mean `complete_name`?

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0599`.
error: Could not compile `rustorm`.

To learn more, run the command again with --verbose.
mike@DESKTOP-IU99086:~/sappworks/rustorm$ rustc -V
rustc 1.30.0-nightly (63d51e89a 2018-09-28)

I was trying to use this but ran into issues with some of my columns having int and bigint arrays, tried to also hack around it by implementing FromValue myself but ran into more issues with Array::Int being only 32bits.

rustorm version: 0.17 rust version: 1.45.2

Attempting to use any of the derive macros provided by rustorm (ToDao, FromDao, ToTableName, ToColumnNames) will fail to compile with the following error message: error[E0433]: failed to resolve: use of undeclared type or module `rustorm_dao`

Adding rustorm_dao = "0.5" as a dependency in Cargo.toml fixes this but since rustorm_dao is already a dependency of rustorm and this is not mentioned anywhere in the readme I am guessing this isn't supposed to be the case? If this is expected, it should probably be mentioned somewhere.