Resolves #535.

Due to a bug in the current stable Rust compiler (https://github.com/rust-lang/rust/issues/44851), this fix won't work on a stable release until the next stable version. Thankfully this is only a few days away as version 1.23 is scheduled to be released on January 4, 2018.

I've tested this on OS X, Linux (Debian), and Windows (Server 2016) with cargo test and cargo test --features=rsa_signing. I've confirmed that all public symbols exported from compiled binaries are versioned on each of these platforms. The only caveat is that I'm getting a warning somewhere along the chain on Windows that I've yet to track down.

This makes use of a new crate I've written for this purpose; I've named that crate native_versioning for now. For an explanation of how this works, please see that crate's docs. In short:

The general idea is that all symbols in C, C++, and assembly code are mangled with the current crate version. For instance, a symbol some_func will become some_func_v1_23_2_beta. On the Rust side, all symbols will be linked to using the mangled name. The C, C++, and assembly name mangling will happen transparently; only a versioned.h file needs to be maintained, and no changes need to be made to the C, C++, or assembly code. On the Rust side, all non-system extern blocks are modified to use the versioned_extern! macro.

Once the PR is ready to be accepted, I'll publish the native_versioning crate and update the PR with the crate's final name.

Steps taken so far:

• Create separate module for padding.
• Refactor existing PKCS padding to use this system.
• Implement PSS padding (encoding and verification).
• Add test cases for PSS signatures.

This is a bit rough at the moment. There are some fairly large changes made by this so I thought it would be best to put it out there for feedback before proceeding.

Relevant issues: #115 and #213

Set feature "no_asm" to use. This currently disables use of aead, ec, and rsa/signature modules due to missing code.

Also adds the mipsel-unknown-linux-gnu target to the travis builds. These builds currently fail in anticipation of PR#199.

This is 1 and 2 of your suggested PR disassembly in #392. I elected to do them together because otherwise this would have failed to build on arm because there wouldn't be a replacement for GFp_cpuid_setup.

Opened the PR so that I can discuss with @briansmith about the code. Nothing works yet. DON'T MERGE!

List of tasks:

• [x] Implement division by small primes as suggested here
• [x] Implement miller-rabin primality test based on FIPS 186-4 C.3.1
• [x] Tests for the miller-rabin primality test
• [x] Implement FIPS 186-4 section B 3.3 algorithm to obtain (p,q) prime pair
• [x] Use (p,q) to create the needed p,q,dP,dQ,qInv,r_i,d_i,t_i
• [x] DER formatting of the created key
• [ ] Implement primitive for multiplication
• [x] Implement primitive for inverse modulo m

Important reading:

• FIPS 186-4: https://nvlpubs.nist.gov/nistpubs/fips/nist.fips.186-4.pdf
• https://eprint.iacr.org/2018/749
• https://tools.ietf.org/html/draft-mavrogiannopoulos-pkcs8-validated-parameters-00
• Formatting of the keys: https://tools.ietf.org/html/rfc5958 and https://tools.ietf.org/html/rfc3447#section-3

Fixes #219

This is harder than EdDSA because there's no code to do the actual ECDSA signing anymore; the ECDSA_sign function in crypto/ecdsa/ecdsa.c was removed to help with the migration to the new Rust ECC code. So, a new implementation of ECDSA signing in Rust is necessary.

For all platforms it is OK (preferable, even) to use crypto::ec::PrivateKey::generate for the key generation (i.e. base point multiplication). So, that part is already done.

I have some code sitting around to do the constant-time modular inversions (mod q) and (mod n). I will try to integrate it...soonish.

For 64-bit platforms, we can use crypto/ec/p256-64.c and crypto/ec/p256-x86_64.c for the variable point multiplication (the multiplication done during the signing operation). However, we don't have any usable code for 32-bit platforms yet (at least, not checked in).

For 32-bit ARM, x86, and AAarch64, I will eventually import in the ecp_nistz256 field operations from OpenSSL. Actually, I'm planning to do this real soon. However, I don't think the ecp_nistz256 group operations are good to use for any platform except x86-64 (even then...). We might try, instead, adapting the p256-64.c variable point multiplication to work using the ecp_nistz256 field operations (which would require adapting it to work on Montgomery-encoded field elements).

Similarly, we need to do make new nonce generation, as the old C code that Adam Langley wrote was removed. It may be worth copying how golang is doing it. Regardless, it would be nice to do as much of this as possible in Rust.

NIST has some test vectors for ECDSA signing, which are the absolute minimum level of testing necessary before the API can be exposed.

There is also no code for serializing private keys or deserializing them, which is pretty essential to most users of ECDSA signing. This should probably be split off into its own task as it is a fair amount of work on its own.

See also any general notes about signing APIs in #205.

For #459.

Todo:

• [x] Try out a guard!/check! macro
• [x] Change private representation of Ed25519KeyPair
• [ ] Avoid unnecessary recomputations
• [ ] Add comments
• [ ] Gather updated benchmarks

https://rustsec.org/advisories/RUSTSEC-2019-0031

The spin dependency is no longer maintained it appears. This causes cargo audit to fail on downstream projects. I haven't had a chance to look into potential fixes.

10: 0x10307a6b7 - build_script_build::build_c_code::hd9ffeb4799056596 at /Users/fl0120/github/ring/build.rs:372 11: 0x10307996d - build_script_build::ring_build_rs_main::h5507f897a7458b6f at /Users/fl0120/github/ring/build.rs:294 12: 0x10307910e - build_script_build::main::h912ac4a7682e0b5c at /Users/fl0120/github/ring/build.rs:256

When cross compile ring for power target which not in ASM_TARGETS, the build.rs will crash on unwrap()

RustCrypto/hashes#82

I noticed it in the CI output of https://github.com/rust-lang/rustup/pull/2517 :

  running "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-arch" "arm64" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/Users/runner/work/rustup/rustup/target/aarch64-apple-darwin/release/build/ring-fcf530fe8716448c/out/aesv8-armx-linux64.o" "/Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S"
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:18:17: error: unexpected token in '.section' directive
  .section .rodata
                  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:28:1: error: unknown directive
  .hidden GFp_aes_hw_set_encrypt_key
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:29:1: error: unknown directive
  .type GFp_aes_hw_set_encrypt_key,%function
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:161:1: error: unknown directive
  .size GFp_aes_hw_set_encrypt_key,.-GFp_aes_hw_set_encrypt_key
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:163:1: error: unknown directive
  .hidden GFp_aes_hw_encrypt
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:164:1: error: unknown directive
  .type GFp_aes_hw_encrypt,%function
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:191:1: error: unknown directive
  .size GFp_aes_hw_encrypt,.-GFp_aes_hw_encrypt
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:193:1: error: unknown directive
  .hidden GFp_aes_hw_decrypt
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:194:1: error: unknown directive
  .type GFp_aes_hw_decrypt,%function
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:221:1: error: unknown directive
  .size GFp_aes_hw_decrypt,.-GFp_aes_hw_decrypt
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:223:1: error: unknown directive
  .hidden GFp_aes_hw_ctr32_encrypt_blocks
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:224:1: error: unknown directive
  .type GFp_aes_hw_ctr32_encrypt_blocks,%function
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:403:1: error: unknown directive
  .size GFp_aes_hw_ctr32_encrypt_blocks,.-GFp_aes_hw_ctr32_encrypt_blocks
  ^
  /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/pregenerated/aesv8-armx-linux64.S:407:19: error: unexpected token in '.section' directive
  .section .note.GNU-stack,"",%progbits
                    ^
  thread 'main' panicked at 'execution failed', /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.15/build.rs:664:9

cc @shepmaster

On January 10 all versions from 0.9.4 to 0.14.0-alpha4 were yanked, along with the versions of untrusted that they depended on. This has broken the build of any crate which had a dependency on older versions of ring anywhere in their build. For example, crates.io can no longer accept any pull request which makes any changes to our Cargo.toml, as any attempts to do so will resolve several of our dependencies to ancient versions from before they depended on Ring, since the versions used can no longer be resolved.

Was there a reason for yanking all of these versions? Yanking is typically only done if there is a severe bug or security vulnerability found in a version, but I cannot find any security advisory involving Ring. I also can't find a changelog anywhere to see if there was a critical fix listed in 0.14.

Given the severe effects this has on the ecosystem, could you elaborate on why these were yanked?

Hey,

I am trying to cross compile it on windows for aarch64 linux sytem. I found the following problem. The error was reproduced in some computers.

The command was cargo build --target aarch64-unknown-linux-gnu .

error: failed to run custom build command for ring v0.16.20

Caused by: process didn't exit successfully: G:\client\target\debug\build\ring-450a68265133bae7\build-script-build (exit code: 101) --- stdout OPT_LEVEL = Some("0") TARGET = Some("aarch64-unknown-linux-gnu") HOST = Some("x86_64-pc-windows-msvc") cargo:rerun-if-env-changed=CC_aarch64-unknown-linux-gnu CC_aarch64-unknown-linux-gnu = None cargo:rerun-if-env-changed=CC_aarch64_unknown_linux_gnu CC_aarch64_unknown_linux_gnu = None cargo:rerun-if-env-changed=TARGET_CC TARGET_CC = None cargo:rerun-if-env-changed=CC CC = None RUSTC_LINKER = Some("G:\Program Files (x86)\Arm GNU Toolchain aarch64-none-linux-gnu\12.2 rel1\bin\aarch64-none-linux-gnu-gcc") cargo:rerun-if-env-changed=CROSS_COMPILE CROSS_COMPILE = None cargo:rerun-if-env-changed=CFLAGS_aarch64-unknown-linux-gnu CFLAGS_aarch64-unknown-linux-gnu = None cargo:rerun-if-env-changed=CFLAGS_aarch64_unknown_linux_gnu CFLAGS_aarch64_unknown_linux_gnu = None cargo:rerun-if-env-changed=TARGET_CFLAGS TARGET_CFLAGS = None cargo:rerun-if-env-changed=CFLAGS CFLAGS = None cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS CRATE_CC_NO_DEFAULTS = None DEBUG = Some("true") CARGO_CFG_TARGET_FEATURE = Some("neon")

--- stderr running "aarch64-linux-gnu-gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-4" "-fno-omit-frame-pointer" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-g3" "-DNDEBUG" "-c" "-oG:\4.installedSoftware\office365\client\target\aarch64-unknown-linux-gnu\debug\build\ring-c28f4785134456e7\out\aesv8-armx-linux64.o" "C:\Users\admin\.cargo\registry\src\rsproxy.cn-8f6827c7555bfaf8\ring-0.16.20\pregenerated\aesv8-armx-linux64.S" thread 'main' panicked at 'failed to execute ["aarch64-linux-gnu-gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-4" "-fno-omit-frame-pointer" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-g3" "-DNDEBUG" "-c" "-oG:\4.installedSoftware\office365\client\target\aarch64-unknown-linux-gnu\debug\build\ring-c28f4785134456e7\out\aesv8-armx-linux64.o" "C:\Users\admin\.cargo\registry\src\rsproxy.cn-8f6827c7555bfaf8\ring-0.16.20\pregenerated\aesv8-armx-linux64.S"]: program not found', C:\Users\admin.cargo\registry\src\rsproxy.cn-8f6827c7555bfaf8\ring-0.16.20\build.rs:653:9 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace warning: build failed, waiting for other jobs to finish...

error: failed to run custom build command for `ring v0.16.20`

Caused by:
  process didn't exit successfully: `/home/pmos/build/src/messenger-notify-0.2.3/target/release/build/ring-9d8e9630d389e5ef/build-script-build` (exit status: 101)
  --- stdout
  OPT_LEVEL = Some("s")
  TARGET = Some("x86_64-alpine-linux-musl")
  HOST = Some("x86_64-alpine-linux-musl")
  CC_x86_64-alpine-linux-musl = None
  CC_x86_64_alpine_linux_musl = None
  HOST_CC = None
  CC = Some("gcc")
  CFLAGS_x86_64-alpine-linux-musl = None
  CFLAGS_x86_64_alpine_linux_musl = None
  HOST_CFLAGS = None
  CFLAGS = Some("-Os -fomit-frame-pointer")
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("false")
  CARGO_CFG_TARGET_FEATURE = Some("neon")

  --- stderr
  running "gcc" "-Os" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-Os" "-fomit-frame-pointer" "-I" "include" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-g3" "-U_FORTIFY_SOURCE" "-DNDEBUG" "-c" "-o/home/pmos/build/src/messenger-notify-0.2.3/target/release/build/ring-082db86d6dcfc6fc/out/aesv8-armx-linux64.o" "/home/pmos/.cargo/registry/src/github.com-1ecc6299db9ec823/ring-0.16.20/pregenerated/aesv8-armx-linux64.S"
  aarch64-alpine-linux-musl-gcc: error: unrecognized command-line option '-m64'

The crate compiles properly with Linux and with the msvc toolchain but fails with gnu toolchain (other crates compile OK):

Compiling ring v0.16.20
error: failed to run custom build command for `ring v0.16.20`

Caused by:
 process didn't exit successfully: `C:\Users\01894832\RUST\iris\target\release\build\ring-eafcd483b9227c36\build-script-build` (exit code: 101)
 --- stdout
 OPT_LEVEL = Some("3")
 TARGET = Some("x86_64-pc-windows-gnu")
 HOST = Some("x86_64-pc-windows-gnu")
 cargo:rerun-if-env-changed=CC_x86_64-pc-windows-gnu
 CC_x86_64-pc-windows-gnu = None
 cargo:rerun-if-env-changed=CC_x86_64_pc_windows_gnu
 CC_x86_64_pc_windows_gnu = None
 cargo:rerun-if-env-changed=HOST_CC
 HOST_CC = None
 cargo:rerun-if-env-changed=CC
 CC = None
 cargo:rerun-if-env-changed=CFLAGS_x86_64-pc-windows-gnu
 CFLAGS_x86_64-pc-windows-gnu = None
 cargo:rerun-if-env-changed=CFLAGS_x86_64_pc_windows_gnu
 CFLAGS_x86_64_pc_windows_gnu = None
 cargo:rerun-if-env-changed=HOST_CFLAGS
 HOST_CFLAGS = None
 cargo:rerun-if-env-changed=CFLAGS
 CFLAGS = None
 cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
 CRATE_CC_NO_DEFAULTS = None
 DEBUG = Some("false")
 CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")

 --- stderr
 running "gcc.exe" "-O3" "-ffunction-sections" "-fdata-sections" "-m64" "-I" "include" "-Wall" "-Wextra" "-std=c1x" "-Wbad-function-cast" "-Wnested-externs" "-Wstrict-prototypes" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-g3" "-DNDEBUG" "-c" "-oC:\\Users\\01894832\\RUST\\iris\\target\\release\\build\\ring-e163d10086ee687e\\out\\aes_nohw.o" "crypto/fipsmodule/aes/aes_nohw.c"
 thread 'main' panicked at 'failed to execute ["gcc.exe" "-O3" "-ffunction-sections" "-fdata-sections" "-m64" "-I" "include" "-Wall" "-Wextra" "-std=c1x" "-Wbad-function-cast" "-Wnested-externs" "-Wstrict-prototypes" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-g3" "-DNDEBUG" "-c" "-oC:\\Users\\01894832\\RUST\\iris\\target\\release\\build\\ring-e163d10086ee687e\\out\\aes_nohw.o" "crypto/fipsmodule/aes/aes_nohw.c"]: program not found', C:\Users\01894832\.cargo\registry\src\github.com-1ecc6299db9ec823\ring-0.16.20\build.rs:653:9
 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

This PR adds support for the wasm32-wasi target.

To get the CI working, i had to use the dtolnay/rust-toolchain@stable action. The toolchain only seems to work when it is installed with rustup, see a similar issue here: https://bugs.archlinux.org/task/75269.

Currently the clippy and audit CI runs are failing. I didn't include them in this PR because I thought it would make it more difficult to see the actual changes. If I should include the clippy and audit changes, please let me know.

I agree to license my contributions to each file under the terms given at the top of each file I changed.