Adds clippy to the CI workflow for dank. Resolves all clippy lints as well.

Notable changes:

• I added #![allow(dead_code)] to xtc to get the lints to pass for the PR, I don't know enough about the project to know if the structs should be re-exported or the modules made public to resolve the dead code lints.

This PR adds a constant transaction fee of 2B cycles for every transaction, keeps track of total volume of captured fees and handles the upgrade logic required for deployment.

no proper support for NFT metadata until the standard changes no support for account identifier no support for history no support for allowances no fees no tests extensions method missing contains some inefficient copying/missing inline attributes... warnings suppressed

In release build we will now have runtime checks whether integers overflow or underflow. By doing so, one of the most common smart contract security weaknesses are prevented.

issue: Guard against overflows on balances [ch23813]

The canister create and canister call functions now record the xtc balance that was used to fund the call under the history transaction. The candid has been updated to reflect the change.

The from property has been added to the CanisterCalled and CanisterCreated history record schemas. It is the principal id of the balance the call was paid from.

    CanisterCalled : record {
        from : principal;
        canister : principal;
        method_name: text;
    };
    CanisterCreated : record {
        from : principal;
        canister : principal;
    };

TODO

• [x] Update candid formats
• [x] Update code to save to those formats
• [x] Add upgrade code, that corrects for missing information in the transaction history

Clubhouse

[23578] XTC history records for CanisterCreated and CanisterCalled are missing the from address

Testing

To manually test, first start the local dfx environement and deploy:

dfx start

# in a different tab
dfx deploy

Then run through xtc setup and make two example calls, checking the output of get_transaction now has from entries.

xtcID=$(dfx canister id xtc)  
walletId=rwlgt-iiaaa-aaaaa-aaaaa-cai

# Transfer cycles to dank under your account
dfx canister call piggy-bank perform_mint "(record { canister= principal \"$xtcID\"; account=null; cycles=1000000 })"

# Perform a proxy call (send cycles to your deployed wallet)
dfx canister call xtc wallet_call "(record { canister= principal \"$walletId\"; method_name= \"wallet_receive\"; args= blob \"DIDL\01nh\01\00\00\"; cycles= (1000:nat64); })"

dfx canister call xtc get_transaction "(1)"

# Expecting a transaction for CanisterCalled with a from as your principal id

# (
#   opt record {
#     fee = 0 : nat64;
#     kind = variant {
#       CanisterCalled = record {
#         from = principal "mwp5g-agwxm-genl7-rh5gi-4nbla-e5mn5-6bkj4-3ellr-qlq4m-npwsx-sae";
#         method_name = "wallet_receive";
#         canister = principal "rwlgt-iiaaa-aaaaa-aaaaa-cai";
#       }
#     };
#     cycles = 1_000 : nat64;
#     timestamp = 1_628_775_471_350 : nat64;
#   },
# )

# Create an empty canister
dfx canister --no-wallet call xtc wallet_create_canister "(record {cycles= (999_000:nat64); controller= (null); })"

dfx canister call xtc get_transaction "(2)"

# Expecting

# (
#   opt record {
#     fee = 0 : nat64;
#     kind = variant {
#       CanisterCreated = record {
#         from = principal "mwp5g-agwxm-genl7-rh5gi-4nbla-e5mn5-6bkj4-3ellr-qlq4m-npwsx-sae";
#         canister = principal "rkp4c-7iaaa-aaaaa-aaaca-cai";
#       }
#     };
#     cycles = 999_000 : nat64;
#     timestamp = 1_628_775_791_145 : nat64;
#   },
# )

This change is confirmed by Harrison.

It will change the name as returned from the name function against the canister as well, as that is populated from metadata.

So:

dfx canister --network=ic call xtc name
# (opt "Cycles")

This release adds functionality that will allow us to support https://github.com/dfinance-tech/ic-token

This will be a two stage process, with the old functions being retained but deprecated, while temporary new methods are added. In a future release, the final version of the IC-Token methods will be added, and the intermediary versions marked as deprecated.

Hello, There's a mismatch in theTxReceipt of the mint function between the candid and the rust implementation In Rust it's Nat and in candid it's Nat64

candid

type MintResult = variant {
    Ok : TransactionId;
    Err: MintError;
};
type TransactionId = nat64;

https://github.com/Psychedelic/dank/blob/965e3dfea7788ed71078849b864d030f547cc215/candid/xtc.did#L59

Rust implementation

pub type TxReceipt = Result<Nat, TxError>;

https://github.com/Psychedelic/dank/blob/f80e1e419029cd6d4e8df3069694df226c731784/xtc/src/ledger.rs#L310

A commend line typo which causes bash returns an error $ dfx canister --network=ic --wallet=$(dfx identity --network=ic get-wallet) call --with-cycles AMOUNT aanaa-xaaaa-aaaah-aaeiq-cai mint "(principal \"Some-Principal-ID\",0:nat")" Should be $ dfx canister --network=ic --wallet=$(dfx identity --network=ic get-wallet) call --with-cycles AMOUNT aanaa-xaaaa-aaaah-aaeiq-cai mint "(principal \"Some-Principal-ID\",0:nat)"

Hello, I sent a WICP from Plug to Stoic but it didn't arrive (https://dashboard.internetcomputer.org/account/33d8485170a0b7fb16314db89e44c53edbdd402d4d25f665d90228611140a364).

I don't see it on either the starting wallet or the destination one. I don't even see it among the transactions on https://dashboard.internetcomputer.org/account/b1aea4232927d66fe69800627f006722a891335328c064fa89e3c4276be8469d

It only shows up in the list of transactions in the Plug wallet Chrome plugin. Can you help me?

DIP20 has errors defined like this

pub enum Dip20TxError {
    InsufficientAllowance,
    InsufficientBalance,
    ErrorOperationStyle,
    Unauthorized,
    LedgerTrap,
    ErrorTo,
    Other,
    BlockUsed,
    AmountTooSmall,
}

While XTC's errors are defined like this

pub enum TxError {
    InsufficientAllowance,
    InsufficientBalance,
    ErrorOperationStyle,
    Unauthorized,
    LedgerTrap,
    ErrorTo,
    Other,
    BlockUsed,
    FetchRateFailed,
    NotifyDfxFailed,
    UnexpectedCyclesResponse,
    AmountTooSmall,
    InsufficientXTCFee,
}

As you can see, XTC has more enum entries. When trying to use DIP20 types against XTC canister and bump into an error, one would get an error message like:

The Replica returned an error: code 5, message: "Canister knhk5-cyaaa-aaaak-aagoq-cai trapped explicitly: Custom(Fail to decode argument 0 from table0 to variant {
  Ok : nat;
  Err : variant {
    InsufficientAllowance;
    InsufficientBalance;
    ErrorOperationStyle;
    Unauthorized;
    LedgerTrap;
    ErrorTo;
    Other;
    BlockUsed;
    AmountTooSmall;
  };
}

Caused by:
    0: input: 4449444c026b02bc8a017dc5fed201016b0dea99f1497fb5da9aa3037fffcc9bc5057fb9d6c894067fa2dab8d7077fd292d883087fd4b4c59a097fd6e89efe097fc3feeeba0b7fb0ad8fcd0c7ff7c295940e7f8afcbca80f7fabb7cef40f7f0100_00dbb301
       table: type table0 = variant { 17_724 : nat; 3_456_837 : table1 }
       type table1 = variant {
         154_946_794;
         879_144_245;
         1_487_332_991;
         1_653_746_489;
         2_062_429_474;
         2_155_219_282;
         2_471_582_292;
         2_680_665_174;
         3_076_243_267;
         3_382_957_744;
         3_800_392_055;
         4_111_416_842;
         4_271_086_507;
       }
       wire_type: table0, expect_type: variant {
         Ok : nat;
         Err : variant {
           InsufficientAllowance;
           InsufficientBalance;
           ErrorOperationStyle;
           Unauthorized;
           LedgerTrap;
           ErrorTo;
           Other;
           BlockUsed;
           AmountTooSmall;
         };
       }
    1: table0 is not a subtype of variant {
         Ok : nat;
         Err : variant {
           InsufficientAllowance;
           InsufficientBalance;
           ErrorOperationStyle;
           Unauthorized;
           LedgerTrap;
           ErrorTo;
           Other;
           BlockUsed;
           AmountTooSmall;
         };
       }
    2: Variant field 3_456_837: table1 is not a subtype of variant {
         InsufficientAllowance;
         InsufficientBalance;
         ErrorOperationStyle;
         Unauthorized;
         LedgerTrap;
         ErrorTo;
         Other;
         BlockUsed;
         AmountTooSmall;
       }
    3: Variant field 154_946_794 not found in the expected type)"

Please, make them compatible. Otherwise, what's the point of the standard?