DIP20: A fungible token standard for the DFINITY Internet Computer.

While trying to run the create token commands, this error shows up.

Way to Replicate Error: cd rust dfx canister create --all dfx build dfx canister install token --argument="("data:image/jpeg;base64,...", "DFinance Coin", "DFC", 8, 10000000000000000, principal "qk36l-k7g7k-mtr6a-bfuek-eqsah-yjjj7-jurfe-54jjj7-jurfe-554sq-d7qhw-jw3su-jqe", 10000)" Invalid data: Unable to serialize Candid values: wrong number of argument values

feat: adds tooling (cap autosetup, healthcheck, deploy scripts) fix: random character in license fix: updated information segment in main.rs refractor: restructure rust folder (it can now be used within another project with no issues from cargo as well) feat: guard methods for permissioned calls fix: issue with transfers trapping

This will extend the usage of the enum type TxError::Other to support arbitrary strings. This will help in surfacing errors coming from cap or anything else.

Ex:

TxError::Other(format!(
            "Inserting into cap failed with error: {:?}",
            error
        ))

• add_record used an Option on caller, cap_sdk expects a value for the param caller.

• https://github.com/Psychedelic/cap/blob/85d135eb43433adef9b6681260ce64eaa5dbe48c/sdk/standards/src/dip20/cap.rs#L587

• refer to link above.

• if None is passed this will throw

issue: 1 warn and 1 vuln, looks like cpu dos

command output:

(ins)kod@m1:~/code/DIP20/rust$ cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 417 security advisories (from /Users/kod/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (164 crate dependencies)
Crate:     regex
Version:   1.5.4
Title:     Regexes with large repetitions on empty sub-expressions take a very long time to parse
Date:      2022-03-08
ID:        RUSTSEC-2022-0013
URL:       https://rustsec.org/advisories/RUSTSEC-2022-0013
Solution:  Upgrade to >=1.5.5
Dependency tree:
regex 1.5.4
├── lalrpop-util 0.19.7
│   ├── lalrpop 0.19.7
│   │   └── candid 0.7.11
│   │       ├── token 0.1.0
│   │       ├── ic-cdk-macros 0.3.3
│   │       │   ├── token 0.1.0
│   │       │   └── ic-kit 0.4.3
│   │       │       ├── token 0.1.0
│   │       │       ├── cap-sdk-core 0.1.0-alpha1
│   │       │       │   └── cap-sdk 0.1.0-alpha1
│   │       │       │       ├── token 0.1.0
│   │       │       │       └── cap-standards 0.1.0-alpha1
│   │       │       │           └── token 0.1.0
│   │       │       ├── cap-sdk 0.1.0-alpha1
│   │       │       └── cap-common 0.1.0
│   │       │           └── cap-sdk-core 0.1.0-alpha1
│   │       ├── ic-cdk 0.3.3
│   │       │   ├── token 0.1.0
│   │       │   ├── ic-kit 0.4.3
│   │       │   ├── ic-cdk-macros 0.3.3
│   │       │   ├── cap-standards 0.1.0-alpha1
│   │       │   ├── cap-sdk-core 0.1.0-alpha1
│   │       │   ├── cap-sdk 0.1.0-alpha1
│   │       │   └── cap-common 0.1.0
│   │       └── cap-standards 0.1.0-alpha1
│   └── candid 0.7.11
└── lalrpop 0.19.7

Crate:     serde_cbor
Version:   0.11.2
Warning:   unmaintained
Title:     serde_cbor is unmaintained
Date:      2021-08-15
ID:        RUSTSEC-2021-0127
URL:       https://rustsec.org/advisories/RUSTSEC-2021-0127
Dependency tree:
serde_cbor 0.11.2
└── cap-common 0.1.0
    └── cap-sdk-core 0.1.0-alpha1
        └── cap-sdk 0.1.0-alpha1
            ├── token 0.1.0
            └── cap-standards 0.1.0-alpha1
                └── token 0.1.0

error: 1 vulnerability found!
warning: 1 allowed warning found

suggested action:

cargo update

This might be nice to have if we have multiple failed transactions in the cap queue.

A heartbeat increases the cost of running a canister so maybe we can put this on the back burner or as an extension module.

Any code that uses the IC CDK storage is using unsafe Rust which can result in race conditions. This may not introduce downstream issues in your code, but it was a problem for us, and certainly may be a problem if storage is used more widely throughout the codebase.

The caller of the transfer method can't reliably predict the fee amount that will be charged when transferring out. After a query call has been made to retrieve the fee value and before the actual transfer call, it's possible the fee could be changed by the owner. This may be a rare occurrence but can cause issues for downstream applications who may send more tokens than is necessary if a fee is changed by the owner.

Two possible fixes include making the transfer method have a limit parameter to ensure that fee + transfer value <= limit, or changing the transfer function so that the amount transferred is inclusive rather than exclusive of the fee.

error[E0308]: mismatched types
   --> src/main.rs:537:13
    |
537 |             caller,
    |             ^^^^^^
    |             |
    |             expected enum `std::option::Option`, found struct `candid::Principal`
    |             help: try using a variant of the expected enum: `_::_serde::__private::Some(caller)`
    |
    = note: expected enum `std::option::Option<candid::Principal>`
             found struct `candid::Principal`

For more information about this error, try `rustc --explain E0308`.
error: could not compile `token` due to previous error

ben@u2 ~/D/rust (main) [101]> rustc --version
rustc 1.57.0 (f1edd0429 2021-11-29)