Hi,

NetBSD package maintainer here. I'm currently using neix for feeds from project I maintain packages for. neix is no longer maintained and I would like to move to tuifeed, also because I could drop ncursesw from my system doing so.

There's a feature that stops me from doing that. neix displays dates, which is rather useful info for a package maintainer. See screenshot

Would this be something that could be implemented? And, are you willing to do so?

#5 - Article should use updated or published property

Fixes #5

Description

I was contacted personally by @0323pin to help out with this issue.

Although I couldn't personally find a feed with a published property, the attribute does exist. This PR aims to implement the request.

List here your changes

• If an article does not present an updated property, use published instead.

EDIT:

I was presented a feed that does contain this published property, but through a different identifier, i.e. pubDate. I hope feed_rs maps them to the same field, if doesn't how can we achieve this?

Type of change

Please select relevant options.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

Checklist

• [x] My code follows the contribution guidelines of this project
• [x] I have performed a self-review of my own code:
  • If I'm not mistaken the updated property is shown on the top right of any feed within the TUI, and we can still see that. So there doesn't seem to be any regressions.
• [ ] I have commented my code, particularly in hard-to-understand areas
• [x] My changes generate no new warnings
• [x] I formatted the code with cargo fmt
• [x] I checked my code using cargo clippy and reports no warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] I have introduced no new C-bindings
• [x] The changes I've made are Windows, MacOS, UNIX, Linux compatible (or I've handled them using cfg target_os)
• [ ] I increased or maintained the code coverage for the project, compared to the previous commit

Acceptance tests

wait for a project maintainer to fulfill this section...

• [ ] regression test: ...

Not really a question, more FYI. I've packaged and merged tuifeed into pkgsrc main branch, https://mail-index.netbsd.org/pkgsrc-changes/2021/11/16/msg243429.html

tuifeed will become available to NetBSD users using the native package manager within a few days.

Regards, [email protected]

Description

Steps to reproduce

Add the source

echo -e "GeorgeHotz = \"https://geohot.github.io/blog/feed.xml\""|tee -a ~/.config/tuifeed/config.toml &&
tuifeed

Copy the url from the lower right corner. It is https://geohot.github.io//blog/jekyll/update/2022/04/ instead of https://geohot.github.io/blog/jekyll/update/2022/04/16/vampire-attack-twitter.html

Expected behaviour

It is https://geohot.github.io//blog/jekyll/update/2022/04/ instead of https://geohot.github.io/blog/jekyll/update/2022/04/16/vampire-attack-twitter.html The other sites work fine. Is it George's fault or the feed reader's fault?

Environment

• OS: Ubuntu 20.04 Desktop

Description

tuifeed fails to load DigiTimes news feed

Steps to reproduce

Add https://www.digitimes.com/rss/daily.xml feed and run tuifeed

"DIGITIMES" = "https://www.digitimes.com/rss/daily.xml"

Expected behaviour

Load the feed and list feed contents.

Error shown

tuifeed show the following error

Could not fetch feed "DIGITIMES": HTTP request failed: https://www.digitimes.com/rss/daily.xml: Connection Failed: An existing
connection was forcibly closed by the remote host. (os error 10054)

Environment

• OS: Windows 10 x64
• Architecture x86_64
• Rust version: ?
• tuifeed version: 0.1.0

Beep boop. Your images are optimized!

Your image file size has been reduced by 20% 🎉

📝 docs | :octocat: repo | 🙋🏾 issues | 🏪 marketplace

~Imgbot - Part of Optimole family

Beep boop. Your images are optimized!

Your image file size has been reduced by 20% 🎉

📝 docs | :octocat: repo | 🙋🏾 issues | 🏪 marketplace

~Imgbot - Part of Optimole family

Description

tuifeed doesn't support local atom/rss file. It will try to download it with a http client.

Changes

Adding a local rss file in the config like this is validated in the config local-rss = "file:///your_path/file.rss" But throw an error when opening tuifeed

Could not fetch feed "local-rss": HTTP request failed: Bad URL: failed to parse
 URL: EmptyHost: empty host 

This README is a bit of a mess in my opinion. It is unreadable as plaintext which doesn’t fit the spirit of a TUI application. It contains a number of markup missuses too.

• Move to AsciiDoc from Markdown to use less HTML in the document; if unfamiliar it is supported by GitHub, GitLab, Codeberg for automatic document rendering and there is a thorough Writer’s Guide
• Subtitle as AsciiDoc subtile using :
• Don’t manually maintain a table of contents when AsciiDoc can do this for you automatically using :toc:
• Remove target="_blank" as this breaks user agent defaults and hurts accessibility; don’t ruin this for users
• AsciiDoc image syntax can do width/height without HTML
• ISO-8601-compatible date to eliminate abiguity and conform to digital standards
• Remove unnecessary align=centers
• Use console syntax highlighting for shell sessions, they are not shell scripts
• Use admonitions properly; do not use <blockquote>s for content that isn’t a quotation; this is incorrect markup (could GitHub do a better job rendering these, absolutely—and if I could fork GitHub to fix this I would, but it’s a proprietary, closed-source Git forge)
• Typographically, the rendering of AsciiDoc will properly use the correct apostrophes/quotation marks (e.g. ' → ’) which will look better

Additional fixes::

• The config actually is read from $XDG_CONFIG_HOME on Linux
• The above block is a tip, not a warning/caution
• Removed some unnecessary intro text in the installation section
• <hr> no longer felt necessary

The normal issue template is noisy and irrelevant to this merge request. How I suggest assessing this pull request:

Compare raw text:: main vs. fork in my repository Compare GitHub's rendering:: main this fork in my repository

GitHub rendering is listed second because I don't think it's the proper target to optimize for. There are many other good alternative code forges, and people that checkout out this project will likely want it readable in their text editor of choice or even with cat. Personally, for this reason I do not include any more images than strictly necessary (especially CI badges, and on a platform like GitLab, they have a dedicated spot for adding badges to not polluted the README) nor do I include emoji because it doesn't render well in terminals--however these are more subjective to the maintainer.

The biggest win here IMO is that there is zero embedded HTML now.

👋🏻

Not sure if this is already possible, or isn't a focus of this tool, but it would be nice if there was a visual aid to help identify new articles published.

It looks like currently articles are changed daily, so for example if I refresh on a Monday I get all the Monday articles but if I don't get a chance to read them all, on the next day if I refresh the feeds I'll see all the Monday articles get replaced with Tuesday articles.

If that's ultimately the design philosophy the tool is going for then that's fine, I just wanted to know if it's possible to persist unread articles from a previous day/date and have a way to highlight what I have/haven't read.

I appreciate open-source is typically a thankless vocation, so I just wanted to say thank you for sharing this tool.