• Added proper Result type
• No unwrapping inside the open dialog functions. It now returns a correct restult type instead
• Added the nfd sources that is built using the gcc crate instead of having the user compile the code manually
• Added DialogBuilder to make it nicer to construct dialogs with filters and paths
• Added builder_open_jpg example which uses the builder code and only allows for opening of jpg files
• Fixed issue focus issue for Mac dialogs: Outlined here https://github.com/mlabbe/nativefiledialog/issues/7
• Support for multi open + example

This PR uses nativefiledialog as submodule. I keep build.rs. But use devel branch. It's in active development. I'll change dependency to master when devel will be merged, because it's one still contains changes we need.

We can use devel or wait for master. Any option available. But PR is ready to check.

I've found a bug with a save dialog:

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
Assertion failed!

Program: C:\kode\kode-simulator\target\debug\simulator.exe
File: nativefiledialog/src/nfd_common.c, Line 55

Expression: ptr

Multiple files were expected on save, but that's wrong. No pointer to multiple files struct, that's why it fails on free assert inside nfd_common.c.

With this PR save dialog works fine.

PR https://github.com/mlabbe/nativefiledialog/pull/19 was merged. It makes possible to use it as submodule.

@saurvs @emoon Let's consider to use it mentioned way.

Now nativefiledialog (devel branch) uses premake 5 and have Makefiles to popular OS. I offer:

• [x] Use nativefiledialog as git submodule
• [x] Remove nfd folder with local version (and stop to maintain it)
• [x] Update and still use build.rs script

Any ideas? Caveats?

    Updating registry `https://github.com/rust-lang/crates.io-index`
   Compiling gcc v0.3.51
   Compiling nfd v0.0.4 (file:///Users/matthew/Documents/nfd-rs)
error: failed to run custom build command for `nfd v0.0.4 (file:///Users/matthew/Documents/nfd-rs)`
process didn't exit successfully: `/Users/matthew/Documents/nfd-rs/target/debug/build/nfd-fadd152c4e7e2b1e/build-script-build` (exit code: 101)
--- stdout
TARGET = Some("x86_64-apple-darwin")
OPT_LEVEL = Some("0")
TARGET = Some("x86_64-apple-darwin")
HOST = Some("x86_64-apple-darwin")
TARGET = Some("x86_64-apple-darwin")
TARGET = Some("x86_64-apple-darwin")
HOST = Some("x86_64-apple-darwin")
CC_x86_64-apple-darwin = None
CC_x86_64_apple_darwin = None
HOST_CC = None
CC = None
HOST = Some("x86_64-apple-darwin")
TARGET = Some("x86_64-apple-darwin")
HOST = Some("x86_64-apple-darwin")
CFLAGS_x86_64-apple-darwin = None
CFLAGS_x86_64_apple_darwin = None
HOST_CFLAGS = None
CFLAGS = None
PROFILE = Some("debug")
running: "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-m64" "-I" "nativefiledialog/src/include" "-o" "/Users/matthew/Documents/nfd-rs/target/debug/build/nfd-2d1f6f190beb9ef3/out/nativefiledialog/src/nfd_common.o" "-c" "nativefiledialog/src/nfd_common.c"
cargo:warning=clang: error: no such file or directory: 'nativefiledialog/src/nfd_common.c'
cargo:warning=clang: error: no input files
exit code: 1


command did not execute successfully, got: exit code: 1



--- stderr
thread 'main' panicked at 'explicit panic', /Users/matthew/.cargo/registry/src/github.com-1ecc6299db9ec823/gcc-0.3.51/src/lib.rs:1239
note: Run with `RUST_BACKTRACE=1` for a backtrace.

@saurvs Could you publish 0.0.4 version to crates.io? I use git version now, it's stable. But I need access it from crates.io to publish own library depends on your crate.

With this code

fn main() {
    let t = nfd::open_file_dialog(None, Some("")).unwrap();
}

rust panics in the build-phase because of the following error:

error: linking with `link.exe` failed: exit code: 1120
...
= note: Non-UTF-8 output: libnfd-2d582c35cd8355e4.rlib(nfd_win.o) : error LNK2019: Reference to unresolved external symbol \"__imp_SHCreateItemFromParsingName\" in function \"\"enum nfdresult_t __cdecl SetDefaultPath(struct IFileDialog *,char const *)\" (?SetDefaultPath@@YA?AW4nfdresult_t@@PEAUIFileDialog@@PEBD@Z)\".\r\nD:\\dev\\repositories\\rust-playground\\target\\debug\\deps\\rust_playground.exe 
: fatal error LNK1120: 1 not resoved extern

When I open the system dialog with open_file_dialog I can't navigate between the folders :

let result = nfd::open_file_dialog(Some("png"), Some("~/Pictures")).unwrap_or_else(|e| {
       panic!(e);
});

The buttons event on the sidebar are disabled, and I don't land on the Pictures folder

Thanks for this useful crate.

After upgrading Rust to 1.33.0 I get the following link error from nfd when building Cinter:

libnfd-ec2bb1b08ec0519c.rlib(nfd_win.o) : error LNK2019: unresolved external symbol __imp_SHCreateItemFromParsingName referenced in function "enum nfdresult_t __cdecl SetDefaultPath(struct IFileDialog *,char const *)" (?SetDefaultPath@@YA?AW4nfdresult_t@@PEAUIFileDialog@@PEBD@Z)

1.32.0 works fine.

I'm on Windows 10 with Visual Studio 2017.

error: failed to run custom build command for `nfd v0.0.4`
process didn't exit successfully: `/target/debug/build/nfd-dff4fe53caa6791a/build-script-build` (exit code: 101)

thread 'main' panicked at '

Internal error occurred: Command "aarch64-linux-gnu-gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-I" "nativefiledialog/src/include" "-Wall" "-Wextra" "-o" "/target/aarch64-unknown-linux-gnu/debug/build/nfd-cc59041a1d0b08c3/out/nativefiledialog/src/nfd_gtk.o" "-c" "nativefiledialog/src/nfd_gtk.c" with args "aarch64-linux-gnu-gcc" did not execute successfully (status code exit code: 1).

', /cargo/registry/src/github.com-1ecc6299db9ec823/gcc-0.3.54/src/lib.rs:1670:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

Kernel: x86_64 Linux 4.9.0-3-amd64

I have a feature that you may like. However, it needs a modification on submodule nativefiledialog. The feature allows the user to replace the default dialog title ("Open File" or "Select folder" etc.) with a dialog title that can serve as a prompt. I have a pull request pending at nativefiledialog, but I am far from sure it will be accepted. I am not sure how to approach this problem. Anyway: here is my two cents

I don't know if it's an issue with these bindings, or the original library, or if I'm doing something terrible... My application crashed in a very rare case when I was in the folder selector opened with nfd::open_pick_folder. And gave output:

mremap_chunk(): invalid pointer
munmap_chunk(): invalid pointer

The code: https://github.com/Ploppz/bup/blob/main/src/path.rs

I may be missing something but I am not aware of any OS where the file chooser lets you pick multiple files in different folders.

Assuming this is the case, the path of all files returned by OkayMultiple will always be the same for all elements of the Vec.

Would it then not make sense to change the return value to a tuple (String, Vec<String>) that returns the path in the first string and just the file names or folders, omitting the path, in the Vec<String>?

It looks like nativefiledialog has some significant updates since 2016, particularly for win32 and osx. Would it be fairly easy to use the latest source files from that project? Thank you.

This updates from using nativefiledialog C library from 2016-08-25 to latest master, version 1.1.6 from 2019-09-30.

No code changes required!

Would be great to publish a new version of this crate with this to include the 3 years of fixes and updates

I'm trying to build using the stable-x86_64-pc-windows-gnu toolchain and I'm getting this error:

cargo:warning=nativefiledialog/src/nfd_win.cpp:118:24: error: 'sprintf_s' was not declared in this scope

Is this because nfd assumes you'll be building using MSVC and sprintf_s is Microsoft-specific? Building against stable-x86_64-pc-windows-msvc works fine.