I'm currently following this blog series, and I'm experiencing severe performance issues in Atom while doing so; every file modification (key press, undo, etc.) takes anywhere between 100ms and 500ms to occur, and the editor hangs in the meantime. This is making my editor absolutely unusable.

I've isolated the problem to ide-rust, specifically when it's connected to an RLS instance with an rls.toml specifying an alternate target; I've tested the following scenarios:

• RLS connected, rls.toml specified: Performance is unusably poor.
• RLS disconnected (eg. repeatedly killed and restart limit reached): Performance is fine.
• rls.toml removed: Performance is fine.
• Editing a non-Rust project: Performance is fine.

I've uploaded an archive here of the project in the exact state in which it causes performance issues. There's also a profiler dump of the performance issues.

I'm currently using Atom 1.31.2 x64, on NixOS 18.03.

(The rls.toml is necessary to keep RLS from complaining about conflicts with std, since this is a no_std project.)

This looks a lot like https://github.com/atom/atom/issues/6437 -- CPU runs constantly until I disable ide-rust. JavaScript profiler in Atom developer tools show that it is constantly forking.

Repro with Atom 0.21.0 on macOS:

cargo new foobar
cd foobar
open -a /Applications/Atom.app --args "$PWD" "$PWD/src/lib.rs"
watch -n 0.1 'ls -lR'

Repro on Linux:

cargo new foobar
cd foobar
atom "$PWD" "$PWD/src/lib.rs"
watch -n 0.1 'ls -lR'

The watch command at the end will show that it's constantly rebuilding rls dependencies. This appears to be a conflict between file change notification watchers. But I cannot pinpoint the cause beyond these initial steps.

I don't have this problem when opening a parent directory of the rust project. In this case, rls isn't getting built in the project directory, either.

Hi, I use this plugin daily and often run into slowness/lagging due to the enormous memory consumption of RLS on my platform. Would it be possible (even experimentally) add support for using Rust Analyzer instead of RLS?

It would be fine to require the user to install it themselves since it has to be built from source. I am very interested in seeing if this makes using atom for Rust more enjoyable.

Thanks for working on this plugin! I use it every day. :smile:

When using the formatting tool (ctrl+shift+c), if there are any lines that consist only of whitespace, the entire line is removed. E.g. starting with

fn foo() {}

fn main() {}

with spaces or tabs on the second line, you end up with

fn foo() {}
fn main() {}

What should happen instead is that the trailing whitespace is removed, but the line isn't. Normal Rustfmt doesn't have this problem, so it seems to be an issue specific to the Atom plugin.

Hi Ryan (or anyone reading this),

I've been using atom-ide-rust for some time, but the rls stopped working lately. I get a Cargo failed: Error compiling dependent crate message when I start atom in a Rust project directory. Other things (like rustfmt) still work.

Here's the output I get with atom.config.set('core.debugLSP', true):

/home/althonos/.local/share/atom/packages/ide-rust/node_modules/atom-languageclient/build/lib/logger.js:9 
Rust (RLS) stderr {
    "message":"multiple input filenames provided",
    "code":null,
    "level":"error",
    "spans":[],
    "children":[],
    "rendered":
    "error: multiple input filenames provided\n\n"
}

with:

$ rls --version
rls-preview 0.128.0-nightly (453f5e4 2018-05-28)
$ atom --version
Atom    : 1.27.1
Electron: 1.8.4
Chrome  : 59.0.3071.115
Node    : 8.2.1

I'm using ide-rust with a project using glium and following the tutorials. https://github.com/glium/glium/tree/master/book

The linter doesn't seem to be working when I'm in this glium project. When I enable logging, I get logger.ts:19 Rust (RLS) stderr thread 'main' has overflowed its stack in the console.

[Enter steps to reproduce:]

Not, sure. I've got that on first save of Rust code (Cmd-S) after upgrading to ide-rust 0.6.0

Atom: 1.22.0 x64 Electron: 1.6.15 OS: Mac OS X 10.13.1 Thrown From: ide-rust package 0.6.0

Stack Trace

Uncaught Error: Connection is closed.

At /Users/imp/.atom/packages/ide-rust/node_modules/vscode-jsonrpc/lib/main.js:613

Error: Connection is closed.
    at /packages/ide-rust/node_modules/vscode-jsonrpc/lib/main.js:138:28)
    at throwIfClosedOrDisposed (/packages/ide-rust/node_modules/vscode-jsonrpc/lib/main.js:613:19)
    at Object.sendNotification (/packages/ide-rust/node_modules/vscode-jsonrpc/lib/main.js:667:13)
    at LanguageClientConnection._sendNotification (/packages/ide-rust/node_modules/atom-languageclient/build/lib/languageclient.js:242:15)
    at LanguageClientConnection.didChangeTextDocument (/packages/ide-rust/node_modules/atom-languageclient/build/lib/languageclient.js:131:10)
    at TextEditorSyncAdapter.sendIncrementalChanges (/packages/ide-rust/node_modules/atom-languageclient/build/lib/adapters/document-sync-adapter.js:200:24)
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app/node_modules/event-kit/lib/emitter.js:141:34)
    at TextBuffer.module.exports.TextBuffer.emitDidChangeTextEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/text-buffer.js:1675:28)
    at TextBuffer.module.exports.TextBuffer.transact (/Applications/Atom.app/Contents/Resources/app/node_modules/text-buffer/lib/text-buffer.js:975:18)
    at TextEditor.module.exports.TextEditor.transact (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:1687:32)
    at /Applications/Atom.app/Contents/Resources/app/src/text-editor.js:1248:30
    at TextEditor.module.exports.TextEditor.mergeSelections (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:2635:24)
    at TextEditor.module.exports.TextEditor.mergeIntersectingSelections (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:2597:41)
    at TextEditor.module.exports.TextEditor.mutateSelectedText (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:1246:25)
    at TextEditor.module.exports.TextEditor.insertText (/Applications/Atom.app/Contents/Resources/app/src/text-editor.js:1212:25)
    at TextEditorComponent.didTextInput (/Applications/Atom.app/Contents/Resources/app/src/text-editor-component.js:1627:30)

Commands

Non-Core Packages

atom-beautify 0.30.6 
atom-ide-ui 0.5.4 
atomatigit 1.5.5 
autocomplete-python 1.10.3 
browser-plus 0.0.98 
build 0.69.0 
build-cargo 2.0.0 
build-make 0.13.0 
busy 0.7.0 
busy-signal 1.4.3 
ide-rust 0.6.0 
imdone-atom 2.2.7 
imdone-atom-github 0.1.11 
intentions 1.1.5 
language-diff 0.7.0 
language-docker 1.1.8 
language-rust 0.4.12 
linter 2.2.0 
linter-pycodestyle 2.1.3 
linter-rust 0.8.1 
linter-ui-default 1.6.10 
merge-conflicts 1.4.5 
minimap 4.29.7 
minimap-git-diff 4.3.1 
project-manager 3.3.5 
python-tools 0.6.9 
racer-plus 2.0.0 
release-notes 0.53.0 
rust-api-docs-helper 0.5.1 
rusty-dark-syntax 0.7.0 
split-diff 1.5.1 
sync-settings 0.8.3 
tool-bar 1.1.0 
travis-ci-status 1.3.1 

So i've run into an issue with this package. Diagnostics or Linting doesn't work while a .rs file is open. Saving the file or going to the new line does not lint the file. It seems that this only happens when the file is first opened and in order to kick it off again you have to close and reopen this file.

Would it be possible to implement proper code linting using the RLS or even Racer if needed?

Atom: version is 1.23.3 (all packages updated to latest) Rust: nightly-x86_64-pc-windows-msvc (default) rustc 1.25.0-nightly (e6072a7b3 2018-01-13)

When atom is closed with atom-ide-rust enabled, a "ghost" window appears, showing the last open file but without any syntax highlighting or most of the UI.

Atom before clicking the cross to close:

Atom after clicking the cross as a "ghost" window.

I noticed that when I do formatting, it uses the default rustfmt configuration

Also would be cool a command to formate all using cargo fmt on the project

I'm getting errors pointing to a missing rustup installation while I'm very certain it is available and present in PATH:

Uncaught (in promise) Error: failed to start server: Error: Command failed: rustup run stable-x86_64-pc-windows-gnu rustc --version
error: toolchain 'stable-x86_64-pc-windows-gnu' is not installed

    at RustLanguageClient.startServerProcess (C:\Users\user\.atom\packages\ide-rust\lib\index.js:622)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

Running rustup run stable-x86_64-pc-windows-gnu rustc --version in cmd works nicely and returns rustc 1.27.0 (3eda71b00 2018-06-19). rustup component list --toolchain stable confirms that the required components are there:

cargo-x86_64-pc-windows-gnu (default)
rls-preview-x86_64-pc-windows-gnu (installed)
rust-analysis-x86_64-pc-windows-gnu (installed)
rust-docs-x86_64-pc-windows-gnu (default)
rust-mingw-x86_64-pc-windows-gnu (default)
rust-src (installed)
rust-std-x86_64-pc-windows-gnu (default)
rustc-x86_64-pc-windows-gnu (default)

I've also tried to make it work with nightly-x86_64-pc-windows-gnu (that I also have along with RLS), but it only changed the flavor of the error to:

Error: Command failed: rustup run nightly-x86_64-pc-windows-gnu rustc --version
error: toolchain 'nightly-x86_64-pc-windows-gnu' is not installed

Debug mode doesn't show any more errors.

Pulsar discord: https://discord.com/invite/7aEbB9dGRT A rust discord: https://discord.gg/rust-lang-community

I couldn't find @aminya or @Green-Avocado

I was asking pulsar devs about variable highlighting, the VSCode plugin does this, and they said I need to contact the ide devs.

[Enter steps to reproduce:]

1. ...starting atom
2. ...

Atom: 1.58.0 x64 Electron: 9.4.4 OS: Windows 10 Thrown From: ide-rust package 1.1.1

Stack Trace

Uncaught Error: Message header must separate key and value using :

At C:\Users\amiga\.atom\packages\ide-rust\node_modules\vscode-jsonrpc\lib\common\messageBuffer.js:87

Error: Message header must separate key and value using :
    at MessageBuffer.tryReadHeaders (/packages/ide-rust/node_modules/vscode-jsonrpc/lib/common/messageBuffer.js:87:23)
    at StreamMessageReader.onData (/packages/ide-rust/node_modules/vscode-jsonrpc/lib/common/messageReader.js:132:45)
    at /packages/ide-rust/node_modules/vscode-jsonrpc/lib/common/messageReader.js:122:18)
    at Socket.emit (events.js:228:7)
    at addChunk (_stream_readable.js:309:12)
    at readableAddChunk (_stream_readable.js:290:11)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:181:23)

Commands

Non-Core Packages

atom-ide-base 3.4.0 
atom-ide-code-format 1.0.2 
atom-ide-datatip 0.25.0 
atom-ide-definitions 0.4.2 
atom-ide-hyperclick 1.0.11 
atom-ide-markdown-service 2.1.0 
atom-ide-outline 3.2.0 
atom-ide-signature-help 0.16.0 
atom-language-rust 0.14.1 
build 0.70.0 
build-cargo 2.0.0 
busy-signal 2.0.1 
ide-rust 1.1.1 
intentions 2.1.1 
linter 3.4.0 
linter-rust-cargo 1.1.0 
linter-ui-default 3.4.1 
rust-format 1.0.3 

I'd like to be able to use nightly Rust for rustfmt but keep using stable Rust for everything else. Stable rust is set as the default toolchain in rustup and I always call cargo +nightly fmt for code formatting. However, I couldn't find any option in atom-ide-rust to replicate this behaviour. Instead, everytime I save a file this package adds a whole bunch of trailing commas, likely because the option to remove those is unstable and ignored by stable rustfmt.

Ide-rust's use of rust analyzer has very poor impact on laptop battery life.

There needs to be work done to reduce its CPU util when idle.

My battery util with rust analyzer turned on v.s. without is 45W v.s. 10-15W. That is truly a battery life killer.

Are there any suggestions on how this might be done?

Rust analyzer issue: https://github.com/rust-analyzer/rust-analyzer/issues/5919

Something that would be nice is to have rust-analyzer be manually refreshable, rather than to be called constantly. Or to have a button to toggle whether analyzer is on or off directly in the console, rather than having to navigate to the packages page.

When the "main.rs" file is saved empty, the whole editor freezes and shortly crashes. During the freeze, a really high spike in CPU usage occurs. The analyzer doesn't show the compilation error that no fn main() was found, so the issue likely occurs during this check.

The editor works normally when in safe mode (eg. all packages disabled).

Atom version: 1.49.0 atom-ide-rust version: 0.22.0-beta.3 RLS: rust-analyzer-mac Toolchain: stable-x86_64-apple-darwin

When I get my project into a state in which there are no compiler errors, then ide-rust starts to go crazy. The rust-analyzer and atom-helper processes go up to 100 - 200% CPU usage and ide-rust says it's running cargo check. This usually takes around 10 minutes and I get messages like this thousands of times:

/.atom/packages/ide-rust/lib/index.js:211 Rust LS suspicious stdout: ource":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_WEIGHT_ARRAY_POINTER_ARB`","range":{"end":{"character":51,"line":661},"start":{"character":0,"line":661}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_WEIGHT_ARRAY_ARB`","range":{"end":{"character":43,"line":662},"start":{"character":0,"line":662}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW0_ARB`","range":{"end":{"character":40,"line":663},"start":{"character":0,"line":663}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW1_ARB`","range":{"end":{"character":41,"line":664},"start":{"character":0,"line":664}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW2_ARB`","range":{"end":{"character":41,"line":665},"start":{"character":0,"line":665}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW3_ARB`","range":{"end":{"character":41,"line":666},"start":{"character":0,"line":666}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW4_ARB`","range":{"end":{"character":41,"line":667},"start":{"character":0,"line":667}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW5_ARB`","range":{"end":{"character":41,"line":668},"start":{"character":0,"line":668}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW6_ARB`","range":{"end":{"character":41,"line":669},"start":{"character":0,"line":669}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW7_ARB`","range":{"end":{"character":41,"line":670},"start":{"character":0,"line":670}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW8_ARB`","range":{"end":{"character":41,"line":671},"start":{"character":0,"line":671}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW9_ARB`","range":{"end":{"character":41,"line":672},"start":{"character":0,"line":672}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW10_ARB`","range":{"end":{"character":42,"line":673},"start":{"character":0,"line":673}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW11_ARB`","range":{"end":{"character":42,"line":674},"start":{"character":0,"line":674}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW12_ARB`","range":{"end":{"character":42,"line":675},"start":{"character":0,"line":675}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW13_ARB`","range":{"end":{"character":42,"line":676},"start":{"character":0,"line":676}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW14_ARB`","range":{"end":{"character":42,"line":677},"start":{"character":0,"line":677}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW15_ARB`","range":{"end":{"character":42,"line":678},"start":{"character":0,"line":678}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW16_ARB`","range":{"end":{"character":42,"line":679},"start":{"character":0,"line":679}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW17_ARB`","range":{"end":{"character":42,"line":680},"start":{"character":0,"line":680}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW18_ARB`","range":{"end":{"character":42,"line":681},"start":{"character":0,"line":681}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW19_ARB`","range":{"end":{"character":42,"line":682},"start":{"character":0,"line":682}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW20_ARB`","range":{"end":{"character":42,"line":683},"start":{"character":0,"line":683}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW21_ARB`","range":{"end":{"character":42,"line":684},"start":{"character":0,"line":684}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW22_ARB`","range":{"end":{"character":42,"line":685},"start":{"character":0,"line":685}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW23_ARB`","range":{"end":{"character":42,"line":686},"start":{"character":0,"line":686}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW24_ARB`","range":{"end":{"character":42,"line":687},"start":{"character":0,"line":687}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW25_ARB`","range":{"end":{"character":42,"line":688},"start":{"character":0,"line":688}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW26_ARB`","range":{"end":{"character":42,"line":689},"start":{"character":0,"line":689}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW27_ARB`","range":{"end":{"character":42,"line":690},"start":{"character":0,"line":690}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW28_ARB`","range":{"end":{"character":42,"line":691},"start":{"character":0,"line":691}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW29_ARB`","range":{"end":{"character":42,"line":692},"start":{"character":0,"line":692}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW30_ARB`","range":{"end":{"character":42,"line":693},"start":{"character":0,"line":693}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_MODELVIEW31_ARB`","range":{"end":{"character":42,"line":694},"start":{"character":0,"line":694}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_ARRAY_BUFFER_ARB`","range":{"end":{"character":43,"line":695},"start":{"character":0,"line":695}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_ELEMENT_ARRAY_BUFFER_ARB`","range":{"end":{"character":51,"line":696},"start":{"character":0,"line":696}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_ARRAY_BUFFER_BINDING_ARB`","range":{"end":{"character":51,"line":697},"start":{"character":0,"line":697}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_ELEMENT_ARRAY_BUFFER_BINDING_ARB`","range":{"end":{"character":59,"line":698},"start":{"character":0,"line":698}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_VERTEX_ARRAY_BUFFER_BINDING_ARB`","range":{"end":{"character":58,"line":699},"start":{"character":0,"line":699}},"severity":2,"source":"rustc","tags":[1]},{"code":"dead_code","message":"constant item is never used: `GL_NORMAL_ARRAY_BUFFER_BINDING_ARB`","range":{"end":{"character":58,"line":700},"start":{"character":0,"line":700}},"severity":2,"sourc

If I run cargo check in the terminal, it usually runs in under a second.

Rust Analyzer Version: fbb8b88