I was scrolling through the org github and just happened to see this. 😄 I was interested in trying it out in one of my project, and I was wondering if you'd consider adding #![no_std] support? As far as I can tell nearly all of the crate is implemented with types in core and alloc, having it available without std would allow this to be used by a lot more lower level libraries such as codec/serialisation frameworks.

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Adds a basic cargo-deny configuration as well as a CI step to run it on every run.

This adds high level docs to all top level items. The most relevant sections are on the root module and #[derive(Reflect)].

Part of https://github.com/EmbarkStudios/mirror-mirror/issues/4

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

I've found these to be useful.

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

• Rename some things
• Iterators
• Public Key constructors

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Its more consistent when you can call .default_value() on anything.

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Adds

• impl From<&dyn Reflect> for Value
• impl ToOwned for dyn Reflect

which I've found to be useful.

We have a use case where it would be useful to pass data into FromReflect which is needed to perform the conversion: We have entity ids encoded as opaque u32s. Before converting a u32 back into an entity id we'd need to check that it actually points to a valid entity, or perhaps do additional checks. Doing that check would require a handle to the system that manages entities. It is currently not possible to pass that into from_reflect and we only get the raw u32.

We can't simply add a new argument for from_reflect...

pub trait FromReflect<C: ?Sized>: Reflect + Sized {
    fn from_reflect(reflect: &dyn Reflect, context: &C) -> Option<Self>;
}

...since from_reflect called from:

• Generated code for patching enums
• [T; N]::clone_reflect
• EnumValue::patch
• BTreeMap::insert
• BTreeMap::remove
• BTreeMap::clone_reflect
• Vec::clone_reflect
• Vec::push
• "Via scalar" patch

So we'd have to also pass the new arg to those functions. We also cannot add generic parameters to those functions since Reflect needs to be object safe. Could make Reflect itself generic over the context but thats a large change that'd cause other changes pretty much everywhere.

Perhaps there is a more elegant solution that wouldn't require changing everything 🤔

Currently Value has a size of 32 bytes on the stack. Would be worth exploring if there are ways to make it smaller. Perhaps by keeping the larges variants in a separate type that is always boxed, something like Value::BigValue(Box<BigValue>).

These are the types from std that bevy_reflect supports that we don't. Not sure we have to support all of them but at least worth considering.

• [ ] Cow<'static, str>
• [x] Duration
• [ ] BTreeSet<T>
• [ ] Instant
• [x] NonZero*
• [ ] OsString
• [ ] PathBuf
• [x] Range<T>
• [x] RangeFrom
• [x] RangeFull
• [ ] RangeInclusive<T>
• [x] RangeTo<T>
• [x] RangeToInclusive<T>
• [x] Result<T, E>
• [x] [T; N] - this'll require a new Array trait since List supports pushing elements which [T; N] doesn't.