Hello,

implemented FTPS support using Private Protection mode what means both commands and data are secured with TLS. FTPS is a feature which is disabled be default because it introduces openssl dependency. To enable it feature secure should be activated in toml or directly in the build command cargo build/test/doc --features "secure".

Also I introduce DataStream struct in the PR which abstracts FtpStream for the underlying stream (TCP or SSL over TCP).

And I added a feature debug_output which on activation prints all commands and responses to STDOUT. Very usefull when debugging.

Hi

It would be nice if this library would use a custom error type for all results, instead of mixing io::Error and Strings. This would play well together with the From<Error> trait.

http://blog.burntsushi.net/rust-error-handling/

I've tried get and retr and neither seem to return a BufRead

I ask because i'm trying to use read_line https://doc.rust-lang.org/beta/std/io/trait.BufRead.html#method.read_line

    let mut ftp_stream = FtpStream::connect(("ftp.arin.net", 21)).unwrap();
    ftp_stream.login("anonymous", "").unwrap();
    println!("current dir: {}", ftp_stream.pwd().unwrap());

    ftp_stream.cwd("pub/stats/arin").unwrap();

    let stream = ftp_stream.get("delegated-arin-extended-latest").unwrap();

    let mut buf = Vec::new();

    let num_bytes = stream.read_line(&mut buf);
    println!("got line: {}", str::from_utf8(&buf).unwrap());

    let num_bytes = stream.read_line(&mut buf);
    println!("got line: {}", str::from_utf8(&buf).unwrap());

error[E0599]: no method named `read_line` found for type `std::io::BufReader<ftp::data_stream::DataStream>` in the current scope

cf: https://github.com/mattnenterprise/rust-ftp/issues/10

This is work in progress. I need to add nlst as well. But if you have feedback aleady it's great. Maybe I should rename list() to ls(), also.

This is the smallest change, so that's why I'm starting with this one. We will need to update the crate's version number to account for this breaking change.

I was trying to connect anonymously to ftp.hq.nasa.gov but I'm getting an "Invalid response". I suspect there is something wrong in read_response:

// nasa.rs
extern crate ftp;

use std::str;
use ftp::FTPStream;

fn main() {
    let mut ftp_stream = match FTPStream::connect("198.116.65.45".to_string(), 21) {
        Ok(s) => s,
        Err(e) => panic!("{}", e)
    };
}

Here is a capture: ftp_failure.pcapng.zip

I realize that this is a fairly controversial and large pull request. I've been using rust-ftp a fair bit lately and have found the code a bit confusing to navigate at times. It is evident that you, Matt, were improving your Rust skills as you wrote the library and I can see you've become a lot more comfortable with error handling in particular as you progressed. Because of the library's earlier roots, some code was implemented with an unnecessarily large amount of Result unwrapping, by way of match. One of the big things I set out to do here is make the implementation of each method more consistent.

Another thing I wanted to set out to do here was introduce a custom error type, FtpError, so that the library only ever returns that one error type in its interface. This allows for much simpler usage, as a user could now chain operations together using Result.and_then() without having to do much intermediate error type inspection and conversion.

You'll also see that I have changed the return types of the messier secure() and secure_with_ssl() methods, which had previously returned a tuple containing a (hopefully) modified FtpStream and an io::Result<()> in the case of error.

If you'd like for me to elaborate on any of the choices I made or would like to discuss the impact or desirability of any of these changes, please don't hesitate to let me know. Since this refactoring is so substantial, I understand if there are parts you disagree with. If you feel that the changes I made are generally not in the spirit of your own intentions, you can reject this PR and I will create my own distinct version of the library.

This PR addresses #48. The idea here is we supply a version of FtpStream that is created when the "secure" feature flag is set which contains an IntoSsl + Clone. By having a copy of an IntoSsl in the struct, we can use it in data_command, so that users can supply their own configurations that will work in all uses.

Let me know if this works for your use cases @mattnenterprise

Hello,

the current implementation of RETR (FtpStream::get) is not correct because it does not read response lines after the data stream is read and closed and using the simple implementation (FtpStream::simple_retr) is not a good idea when files for downloading are big. In the PR I added a new function FtpStream::retr which takes an additional argument reader which is a closure which operates the data stream and inside retr all repsonses and dropping of the data stream are handled correctly.

In the PR I also added TYPE (FtpStream::transfer_type) function which is very important when the binary file should be transfered.

Both status codes and ports don't have anything to do with the pointer size.

Therefore I converted the type for port numbers to an u16 and the type for status codes to i16.

According to https://en.wikipedia.org/wiki/List_of_FTP_server_return_codes, the return codes are between 100 and 10068. An i16 should be suitable here.

An alternative would be to use i32 instead, the default for integer literals where the type cannot be derived properly. Also, an i32 is probably faster on a 32 bit platform (although that really shouldn't matter in this case). So let me know if I should change it :)

Hi,

I wonder what the current status is given that there are a bunch of PRs being open that fixes some fairly important issues (such as version of openssl) is this crate still being supported or not?

Would be nice to have an example of how to properly download/upload a large file, avoiding the control stream timeout (null command)... I'm relatively new to rust and just trying to get a grasp of this.

Hey there, thanks for the great library!

On compiling with ftp 3.0.1 I get the following error:

❯ cargo b -r --future-incompat-report
    Finished release [optimized] target(s) in 0.13s
warning: the following packages contain code that will be rejected by a future version of Rust: winapi v0.2.8
note: 
To solve this problem, you can try the following approaches:


- Some affected dependencies have newer versions available.
You may want to consider updating them to a newer version to see if the issue has been fixed.

winapi v0.2.8 has the following newer versions available: 0.3.0, 0.3.1, 0.3.2, 0.3.3, 0.3.4, 0.3.5, 0.3.6, 0.3.7, 0.3.8, 0.3.9


- If the issue is not solved by updating the dependencies, a fix has to be
implemented by those dependencies. You can help with that by notifying the
maintainers of this problem (e.g. by creating a bug report) or by proposing a
fix to the maintainers (e.g. by creating a pull request):

  - [email protected]
  - Repository: https://github.com/retep998/winapi-rs
  - Detailed warning command: `cargo report future-incompatibilities --id 14 --package [email protected]`

- If waiting for an upstream fix is not an option, you can use the `[patch]`
section in `Cargo.toml` to use your own version of the dependency. For more
information, see:
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section

note: this report can be shown with `cargo report future-incompatibilities --id 14`

It seems like winapi is required by the following sequence:

ftp v3.0.1
└── regex v0.1.80
    └── thread_local v0.2.7
        └── thread-id v2.0.0
            └── kernel32-sys v0.2.2
                └── winapi v0.2.8

Is there any chance to update these? Maybe a regex update might already suffice, or we might need to pass it down.

When connecting to an IIS ftp server we stumble upon the following error message:

FTP - quit: InvalidResponse("Expected code [221], got response: 150 Opening BINARY mode data connection.")

Cargo audit failed

cargo check
cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 433 security advisories (from /home/balrog/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (57 crate dependencies)
Crate:     time
Version:   0.1.44
Title:     Potential segfault in the time crate
Date:      2020-11-18
ID:        RUSTSEC-2020-0071
URL:       https://rustsec.org/advisories/RUSTSEC-2020-0071
Solution:  Upgrade to >=0.2.23
Dependency tree:
time 0.1.44
└── chrono 0.4.20
    └── ftp 3.0.1

error: 1 vulnerability found!

Update chrono dependency and reduce its features to pass audit.

cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 433 security advisories (from /home/balrog/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (55 crate dependencies)

Im not sure if that is the right place but when I run cargo audit on the duckscript repo I get this error:

https://github.com/sagiegurari/duckscript

$ cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 416 security advisories (from /Users/john/.cargo/advisory-db)
    Updating crates.io index
    Scanning Cargo.lock for vulnerabilities (124 crate dependencies)
Crate:     regex
Version:   0.1.80
Title:     Regexes with large repetitions on empty sub-expressions take a very long time to parse
Date:      2022-03-08
ID:        RUSTSEC-2022-0013
URL:       https://rustsec.org/advisories/RUSTSEC-2022-0013
Solution:  Upgrade to >=1.5.5
Dependency tree:
regex 0.1.80
└── ftp 3.0.1
    └── duckscriptsdk 0.8.12
        └── duckscript_cli 0.8.12

Crate:     thread_local
Version:   0.2.7
Title:     Data race in `Iter` and `IterMut`
Date:      2022-01-23
ID:        RUSTSEC-2022-0006
URL:       https://rustsec.org/advisories/RUSTSEC-2022-0006
Solution:  Upgrade to >=1.1.4
Dependency tree:
thread_local 0.2.7
└── regex 0.1.80
    └── ftp 3.0.1
        └── duckscriptsdk 0.8.12
            └── duckscript_cli 0.8.12

error: 2 vulnerabilities found!

So I'm not sure if that's the rust-ftp that has an old regex version or duckscript if its duckscript I will move my issue there.