100% conversion to crossterm (no dual mode)

seems to work fine, test on windows 10 using new windows terminal and powershell works on my rasp pi system too

tests all compile but dont run

On my machine and several CI builders, diskonaut tests fail. The problem is that the rust-filesize uses MetadataExt::blocks to get the number of file blocks:

https://github.com/Freaky/rust-filesize/blob/e8042c00cebd215ac9f106e8b5a20b0c072fd77d/src/lib.rs#L72

However, this method is not reliable. For example:

$ cat blksize.rs 
use std::fs;
use std::os::unix::fs::MetadataExt;
use std::io;

fn main() -> io::Result<()> {
    let meta = fs::metadata("2pow20bytes")?;
    let blocks = meta.blocks();
    let block_size = meta.blksize();
    eprintln!("blocks: {}, block size: {}", blocks, block_size);
    Ok(())
}
$ rustc blksize.rs
$ dd if=/dev/zero of=2pow20bytes bs=1024 count=1024
$ ls -l 2pow20bytes 
-rw-r--r-- 1 daniel users 1048576 Jun 25 19:48 2pow20bytes
$ ./blksize 
blocks: 1, block size: 131072

So, this will be reported as a 512 byte file(!), even though it is 1MiB. The wonders of (ZFS) filesystem compression.

$ dd if=/dev/urandom of=2pow20bytes bs=1024 count=1024
$ ./blksize 
blocks: 2065, block size: 131072

/mnt/n/AppData/Local/Bisq/runtime/include/win32/bridge                                      thread 'main' panicked at 'index out of bounds: the len is 3600 but the index is 3600', /rustc/4fb7144ed159f94491249e86d5bbd033b5d60550/src/libcore/slice/mod.rs:2842:10

Running in WSL 2 with rustc 1.43.0 (4fb7144ed 2020-04-20).

Fixes #36 ... again I've added a key! macro to make it easier to define patterns like Event::Key(Key::Char(..))

In my first PR I think I replaced one of the other keybindings with \n when it was supposed to be n, so this should fix that, since the tests are working locally. Although for some reason if I run the same tests multiple times without changing the code I get different results.

this commit will add an ability to the app which asks user for confirmation just before exit, both in normal and loading mode. please feel free to comment or ask for any changes.

squashed commits:

• add keyEvent handler function for exiting mode
• add Exiting variant to UiMode enum | add prompt_exit method
• implement ExitingMode widget render functionality
• fix mixed UiState issue

There are two main things I know of that we need to do to port diskonaut to work on windows:

1. Currently we rely on hard disk blocks to scan the hard-drive. As far as I know, this does not work on windows, and so we need to find another solution.
2. Termion doesn't(?) work on windows, so we would need to use another backend for TUI.

I am VERY interested in a solution for this. If you want to work on this and are unsure how to begin, or the points above are not clear, I would be very happy to discuss this with you further and clarify anything. Please do not hesitate. :)

Scanning large volumes with diskonaut takes some time. Not terrible (likely less than 10 minutes for really populated volumes) but this is still not the best experience.

It could be nice to experiment with scanning parallelization, as long as it does not impact performance. I feel a slow scan is better than a fast scan that makes your computer stuck and unable to do anything else.

Fixes #37 Although, the way it is now, it will only select (but not cd into) the largest folder if nothing is selected. From the wording "... the app goes into the largest folder" in the comment of #37 I wasn't really sure if it should cd into the largest folder or just select it. However, if should also cd into it, it should be a very trivial change in the handle_enter function.

Right now, when we press "Ctrl-C" or "q" to exit, the app exits immediately. It would be nice if we could add a modal that prompts the user in case they pressed this by mistake.

When running diskonaut on a BTRFS filesystem with compression enabled, it shows the uncompressed space used by folders and files, not the actual disk-space used.

One folder of mine using 69.5G of storage, but if I delete this folder I would not regain 69.5G worth of disk space because that folder is being compressed instead I would only regain 50G of space which represents the actual space used on the disk.

The command [sudo compsize /path/to/folder] was able to identify the post-compression space used.

Rationale for feature:

If I am using this tool, I am likely trying to free space so that I may allocate a new file.

Suppose I want to download a 4GiB iso image. If I have a 4.5GiB zip archive and a 5GiB text-file, diskonaut would make it appear that deleting the text-file would let me download the iso with a GiB to spare. Unfortunately, with compression enabled, the compressible zip archive would still free up 4.5GiB while the highly compressible text-file may only free a 900MiB. At that point I would download the iso, run out of space and then have to reopen diskonaut to free ? more GiB (and hope that compression doesn't cause more trouble).

Design Questions

• How should the compressed vs uncompressed space be represented in the UI?

  The uncompressed usage may still be useful if I plan on copying my files to a location without compression.

• On filesystems where it is relatively slow to compute the compressed disk usage, should there be a fast estimation run where placeholders (e.g. 69.5G??? would be displayed above) until the slower more accurate run occurs.

  • How should the estimation be displayed? I chose 69.5G??? earlier but maybe <69.5G> or some other formatting makes more sense.

• What configuration flags should be added?

  • Formatting
  • Enabling/Disabling feature
  • Enabling/Disabling faster estimation process.

Relevant Filesystems

This Wikipedia table of filesystem capabilities shows that the following support compression.

• BeeGFS
• APFS
• NTFS
• F2FS
• Reiser4
• NSS
• NWFS
• Fossil
• ZFS
• BTRFS
• SquashFS

Hi @imsnif, this commit resolves https://github.com/imsnif/diskonaut/issues/32.

• added WarningBox to modals module.
• rendering logic is similar to other modals. nothing specific to mention.
• about the auto close functionality i added a WarningTimeout variant to your Event enum. this event waits for 5 seconds then resets the ui state using Instruction::ResetUiMode.

please let me know if anything needs to change.

When I ssh to a remote and I ran the utility, the graphics break down, although the functionality seem to work.

My machine is Windows, the remote is Windows. If the remote is Linux, no problem.

Hey there,

I'm packaging diskonaut for Alpine Linux but it seems tests fails for those two architectures.

https://gitlab.alpinelinux.org/StacyHarper/aports/-/pipelines/114814

Is it known ?

edit: and it seems that armv7 can also fail o_O https://gitlab.alpinelinux.org/StacyHarper/aports/-/pipelines/114819

It would be useful to have prebuild deb packages in a ppa at https://launchpad.net . So people can install it with getting updates and without having to compile it themself.