Hi, I usually launch emacs only for magit, so I am interested in gex

gex command fails when the locale is non-English:

$ gex --version
gex 0.3.2

$ echo $LANG
ja_JP.UTF-8

$ gex
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Error { input: "ブランチ master", code: Tag })', /home/<username>/.cargo/registry/src/github.com-1ecc6299db9ec823/gex-0.3.2/src/status.rs:307:34
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

$ LANG=en_US gex
# it works

It may be because git status's result changes depending on locale:

$ LANG=en_US git status
On branch master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

$ echo $LANG
ja_JP.UTF-8

$ git status
ブランチ master
Your branch is up to date with 'origin/master'.

nothing to commit, working tree clean

(ブランチ means "branch" in japanese)

and gex uses git status at https://github.com/Piturnah/gex/blob/v0.3.2/src/status.rs#L299-L307

Message:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Error { input: "Sur la branche nu-ansi-term", code: Tag })', /Users/user/.local/share/cargo/registry/src/github.com-1ecc6299db9ec823/gex-0.3.2/src/status.rs:307:34

With RUST_BACKTRACE=1:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Error { input: "Sur la branche nu-ansi-term", code: Tag })', /Users/alexis/.local/share/cargo/registry/src/github.com-1ecc6299db9ec823/gex-0.3.2/src/status.rs:307:34
stack backtrace:
   0: rust_begin_unwind
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/panicking.rs:142:14
   2: core::result::unwrap_failed
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/result.rs:1805:5
   3: gex::status::Status::fetch
   4: gex::status::Status::new
   5: gex::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Meta

• gex --version:gex 0.3.2`
• OS: macOS 12.5.1

Found via this command:

markdownlint *.md --disable MD013 MD033 MD024

See a detailed description of the rules is available at https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Hello!

Adding the following snippet to the top of main.rs will introduce a bunch of best practices and such that can improve code quality. See here for more details.

#![warn(clippy::nursery, clippy::pedantic)]

This is the allow list that I have, also as a suggestion.

Happy holidays!

If I'm in a child directory of a git repo it should recognize that I am in a git repo.

Since you are already using the git command you could use git rev-parse --is-inside-work-tree to detect a git repo instead of looking for the git folder

as a user of magit, i am glad people are spreading the magic of that UI

There is an awesome project under active development that promises much faster git interactions https://github.com/Byron/gitoxide

that has already delivered 2x performance improvements on large repos like the linux kernel https://github.com/o2sh/onefetch/pull/635

gitoxide has a group of issues to replace git2 https://github.com/Byron/gitoxide/issues?q=is%3Aissue+is%3Aopen+label%3AC-replace-git2

I appreciate this is a personal project and git2 works fine for you now. Only wanted to make you aware in case you might find this interesting

When opening the commit menu, the underlying content is not cleared. This can be seen in the following screenshots:

After pressing c the text "es:" leaks through from behind:

git log HEAD^..HEAD --pretty=format:"%h %s" -n 1 fails with

fatal: ambiguous argument 'HEAD^..HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

I'm a beginner in rust and this is my first contribution in a rust project. Please correct me if I'm wrong.

Issue: https://github.com/Piturnah/gex/issues/17

The following lines really shouldn't be panics, they were missed when anyhow crate was added in 9f13bccbe0df16e9debd837ce9e28e470a39b2b3.

https://github.com/Piturnah/gex/blob/60d0f5a397e745e16dd00903a233c61e3c9fb184/src/status.rs#L356

https://github.com/Piturnah/gex/blob/60d0f5a397e745e16dd00903a233c61e3c9fb184/src/status.rs#L381

Fix: return from the function with Err

There are lots of places in the code where we are aborting on an error even though the error is recoverable. Now that the minibuffer API is a lot simpler, it seems like a good idea to change some of these aborts into warnings.

For example: https://github.com/Piturnah/gex/commit/5b55cfe5a7cd0e630547d1846c2697edbc7a4411#diff-2b963e7f31870073ce48ea6dd279de519d083f2e92d4a33124809465fd7569e5L43-R49

Here we were originally exiting the program on the error but switched to reporting it within gex. There are many similar cases where this is possible.

Could potentially be good if we could just print the anyhow error, something like

foo
    .context("failed to foo")
    .map_err(|e| {
        mini_buffer.push(format!("{e}"), MessageType::Error);
    });

In general Gex may run into issues when the locale is not English as it often directly parses the output from git.

In particular changes to the working tree are not shown as we are looking for the lines "Untracked files:" and "Changes not staged for commit:" https://github.com/Piturnah/gex/blob/71d455f16f1786374ca2da7fa94a411ff2055121/src/status.rs#L317 https://github.com/Piturnah/gex/blob/71d455f16f1786374ca2da7fa94a411ff2055121/src/status.rs#L349

This is a pretty hacky solution and I would rather directly interface with libgit2.

I don't have the time to work on this right now so I am marking as "help wanted" and in the next release I will include a warning if the locale is not English. As stated in the README Gex is primarily a personal project, but that being said I do very much want to support non-English locales.

TODO:

• [x] Implement warning when locale is non-English
• [ ] Actually fix the issue

Originally discovered in #7

So far I'm really enjoying using gex, coming from tig -> gitui, I realized that gex allows me to do most of what I really used those tools for in a much smaller package.

One suggestion I have to improve gex is to allow the usage of an external diff tool to view changes. there are other light weight diff tools that I think would compliment the gex, like difftastic. What do you think?