Hey! I came across this project from a panic stacktrace I got when trying to use https://github.com/adamchainz/django-minify-html. Following that, I found that import and the different variants of export statements are still left as todo!(): https://github.com/wilsonzlin/minify-js/blob/eb27a22535a3bbef7c568a597bb7e470f1bc3797/rust/src/emit/mod.rs#L795

I wanted to ask whether support for these statements is planned anytime soon. Are there any particular problems, or has just no one come around to implementing it yet? In that case, I could also try to file a PR myself, it may take some time though. Until then, I already found the option to disable js minification when using minify-html

Looking forward to using your library. Thanks!

Having trouble parsing wasm-bindgen output again, this time it's about exports. File in question:

https://gist.github.com/Carlrs/67035c2639f0df5d4eca13e47f64a2ea

The algorithm is removing the parenthesis on lambda expressions. It breaks the code in some cases.

For instance :

let fns = [ x => (1, 2) ]

is compressed as

let fns = [ x => 1, 2 ]

The original code creates an array with a single function returning 2. The compressed code creates an array with a lambda returning 1 and with an additional entry 2.

Nice lib.

I would like to suggest the addition of a new feature:

What about creating a macro, such as minify!(...), so we can embed js inside the binaries. With this feature we will be able to use it with projects such as Tauri, and web servers.

It could use something like include_bytes!, and include_str!.

Thanks.

https://developer.mozilla.org/en-US/docs/Glossary/IIFE

(function () {
  let foo = 'bar';
})();

(() => {
  let foo = 'bar';
})();

(async () => {
  let foo = 'bar';
})();

(function(){let a='bar'})();()=>{let a='bar'}();async()=>{let a='bar'}()

Uncaught SyntaxError: unexpected token: '('      debugger eval code:1:45

Should be:

(function(){let a='bar'})();(()=>{let a='bar'})();(async()=>{let a='bar'})()
//                          ^                 ^   ^                      ^

This minimal code:

class Foo {
   #Bar() {
      console.log("Compress me!");
   }
}

outputs this error: thread 'main' panicked at 'minify: Syntax(ExpectedNotFound [position=16 token=None] around ```class Foo { #Bar() { console.log("Compress m```)', cli\src\main.rs:33:41

Trying to minify

for await (const chunk of stream) {
  // ...
}

results in

Error: RequiredTokenNotFound(ParenthesisOpen) [token=Some(KeywordAwait)] around ```await```

I get an error trying to minify a tagged template literal.

// tagged_template.js 
const noop = (raw, ...keys) => keys.length === 0 ? raw[0] : String.raw({ raw }, ...keys)
template = noop`a`
console.log(template)

$ ./minify-js --mode global tagged_template.js 
thread 'main' panicked at 'minify: ExpectedSyntax("expression operator") [token=Some(LiteralTemplatePartStringEnd)] around ```a```', cli/src/main.rs:38:52

I get the same error with other examples at https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#tagged_templates.

import('file.js');

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/import

import can be used with a function syntax instead of a keyword. For both Global and Module, it results in the parse error result:

Error: RequiredTokenNotFound(ParenthesisClose) [token=Some(Semicolon)] around ```;```

Hey, just wanted to give you a heads up that we started benchmarking your minifier here: https://github.com/privatenumber/minification-benchmarks

Thanks for your project and good luck!

In global mode, top-level variables are not added to any scope, so a statement like export a or export { a } will panic due to not finding the symbol if accidentally invoked with TopLevelMode::Global instead of TopLevelMode::Module.