Several times I've had ytop left running and came back to find it crashed with this backtrace:

Backtrace (most recent call first):
  File "src/libcore/option.rs", line 1185, in core::option::expect_failed
  File "src/libcore/option.rs", line 345, in core::option::Option<T>::expect
  File "src/libcore/time.rs", line 744, in <core::time::Duration as core::ops::arith::Sub>::sub
  File "<unknown>", line 0, in psutil::process::process::Process::cpu_percent
  File "<unknown>", line 0, in <core::iter::adapters::Map<I,F> as core::iter::traits::iterator::Iterator>::try_fold
  File "<unknown>", line 0, in <alloc::vec::Vec<T> as alloc::vec::SpecExtend<T,I>>::from_iter
  File "<unknown>", line 0, in <ytop::widgets::proc::ProcWidget as ytop::update::UpdatableWidget>::update
  File "<unknown>", line 0, in ytop::update::update_widgets
  File "<unknown>", line 0, in ytop::main
  File "<unknown>", line 0, in std::rt::lang_start::{{closure}}
  File "src/libstd/rt.rs", line 48, in std::rt::lang_start_internal::{{closure}}
  File "src/libstd/panicking.rs", line 287, in std::panicking::try::do_call
  File "src/libpanic_unwind/lib.rs", line 78, in __rust_maybe_catch_panic
  File "src/libstd/panicking.rs", line 265, in std::panicking::try
  File "src/libstd/panic.rs", line 396, in std::panic::catch_unwind
  File "src/libstd/rt.rs", line 47, in std::rt::lang_start_internal
  File "<unknown>", line 0, in main
  File "<unknown>", line 0, in __libc_start_main
  File "<unknown>", line 0, in <unknown>
  File "<unknown>", line 0, in <unknown>

The application panicked (crashed).
  overflow when subtracting durations
in src/libcore/option.rs, line 1185
thread: main

Currently rust-psutil is pretty barebones so we need to implement a lot the necessary cross platform functionality. Also, ytop currently only compiles on Linux because only Linux functions are implemented.

• [x] Refactor rust-psutil to be more modular and allow cross platform functionality: https://github.com/borntyping/rust-psutil/pull/54
• [x] Implement the functionality on Linux x86
  • [x] temperatures
• [ ] Implement the functionality on macOS x86
  • [x] cpu percents
  • [x] cpu count
  • [x] memory
  • [ ] temps
  • [ ] disk
  • [x] net
  • [ ] processes
  • [x] battery

Hey there,

I have fixed the missing temperature for mac os by using the same approach as used in the go version of this repo: https://github.com/cjbassi/gotop

Cheers

This introduces an ability to not-follow a process in the proc widget. I having to do gg whenever I visit ytop to find out the process which is currently using high mem/CPU. It'd be great to have the ability to not always track the currently highlighted process.

This patch is a POC for that. What it does is:

• Introduce a new flag on the widget: follow_proc, which is false by default. If it is set to true, the render will always jump to the position for the highlighted position. If it is false, it'll keep the selected position the same, no matter which process lands on it.
• When ever the user does a scroll action (except gg), ytop will keep track of the process. gg or scroll to top on the other hand, stops the process tracking facilitating a view such as: the current process taking the most resources.
• Also, bind Esc to set follow_proc as false and disable following of a process.

I understand this cannot be merged as is, but I'd like to start a discussion. If this makes sense, I'd like suggestions on what can be changed in the patch to merge it in.

Minimal effort changes to make ytop build with tui-0.9.

Needs some discussion whether proposed approach of Widget ownership/borrowing is fine.

Fixes #69

We need to upgrade tui for a few features and bug fixes but there is quite a few api changes in the latest release. I've started some work on this in the upgrade-tui branch, but i've just been a little busy with some other things if anybody feels like continuing to work on it. If you make any progress feel free to open a pull request against that branch. Thanks!

Required information:

• ytop version (ytop -V): ytop 0.5.1
• The output of uname -a: Linux roman-MS-7B43 5.3.0-40-generic #32-Ubuntu SMP Fri Jan 31 20:24:34 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Include any of the following information if relevant:

• Terminal emulator (e.g. iTerm or gnome terminal): gnome terminal
• tmux version (tmux -V):
• Any relevenat hardware info:

Please copy or attach ~/.local/state/ytop/errors.log if it exists and contains logs:

repo @ e56403ded6881bc99a5425dc83d32c94e01f8f85 Linux t470 5.4.12-1-MANJARO #1 SMP PREEMPT Wed Jan 15 08:05:08 UTC 2020 x86_64 GNU/Linux terminal is alacritty

RUST_BACKTRACE=Full ./target/debug/ytop

Backtrace (most recent call first):
  File "/home/matthias/.cargo/git/checkouts/tui-rs-7836e4b22d734056/aff0a4c/src/widgets/canvas/mod.rs", line 106, in tui::widgets::canvas::Context::draw
    let index = dy / 4 * self.width as usize + dx / 2;
  File "/home/matthias/.cargo/git/checkouts/tui-rs-7836e4b22d734056/aff0a4c/src/widgets/chart.rs", line 474, in <tui::widgets::chart::Chart<LX,LY> as tui::widgets::Widget>::draw::{{closure}}
    ctx.draw(&Points {
  File "/home/matthias/.cargo/git/checkouts/tui-rs-7836e4b22d734056/aff0a4c/src/widgets/canvas/mod.rs", line 255, in <tui::widgets::canvas::Canvas<F> as tui::widgets::Widget>::draw
    painter(&mut ctx);
  File "/home/matthias/.cargo/git/checkouts/tui-rs-7836e4b22d734056/aff0a4c/src/widgets/chart.rs", line 469, in <tui::widgets::chart::Chart<LX,LY> as tui::widgets::Widget>::draw
    Canvas::default()
  File "src/widgets/mem.rs", line 96, in <ytop::widgets::mem::MemWidget as tui::widgets::Widget>::draw
    Chart::<String, String>::default()
  File "/home/matthias/.cargo/git/checkouts/tui-rs-7836e4b22d734056/aff0a4c/src/terminal.rs", line 49, in tui::terminal::Frame<B>::render
    widget.draw(area, self.terminal.current_buffer_mut());
  File "/home/matthias/.cargo/git/checkouts/tui-rs-7836e4b22d734056/aff0a4c/src/widgets/mod.rs", line 85, in tui::widgets::Widget::render
    f.render(self, area);
  File "src/draw.rs", line 75, in ytop::draw::draw_middle_row
    widgets.mem.render(frame, horizontal_chunks[1]);
  File "src/draw.rs", line 41, in ytop::draw::draw_widgets
    draw_middle_row(frame, widgets, vertical_chunks[1]);
  File "src/draw.rs", line 22, in ytop::draw::draw::{{closure}}
    draw_widgets(&mut frame, &mut app.widgets, chunks[0]);
  File "/home/matthias/.cargo/git/checkouts/tui-rs-7836e4b22d734056/aff0a4c/src/terminal.rs", line 140, in tui::terminal::Terminal<B>::draw
    f(self.get_frame());
  File "src/draw.rs", line 11, in ytop::draw::draw
    terminal.draw(|mut frame| {
  File "src/main.rs", line 128, in ytop::main
    draw(&mut terminal, &mut app).unwrap();

The application panicked (crashed).
  attempt to multiply with overflow
in /home/matthias/.cargo/git/checkouts/tui-rs-7836e4b22d734056/aff0a4c/src/widgets/canvas/mod.rs, line 106
thread: main

Hello,

After running ytop for a few hours I get this error below. I've encountered it a few times and I'm unsure how to debug it. Is it possible to run ytop with RUST_BACKTRACE=1 as a flag to find the bug?

Thanks for your work on this app.

Cheers.

Info

ytop 0.6.2

Darwin rrfd.local 18.7.0 Darwin Kernel Version 18.7.0: Mon Apr 27 20:09:39 PDT 2020; root:xnu-4903.278.35~1/RELEASE_X86_64 x86_64

Include any of the following information if relevant:

ProductName: Mac OS X ProductVersion: 10.14.6 BuildVersion: 18G5033

alacritty 0.5.0-dev (65bff18) tmux 3.1b

Please copy or attach ~/.local/state/ytop/errors.log if it exists and contains logs:

Does not exist

Error Message:

Backtrace omitted. Run with RUST_BACKTRACE=1 to display it.
Run with RUST_BACKTRACE=full to include source snippets.

The application panicked (crashed).
  index out of bounds: the len is 0 but the index is 3
in rust:src/libcore/slice/mod.rs, line 2842
thread: main

• Arch / ytop-git^AUR
• ❯ ytop -V: ytop 0.5.1
• Terminal: kitty

I noticed that graphs don't look good on my main machine.

• Here's how it rendered on an old VM (also using Arch and kitty):

• Here's how it renders on my main machine:

The dots characters look way too thin. They should look just like on the README screenshot and the VM screenshot.

kitty.conf:

font_family                   JetBrainsMonoMedium Nerd Font
font_size                     10.5
bold_font                     auto
italic_font                   auto
bold_italic_font              auto
force_ltr                     no
adjust_line_height            0
adjust_column_width           0
disable_ligatures             cursor
font_features                 none
box_drawing_scale             0.001, 1, 1.5, 2

.Xresources:

Xft.dpi: 96
Xft.antialias: true
Xft.hinting: true
Xft.rgba: rgb
Xft.autohint: false
Xft.hintstyle: hintfull
Xft.lcdfilter: lcddefault

.xinitrc:

xrdb -load ~/.config/X11/.Xresources

I tried using another font with kitty (Fira Code Nerd Font Mono) but it doesn't make any difference.

Any idea which settings I should tweak in order to get the same rendering than the VM one?

Thanks.

ytop graphics have a quirk, the points seem to be improperly spaced when the terminal window is maximized.

Example:

This is gotop running at the same time:

Required information:

• ytop version (ytop -V): ytop v0.4.2 (https://github.com/cjbassi/ytop#f86926c7)
• The output of uname -a: Linux Dianakko 5.4.17-1-MANJARO #1 SMP PREEMPT Tue Feb 4 11:40:50 UTC 2020 x86_64 GNU/Linux

Include any of the following information if relevant:

• Terminal emulator (e.g. iTerm or gnome terminal): Gnome Terminal 3.34.2
• tmux version (tmux -V): N/A
• Any relevenat hardware info: N/A

Please copy or attach ~/.local/state/ytop/errors.log if it exists and contains logs: N/A

Configuration to show displayed batteries, temperatures, and mount points

For example, I might want to exclude my CPU die, or include my mouse battery

Environment

$ ytop -V
ytop 0.6.2
$ uname -a
Darwin 549725-mitll 19.6.0 Darwin Kernel Version 19.6.0: Sun Jul  5 00:43:10 PDT 2020; root:xnu-6153.141.1~9/RELEASE_X86_64 x86_64

• Software: Mac OS X 10.15.6 (build 19G73), Xcode-11.6, rustc 1.47.0-nightly (cfc572cae 2020-07-30)
• Any relevenat hardware info: iMac Pro 2019

~/.local/state/ytop/errors.log exists, but is empty.

Problem

On iMac (but not on older MacBooks) sysinfo provides - and ytop displays - wrong temperature. Note: I cloned sysinfo, and added some sensors (PECI CPU, and a couple more of such) to see what sensors report correctly on both Mac platforms). I found that all of those sensors give correct values on MacBook, but some fail on iMac Pro.

Proposed Workaround

While we're discussing with @GuillaumeGomez the possibility of fixing sysinfo library - it would be nice if ytop could validate (sanity-check) inputs it receives from it. In this particular case, I'd love if ytop would check the received CPU temperature either against zero, or against CPU Proximity, and if it is lower (i.e., lower than zero, or lower than CPU Proximity) - ignore/drop that value and don't display it.

Could you do that, please?

Some people have been rightfully confused (including myself when I first switched to ytop) that some computers will display all CPU cores, vs the average CPU usage. I think it would help if this detection was documented in the --help output next to the -a and -p flags saying something along the lines that it's the default if >= or < 8 cpu cores respectively.

Sadly from what I can tell there's no way to provide information about the minimum supported rust version in Cargo.toml, but there have been a number of issues raised here because of people using outdated compilers and getting build failures (#107 #66 etc.). If a minimum supported rust version was documented in the README and tested against with CI then hopefully people will understand the issue earlier.

Installed package ytop v0.6.2 (executable ytop) *******> ytop

Backtrace omitted. Run with RUST_BACKTRACE=1 to display it. Run with RUST_BACKTRACE=full to include source snippets.

The application panicked (crashed). called Result::unwrap() on an Err value: MissingData { path: "/proc/meminfo", contents: "MemTotal: 16112436 kB\nMemFree: 7029116 kB\nBuffers: 34032 kB\nCached: 188576 kB\nSwapCached: 0 kB\nActive: 167556 kB\nInactive: 157876 kB\nActive(anon): 103104 kB\nInactive(anon): 17440 kB\nActive(file): 64452 kB\nInactive(file): 140436 kB\nUnevictable: 0 kB\nMlocked: 0 kB\nSwapTotal: 13107196 kB\nSwapFree: 12628476 kB\nDirty: 0 kB\nWriteback: 0 kB\nAnonPages: 102824 kB\nMapped: 71404 kB\nShmem: 17720 kB\nSlab: 13868 kB\nSReclaimable: 6744 kB\nSUnreclaim: 7124 kB\nKernelStack: 2848 kB\nPageTables: 2524 kB\nNFS_Unstable: 0 kB\nBounce: 0 kB\nWritebackTmp: 0 kB\nCommitLimit: 515524 kB\nCommitted_AS: 3450064 kB\nVmallocTotal: 122880 kB\nVmallocUsed: 21296 kB\nVmallocChunk: 66044 kB\nHardwareCorrupted: 0 kB\nAnonHugePages: 2048 kB\nHugePages_Total: 0\nHugePages_Free: 0\nHugePages_Rsvd: 0\nHugePages_Surp: 0\nHugepagesize: 2048 kB\nDirectMap4k: 12280 kB\nDirectMap4M: 897024 kB\n" } in /home/ds/.cargo/registry/src/mirrors.tuna.tsinghua.edu.cn-df7c3c540f42cdbd/ytop-0.6.2/src/widgets/mem.rs, line 71 thread: main