Convert timestamps to local times

• Fix 1: A parsing error means we just keep the original number around.

(This is just a suggestion, and the maintainers might prefer an alternative solution.)

• Fix 2: Use signed 64 big to get a tiny bit more range.

Since the regex is looking for 19 digits only, this will fix the issue, as 2^63 has 19 digits but 2^64 has 20 digits. Thus with the range up to 2^64, we're in the clear.

EDIT: The above was auto-generated with the Github CLI.

Question to @mattgodbolt (and maintainers): What is the behavior you'd like to see?

Fixes: https://github.com/aquanauts/rizzy/issues/2

Proof of concept for #9.

chris@christophs-air rizzy % cargo run -- -z America/Chi
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s
     Running `target/debug/rizzy -z America/Chi`
Error: 
   0: Unknown timezone 'America/Chi', did you mean: ["America/Chihuahua", "America/Chicago"]

Location:
   src/main.rs:103

Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

• I found this using fuzzing.
• I'm not sure if the output makes any sense, but I feel like this is better than just crashing. Others may disagree.

I'm happy to provide the fuzzing code as well. Link: https://github.com/siedentop/rizzy/pull/new/fuzzing/trying-fuzzing Please let me know if you want a PR for that. (I kinda suspect that this fuzzing code is not terribly useful.)

I took the liberty to run Rust Format on everything -- if you're not ready for this yet, I totally understand.

Note: I did not have a chance to test the Github Action. Let's see how it works.

UPDATE: The Github Action works: https://github.com/siedentop/rizzy/actions/runs/1770883233 UPDATE 2: And here is the GH Action failing, if the code is not formatted correctly: https://github.com/siedentop/rizzy/runs/5001466217?check_suite_focus=true

Reference: #5

% echo '-9223372036854775808' | rizzy -n
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ParseIntError { kind: PosOverflow }', src/rizzy.rs:77:69
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
% echo '-9223372036854775807' | rizzy -n
-2262-04-11T17:47:16.854775807-06:00
% rizzy --version
rizzy 0.1.1

I keep finding I want to do: rizzy somefile.txt but discover of course I need to cat somefile.txt | rizzy. But it seems like that'd be a nice thing to support (arbitrary number of files in fact).

Thanks for this neat little utility!

Would it be possible for you to run Rust Format (rustfmt) on the code. This would make it more fun to contribute to your code.

If you prefer, you could enforce future compliance through the GitHub Actions.

This example suggests doing it this way:

      - uses: actions-rs/cargo@v1
        with:
          command: fmt
          args: --all -- --check

We use rizzy as an easy-copyable binary at Aquatic. That works as we all agree on the Ubuntu version:

$ ldd target/release/rizzy
	linux-vdso.so.1 (0x00007ffd83470000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f040597e000)
	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f0405776000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0405557000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f0405353000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f0404f62000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f04061cf000)

It might be worth looking at building a musl static build which ends up with a 7MB static binary.

$ rustup target add x86_64-unknown-linux-musl
$ cargo build --release --target x86_64-unknown-linux-musl
$ ls -hld target/x86_64-unknown-linux-musl/release/rizzy
-rwxrwxr-x 2 mgodbolt mgodbolt 7.0M Feb  3 19:27 target/x86_64-unknown-linux-musl/release/rizzy
$ ldd target/x86_64-unknown-linux-musl/release/rizzy
	not a dynamic executable

I'm not sure what the rust-y way to do this is but when I typo a timezone, this seems pretty nasty:

$ rizzy --zone not_a_tz
thread 'main' panicked at 'Could not parse timezone: not_a_tz, Error: 'not_a_tz' is not a valid timezone', src/main.rs:45:19
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Cool tool!

One thing caught my eye: https://github.com/aquanauts/rizzy/blob/c98251b16fe13dd0b1c6054c9d24c3a3454cb06a/src/main.rs#L67

If you are processing a stream without newlines that is going to eat all the RAM. It would be wise to do a few KB at a time in a buffer.

https://github.com/uutils/coreutils/blob/master/src/uu/wc/src/count_fast.rs#L31 has the boilerplate tuned for Linux system calls.