Issues:

Resolves #5

Description of changes:

There is no behavior change. This PR removes some cargo features which are now considered always on (if their dependencies are on too).

• external_proposal was replaced by the by_ref_proposal feature it depends on in mls-rs. In other crates, the guards were removed.
• external_commit was removed.
• all_extensions was removed.

Call-outs:

N/A

Testing:

Parts of CI run locally, including tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

1. Readme is out of date due to not syncing with lib.rs
2. Circular dependency in duplicate tests between the HPKE crate and the crypto crates that implement it
3. Invalid metadata in the rust crypto provider
4. Invalid link in build badge

In preparation to publish to crates.io.

Issues:

Resolves #12

Description of changes:

Just a version requirement update.

Call-outs:

N/A

Testing:

Built.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

Problem:

crates.io does not allow dependency versions specified as *. E.g. in mls-rs/Cargo.toml:

mls-rs-core = { path = "../mls-rs-core", default-features = false, version = "*" }

Solution:

Wildcard version requirements need to be changed to version numbers.

Requirements / Acceptance Criteria:

Our crates can be published to crates.io.

Out of scope:

N/A

Issues:

Resolves #6

Description of changes:

Added the necessary flags to support docs.rs + feature flags for the mls-rs crate

Call-outs:

Specifically did not look at the other crates, maybe some follow up work there later.

Testing:

The documentation with feature labeling can be generated following the instructions here

Description of changes:

• Group secrets are encrypted in parallel.
• The group_add benchmark doesn't encrypt the tree in the welcome message, which is a more common use case.
• The group_add benchmark is added to CI.

Testing:

Run cargo bench --features benchmark_util --bench group_add locally on an M1 MAC. For 1000 adds the result is

• main : 419.84 ms
• after this PR but encrypting the tree : 174.00 ms (= 42% of 419.84ms)
• after this PR : 155.88ms

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

Description of changes:

Also fix 2 bugs found by the tests:

• The context extensions were not updated without the by_ref_proposal feature
• The GroupSecrets struct was serialized incorrectly without the psk feature -- the psks list was omitted instead of set to empty list. (Trying to process a commit/welcome with PSKs while not using the psk feature will always fail, at latest with "invalid confirmation tag".)

configs were adjusted from https://github.com/mlswg/mls-implementations/tree/main/interop/configs to work with all feature sets.

Testing:

The CI runs the new tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

Description of feature:

The size reduction offered by turning off the features external_proposal, external_commit or all_extensions, was not deemed worth the added complexity.

Use case:

Somewhat simpler code and easier maintenance.

Issue #, if available: Resolves #1

Description of changes:

Added codeowners, issue temples, and code of conduct

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

We had a set of duplicate tests, one in HPKE and another in core which is used to determine if a crypto provider is meeting the standard properly. We should replace the test vector data in the currently active test within mls-rs-core with the one that was previously used in mls-rs-hpke