Is your feature request related to a problem? Please describe. No.

Describe the solution you'd like The proxy listens on 127.0.0.1, which only allows connections from localhost. I want to use the proxy for other devices in the network.

It might be a good idea to allow the user to select a cert to use instead of providing a CA that needs to be trusted by the system. This would allow users to take advantage of something like mkcert for local use in a more flexible way.

Hello! My name is Marcel and I'm a recent Bachelor's graduate and Rust enthusiast 🦀. I saw your posting on TWIR Call for Participation, and it seemed like a perfect avenue for my first open source contribution, closes #6.

https://user-images.githubusercontent.com/45983298/220324277-61a83201-38bc-4835-bc17-cf89d73c905b.mov

I did my best to maintain the existing inline style of the code, and no keep the filter minimally intrusive visually. Please let me know if there's anything you'd like me to change :)

Should solve: #8 The commit adds an extra button per request that let's the user remove the request.

A couple things: Because the rows per request are generated by iterating over the vector of MitmProxy.requests and we want to remove an entry from that vector while iterating over it, I had to copy the vector and iterate over the copy so that I could change the MitmProxy.requests freely. Not sure if this is the best approach, but works as of now.

Also the order of how the different panels and columns are rendered had to be changed because otherwise render_right_panel would cause an index out of bounds error if a request got deleted in the call to self.table_ui beforehand. That's because it would try to render the right panel for a request that was deleted. Maybe we could also do it like this to make sure that every call to self.render_right_panel() always has the latest version of self.requests:

ui.columns(2, |columns| {
            ScrollArea::both()
                .id_source("requests_table")
                .show(&mut columns[0], |ui| self.table_ui(ui));

            if let Some(i) = self.state.selected_request {
                ScrollArea::vertical()
                    .id_source("request_details")
                    .show(&mut columns[1], |ui| {
                        self.render_right_panel(ui, i);
                    });
            }
        })

But then the sizing of the columns looks weird when start up of the application.

Let me know what you think.

Due to me and my initial laziness all communications between API and eGUI are done trough String in the following way: 1. Api Structs types -> 2. Convert all fields to String (even in twisted ways) -> 3. Output Struct (of String) -> 4. Send Output Struct via Thread channel to eGUI -> 5. eGui Receives Output Struct -> 6. eGui convert it to a new Requests struct (of String) in order to print it correctly.

It Sucks.

The goal is to avoid string conversion and if possible make order and consistency between API types and eGUI types in this way: 1. API Structs types -> 2. send that type via Channel -> 3. eGui Receives the structs and print it directly

Closes #20. While visual changes were, by design, kept to a minimum, one that fell into place is a display of the actual body bytes of the requests and responses

This could easily be expanded upon later, implementing decompression and interpreting the data in several ways (e.g. utf-8 vs png)

Describe the bug The App crashes if you clear the requests list if a request is selected

To Reproduce Steps to reproduce the behavior:

1. wait for some requests
2. Click on 🔍 button on a request
3. Click on 🚫 button (clear button) in the top bar
4. Crash

Expected behavior When we clear the list we expected that the selection to be removed

Resolution Best solution imho is to manage differently the selection with the state struct, with a state struct we can add an <Option> field called "selected", before clearing the list we can set that field as None. This is only the first solution that came to my mind but I think that it's could be good, I am however open to different and better solutions

Per issue #10 (https://github.com/emanuele-em/man-in-the-middle-proxy/issues/10), the repository should not use gendered language for naming the capabilities of this codebase. Rename this to something resembling machine-in-the-middle-proxy.

some parts are hardcoded to fix different and stupid bugs. It could be a good idea to store all numerical variables in idiomatic const to put in main.rs file:

• offsets
• dinstances
• paddings
• etc...

Is your feature request related to a problem? Please describe. add a toggle button (pause / play) in the bottom panel that allow to temporary stop the listening

Describe the solution you'd like it should only stop the "append to vec" action

Description add different colors for different request method, the color should be only the background of the method and not the background of the entire row