This is related to Issue #31 . I have used clipboard crate to copy the password to clipboard.

In case the clipboard is unavailable, default approach to only present the password is used.

While generating multiple passwords, no password is copied to clipboard.

Output copied from windows command prompt

Welcome to L🦀CKBOX!

Please enter the master password
>> 

Enter [1] add password [2] generate random password [3] list passwords [4] remove password [5] show password [6] update master password [7] exit
>> ^C

This is likely due to the fact that the Windows Command Prompt does not natively support ANSI escape codes, which are used by the colored crate to produce colored output.

Solution:

• Try termcolor which supports cross-platform abstraction for colors. Sunset colored crate from lockbox.

Related to Issue: https://github.com/SonuBardai/lockbox/issues/61

Addresses https://github.com/SonuBardai/lockbox/issues/47

Write tests for commands:

• [x] add_password

• [x] generate_password

• [x] show_password

• [x] remove_password

• [x] list_passwords

• [x] copy_to_clipboard https://github.com/SonuBardai/lockbox/issues/43

• [x] print in PasswordStore

• [x] Add help to all commands
• [x] Add help to all command flags
• [x] Update ASCII ART
• [x] Center align ASCII ART on help
  • [x] Update tests for get_about
• [x] Update README

Addresses clipboard dependencies issue introduced in this PR https://github.com/SonuBardai/lockbox/pull/34

Closes Issue https://github.com/SonuBardai/lockbox/issues/35

Functions added in this PR https://github.com/SonuBardai/lockbox/pull/72

These are the functions: https://github.com/SonuBardai/lockbox/blob/cba904ed7f81b5b06f2300c38c23d87a99bb3641/src/cli/io.rs#L67-L102

lockbox add --service dummy
Please enter the master password
>> 
Please enter the password
>> 
Error: Master password incorrect. Please try again.

Don't wait for user entering the password to be saved if master password is incorrect

Currently, the flags --password, --master, and --new-master accepts password values directly. This can be a vulnerability as the passwords can be easily read from command history. Rather, these flags should accept file paths that contain passwords.

cargo run -- update-master --master ./current_master.txt --new-master /tmp/new_master.txt

When there's multiple passwords associated with a single service, it helps organize the passwords by also adding the username which the password is linked with. A show password command looks for the exact match of [service + username]. It would be convenient if it had a broader scope where it first searched for matching services, and then go deeper into searching for specific username only if a username is provided. If there's no username provided in the search query then all password entries matching the service would make sense.

Current behavior

$ lockbox list
Service: instagram, Username: myaccount, Password: jOSjoewmgnosjgo
Service: facebook, Username: someusername-1, Password: OybNRFgdx7l5PK8f
Service: facebook, Username: someusername-2, Password: UJRJI1d2t2IqbEkq

$ lockbox show --service facebook --username someusername-1
Password: OybNRFgdx7l5PK8f

$ lockbox show --service facebook
Password not found

Desired behavior:

$ lockbox show --service facebook --username someusername-1
Password: OybNRFgdx7l5PK8f

$ lockbox show --service facebook
Username: someusername-1, Password: OybNRFgdx7l5PK8f
Username: someusername-2, Password: UJRJI1d2t2IqbEkq

$ lockbox show --service facebook --username someusername-1
Password: OybNRFgdx7l5PK8f

$ lockbox show --service facebook --username someusername-3
Password not found

There is no update-password flow in the tool right now. The way we update passwords is by deleting the old one and adding a new password. This is not ideal. We need an update password flow in the CLI and REPL. It should have options similar to the add-password command.

- User enters: service [Required]; username [Optional]
- Search for entry in store with matching service & username
- If found
    - User enters new password; password is updated
- else
    - Print password not found (OR) Create a new password (trigger the add password command)

Problem:

Right now we're only reading the master password once and using it to encrypt the password file. If the user mis-types the master password there's no way to gain access to the passwords stored in the password store.

Solution:

Ask the user to re-enter the master password and compare the two master password inputs before using the master password to encrypt the file. We want to do this in two cases:

1. Updating master password. This feature was setup here: https://github.com/SonuBardai/lockbox/pull/57
2. Setting up the password store for the first time (either through CLI or REPL). ie. here when we're creating a new password file when the file does not exist.