This crate basically provides a thin wrapper around the nativefiledialog C library, which itself is just a small abstraction on top of the OS dialogs. While nativefiledialog is small and easy to build, there's really no good reason why we can't go directly to the OS dialogs inside Rust without needing to have a submodule/wrapper for a C library.

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

The libraries needed for FreeBSD support are not in the default search-path on the system, this patch adds /usr/local/lib to rustc's search path on FreeBSD.

Related Issues

List related issues here

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Added an implementation of std::error::Error for NFDError. Used error::Error instead of just importing Error because I noticed that the rest of the file used a similar convention.

Thanks for maintaining this crate! Please release a new version once this is merged. :)

Related Issues

Fixes #7

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Added Clone & PartialEq traits to Response enum. I need to be able to compare against a Response directly (w/o using a match). As in:

if Response::Cancel != result {
    ...
}

This requires only PartialEq. I added Clone just because. For the same reason no one though PartialEq was needed here Clone may be needed by someone in a situation no one though about. :)

Describe the bug imgui (https://github.com/Gekkio/imgui-rs/) does not provide a file picker. So I gave a try to nfd2. The following piece of code (included in the definition of a window)

...
        if ui.small_button(im_str!("...")) {
            if let Ok(nfd2::Response::Okay(fname)) = nfd2::open_file_dialog(
                Some("bmp,png,jpg"), 
                None)
            {
                state.texture_import = fname.into();
            }
        }
...

makes panic the application.

The same code in a standalone application that does not use imgui-rs works perfectly. The issue exists also with the original nfdcrate.

I have no idea if I have to report the bug there (I guess) or in ìmgui-rs` repository.

Expected behavior No panic is expected.

Trace

thread 'main' panicked at 'already mutably borrowed: BorrowError', /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\src\libcore\cell.rs:798
:9
stack backtrace:
   0: core::fmt::write
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libcore\fmt\mod.rs:1069
   1: std::io::Write::write_fmt<std::sys::windows::stdio::Stderr>
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libstd\io\mod.rs:1427
   2: std::sys_common::backtrace::_print
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libstd\sys_common\backtrace.rs:62
   3: std::sys_common::backtrace::print
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libstd\sys_common\backtrace.rs:49
   4: std::panicking::default_hook::{{closure}}
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libstd\panicking.rs:198
   5: std::panicking::default_hook
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libstd\panicking.rs:218
   6: std::panicking::rust_panic_with_hook
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libstd\panicking.rs:511
   7: std::panicking::begin_panic_handler
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libstd\panicking.rs:419
   8: core::panicking::panic_fmt
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libcore\panicking.rs:111
   9: core::option::expect_none_failed
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\/src\libcore\option.rs:1211
  10: core::result::Result<core::cell::Ref<core::option::Option<winit::platform_impl::platform::event_loop::runner::EventLoopRunner<()>>>,
 core::cell::BorrowError>::expect<core::cell::Ref<core::option::Option<winit::platform_impl::platform::event_loop::runner::
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\src\libcore\result.rs:961
  11: core::cell::RefCell<core::option::Option<winit::platform_impl::platform::event_loop::runner::EventLoopRunner<()>>>::borrow<core::opt
ion::Option<winit::platform_impl::platform::event_loop::runner::EventLoopRunner<()>>>
             at /rustc/f509b26a7730d721ef87423a72b3fdf8724b4afa\src\libcore\cell.rs:798
  12: NtGdiExtSelectClipRgn
  13: winit::platform_impl::platform::event_loop::SubclassInput<()>::send_event<()>
             at C:\Users\giotr\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.21.0\src\platform_impl\windows\event_loop.rs:104
  14: winit::platform_impl::platform::event_loop::public_window_callback<()>
             at C:\Users\giotr\.cargo\registry\src\github.com-1ecc6299db9ec823\winit-0.21.0\src\platform_impl\windows\event_loop.rs:1382
  15: DefSubclassProc
  16: DefSubclassProc
  17: AddClipboardFormatListener
  18: GetParent
  19: CallWindowProcW
  20: glDebugEntry
  21: AddClipboardFormatListener
  22: GetParent
  23: GetParent
  24: IsRectEmpty
  25: KiUserCallbackDispatcher
  26: <unknown>
  27: DllGetClassObject
  28: <unknown>
  29: <unknown>
  30: <unknown>
  31: AddClipboardFormatListener
  32: PtInRect
  33: PtInRect
  34: PtInRect
  35: AddClipboardFormatListener
  36: GetParent
  37: GetParent
  38: IsRectEmpty
  39: KiUserCallbackDispatcher
  40: IsWindow
  41: DialogBoxIndirectParamAorW
  42: DialogBoxIndirectParamAorW
  43: DialogBoxIndirectParamW
  44: DllCanUnloadNow
  45: <unknown>
  46: NFD_OpenDialog
             at C:\Users\giotr\.cargo\registry\src\github.com-1ecc6299db9ec823\nfd2-0.1.1\nativefiledialog\src\nfd_win.cpp:426
  47: nfd2::open_dialog
             at C:\Users\giotr\.cargo\registry\src\github.com-1ecc6299db9ec823\nfd2-0.1.1\src\lib.rs:176
  48: nfd2::open_file_dialog
             at C:\Users\giotr\.cargo\registry\src\github.com-1ecc6299db9ec823\nfd2-0.1.1\src\lib.rs:121
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
error: process didn't exit successfully: `target\debug\magicrasters.exe` (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN)

Device:

• OS: Window10
• Browser [e.g. chrome, safari]
• Version: 0.2.0 and 0.1.1 (not tested with previous one)

I don't think it is possible to return a file selection if the file name is not utf8 The Response returns a String, which must be valid utf8. The same constraint does not apply to files on the file system, consequently it is not possible to get a usable representation of the file name to such a file.

Alternative methods should be added with a new Response type For instance a "OsResponse" enum with Okay(OsString) could be returned from the new method.

This PR updates nfd to the devel branch to take advantage of some changes that haven't hit master yet. When updating, I also noticed that there was a memory leak where the path was not being freed, so fixed that.

This also fixes all the clippy lints as of 1.51.0.

Checklist

• [ ] I have read the Contributor Guide
• [ ] I have read and agree to the Code of Conduct
• [ ] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Describe your changes here

Related Issues

List related issues here

Checklist

• [x] I have read the Contributor Guide
• [x] I have read and agree to the Code of Conduct
• [x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

In creating my other PR to this repo (#9), I ran into a few things that I thought should be documented. Please feel free to nitpick my wording. Preferably using GitHub's new suggestions feature so I can quickly merge in the changes.

Thanks for maintaining this crate!

Related Issues

N/A

While the underlying C library only supports utf-8 strings, the API has been changed to use the more idiomatic Path and PathBuf types for working with the file system.

Resolves: #4

The new pure-Rust rfd crate replaces this crate, so let's close this project!

Think we can do:

• [ ] Push out a release of this where we mark it in the README.md and Cargo.toml as unmaintained & recommend rfd
• [ ] Publish a RUSTSEC advisory about the same
• [ ] Archive this github repo

Anything else? We didn't have it listed on embark.dev/embark.rs as it was just a fork, otherwise we would have removed from there also.

Crate is missing top-level documentation. This is the first thing users see when going to https://docs.rs/nfd2 or using rustdoc. Copying readme might be good start. Also, other items are missing (or have wrong) documentation. E.g. open_pick_folder is described as "Open save dialog".