I've noticed some cases where an orr with xzr or wzr does not disassemble as a mov. Changing tiny details makes a mov or a mvn as expected.

I'm not sure this is an incorrect disassembly. I have seen similar cases where the orr form is being used because the mov form would assemble to a different instruction. However, I can't explain the following cases:

orr w0, wzr, w1, lsl #0x15 // orn is fine.
orr x0, xzr, x1, lsl #0x15 // orn is fine.
orr x0, xzr, #0x3333333333333333 // 32-bit is fine.

Of course, this is not a serious problem. All these disassemblies would assemble back to the correct instruction. The issue is only that the disassembly is not using the mov alias.

Thanks for a great project. This is exactly what I need! However, I need a version that builds on Rust stable. Attempting to build on stable gives the following errors:

$ cargo check
[... lines omitted ...]
    Checking bad64 v0.2.0 (/home/apt1002/temp/bad64)
error[E0554]: `#![feature]` may not be used on the stable release channel
  --> src/lib.rs:67:1
   |
67 | #![feature(maybe_uninit_uninit_array, maybe_uninit_extra, maybe_uninit_slice)]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0554]: `#![feature]` may not be used on the stable release channel
  --> src/lib.rs:68:1
   |
68 | #![feature(array_map)]
   | ^^^^^^^^^^^^^^^^^^^^^^

These problems are pretty easy to fix. It is sufficient to initialise some variables and find an alternative to array_map. You might not like all my choices in this pull request; they are only intended to show that the fix is easy.

Yours hopefully,

• Alistair

Updates the requirements on bad64-sys to permit the latest version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

The falcon arm64 stuff is almost done. The falcon portion, at least, is done.

I am hoping you will upstream these changes. These changes:

1. Eliminate that terrible, awful Operand::None case I put in your library for some reason. Apologies for that, and... it's gone. Instead, operands will default to an Imm::Unsigned(0). The user will never see those values, so it shouldn't matter too much. The original purpose of that case was to give us something to use instead of MaybeUninit, which is not yet stable.
2. Implement the std::error::Error trait behind a std feature flag. The create remains no_std, but this is going to make it much easier to integrate Bad64 into projects which use convenience error things like error-chain or failure or what have you. No one should use those, btw, but the past is what it is.

So a wonderful person wrote an AARCH64 lifter for Falcon against these bindings :)! https://github.com/kawadakk/falcon/tree/aarch64-bad64

I want to bring these bindings into Falcon (we're working it https://github.com/falconre/falcon/pull/108). In order for that to happen those bindings are going to need to build stable, which means bad64 will need to build stable.

This PR is a proposal to make bad64 build stable. It's probably slightly slower than the original. Very open to comments. Let me know.

This panics on main right now, but run to completion, looks like:

checked 134217728 words (3.1%) in 7.7s (19173961 words/sec)
checked 268435456 words (6.3%) in 17.1s (15790321 words/sec)
checked 402653184 words (9.4%) in 28.8s (14380471 words/sec)
checked 536870912 words (12.5%) in 38.9s (14128182 words/sec)
checked 671088640 words (15.6%) in 46.8s (14588883 words/sec)
checked 805306368 words (18.8%) in 59.6s (13649260 words/sec)
checked 939524096 words (21.9%) in 71.9s (13232734 words/sec)
checked 1073741824 words (25.0%) in 82.1s (13094412 words/sec)
checked 1207959552 words (28.1%) in 89.8s (13572579 words/sec)
checked 1342177280 words (31.3%) in 99.6s (13557346 words/sec)
checked 1476395008 words (34.4%) in 108.8s (13670324 words/sec)
checked 1610612736 words (37.5%) in 118.2s (13649260 words/sec)
checked 1744830464 words (40.6%) in 126.1s (13847861 words/sec)
checked 1879048192 words (43.8%) in 138.6s (13616291 words/sec)
checked 2013265920 words (46.9%) in 147.3s (13695687 words/sec)
checked 2147483648 words (50.0%) in 157.1s (13678240 words/sec)
checked 2281701376 words (53.1%) in 165.4s (13828493 words/sec)
checked 2415919104 words (56.3%) in 174.7s (13884593 words/sec)
checked 2550136832 words (59.4%) in 187.5s (13637095 words/sec)
checked 2684354560 words (62.5%) in 197.2s (13626165 words/sec)
checked 2818572288 words (65.6%) in 205.4s (13749133 words/sec)
checked 2952790016 words (68.8%) in 218.2s (13544908 words/sec)
checked 3087007744 words (71.9%) in 231.0s (13421773 words/sec)
checked 3221225472 words (75.0%) in 240.1s (13421773 words/sec)
checked 3355443200 words (78.1%) in 248.6s (13530013 words/sec)
checked 3489660928 words (81.3%) in 258.4s (13525818 words/sec)
checked 3623878656 words (84.4%) in 268.8s (13521935 words/sec)
checked 3758096384 words (87.5%) in 277.4s (13567135 words/sec)
checked 3892314112 words (90.6%) in 285.6s (13657242 words/sec)
checked 4026531840 words (93.8%) in 294.3s (13695687 words/sec)
checked 4160749568 words (96.9%) in 303.6s (13731847 words/sec)
decoded 1544103388 valid instructions in 312.9s

Updates the requirements on xmas-elf to permit the latest version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Updates the requirements on xmas-elf to permit the latest version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.