Resolves #348

Uses standard styles where applicable, gives songs more space, uses multipliers of 6 for margins, makes album cover larger, uses real icon for like button, ~~adds an animated playback indicator~~ (#358), ~~makes the entire window scrollable~~ and tries to replicate the boxed-list style for songlist.

TODO:

• ~~[ ] Pause playback indicator with the song~~ will be in a followup
• [x] Make album header adaptive
• • [x] Ditto for playlist
• [x] Kill custom styles and classes where possible
• [x] Use boxed-list-ish style on queue and saved songs
• • [ ] ~~Add initial state for queue~~ will be in a followup
• [x] Ditto for artist view lists
• [x] Add border and rounded corners to album cover
• [ ] ~~Add inline release details?~~

This pull request focuses on adding a button and ui to albums to display some album info.

• Added a button in albums to go to the info screen
• Added a ui to display the info for albums

The layout is as follows:

Addresses #232

I inserted a column for the album name in the playlist view, as was described in the issue.

I'm not entirely happy with how the UI looks with it now. I think it would look best if we showed the album name beneath the artist, but I feel like that would be worse since it wastes so much vertical space. I'm attaching a screenshot so we can discuss.

Since I am not experienced with both Rust and GTK I'd be happy for any pointers as to what could be improved here, even though this is a small change.

Thanks for the awesome spotify client!

This PR will hopefully fix #305. I'm new to the project and am still getting used to the codebase so I might have edited the wrong files.

Unresolved stuff

• What should go in Library's
  • [x] title
  • [x] description
  • [x] icon
• What should go in Playlists'
  • [x] title
  • [x] description
  • [x] icon

Report all the information from SongDescription to MPRIS, this meant adding album name and art url.

I would've added more but it seems unecessary to add extra information to SongDescription just for mpris reporting

• Don't use .card, use custom style for playlists instead One thing about the previous MR is that .card applies to the entire ListView, including stuff like rounded corners. Herein, I try to recreate the .boxed-list style, applying the style to individual rows.
• Use AdwClampScrollable In practice, this means that the scrollbar is where it's supposed to be while technically being under ListView ∈ ScrolledWindow rule.
• Visually merge album header & headerbar Make header revealing/collapsing feel more intentional.

Resolves #379

As you can see on the Picture the window is to large if you use the PinePhone in vertical rotation (or normal use). In horizontal rotation it works fine. The PinePhone uses as screen resolution 720 x 1440 px with double scale PhoshUI.

Describe the bug Two close buttons on elementaryOS

Screenshots

General information:

• Distribution: elementaryOS 6.1
• Installation method: Flathub
• Version: 0.3
• Device used: Desktop

Additional context I think these are related.

I'm working on #142 and trying to create the UI first (see components/settings/) then to integrate it with some structs in src/settings.rs.

Currently I am stuck at how to handle the AdwPreferencesWindow. I have set up XML file with some widgets, added a button in the user menu, but an empty window is shown:

Hello! Thanks, for this cool project! I decided to contribute and added support for Russian language.

If there are any problems, please write under pull request.

Describe the bug A clear and concise description of what the bug is. Following the manual build instructions in the README, it seems like everything ran fine. However, I get this message at the end:

[1/2] Generating spot_gresource with a custom command

It seems like there's suppose to be a second step that never happens? When I go directly to spot/target/src and issue ./spot I get the following error message:

thread 'main' panicked at 'Could not load resources: Error { domain: g-file-error-quark, code: 4, message: "Failed to open file “/home/barbarossa/.local/share/spot/spot.gresource”: open() failed: No such file or directory" }', src/main.rs:55:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

To Reproduce Steps to reproduce the behavior: Install dependencies run meson and then ninja commands try to run the spot executable

Expected behavior Running the spot executable should have everything running fine

Screenshots If applicable, add screenshots to help explain your problem.

General information:

• Distribution: Arch Linux
• Installation method [e. g. built from source, installed from Flathub...]: Source
• Version [e.g. 0.1.0]: 0.1.7 (git)
• Device used [e. g. desktop, phone...]: desktop

Stack trace: If applicable, run the application from a terminal and paste relevant log output.

thread 'main' panicked at 'Could not load resources: Error { domain: g-file-error-quark, code: 4, message: "Failed to open file “/home/barbarossa/.local/share/spot/spot.gresource”: open() failed: No such file or directory" }', src/main.rs:55:10
stack backtrace:
   0:     0x558c5e7096b0 - std::backtrace_rs::backtrace::libunwind::trace::hc8b42b9686bc0d07
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/../../backtrace/src/backtrace/libunwind.rs:90:5
   1:     0x558c5e7096b0 - std::backtrace_rs::backtrace::trace_unsynchronized::h839b1b3e096c7094
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x558c5e7096b0 - std::sys_common::backtrace::_print_fmt::h9f36d7c0c192ca75
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/sys_common/backtrace.rs:67:5
   3:     0x558c5e7096b0 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::haad7d3f8925bad2e
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/sys_common/backtrace.rs:46:22
   4:     0x558c5e72d2bc - core::fmt::write::h7239b2f9a99358fb
                               at /build/rust/src/rustc-1.50.0-src/library/core/src/fmt/mod.rs:1078:17
   5:     0x558c5e702055 - std::io::Write::write_fmt::hf8c959f904cf1571
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/io/mod.rs:1517:15
   6:     0x558c5e70b955 - std::sys_common::backtrace::_print::h2c2d9abbb61e574c
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/sys_common/backtrace.rs:49:5
   7:     0x558c5e70b955 - std::sys_common::backtrace::print::h1362a4690ddc5737
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/sys_common/backtrace.rs:36:9
   8:     0x558c5e70b955 - std::panicking::default_hook::{{closure}}::h250793a7822001b5
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/panicking.rs:208:50
   9:     0x558c5e70b4aa - std::panicking::default_hook::h888581adc5c27c77
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/panicking.rs:225:9
  10:     0x558c5e70c0f1 - std::panicking::rust_panic_with_hook::h77f2fa3bf09efb3b
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/panicking.rs:591:17
  11:     0x558c5e70bc37 - std::panicking::begin_panic_handler::{{closure}}::h3cafa059e2851c7f
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/panicking.rs:497:13
  12:     0x558c5e709b6c - std::sys_common::backtrace::__rust_end_short_backtrace::h46c04e54576d0893
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/sys_common/backtrace.rs:141:18
  13:     0x558c5e70bb99 - rust_begin_unwind
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/panicking.rs:493:5
  14:     0x558c5e72aa11 - core::panicking::panic_fmt::hb1f208d1d41afb98
                               at /build/rust/src/rustc-1.50.0-src/library/core/src/panicking.rs:92:14
  15:     0x558c5e72a833 - core::option::expect_none_failed::h5d536c1ceba4b362
                               at /build/rust/src/rustc-1.50.0-src/library/core/src/option.rs:1268:5
  16:     0x558c5d2e1ea0 - core::result::Result<T,E>::expect::h99b4e43ee2788aaf
                               at /build/rust/src/rustc-1.50.0-src/library/core/src/result.rs:933:23
  17:     0x558c5d23a723 - spot::setup_gtk::h6f1c5b8f6b5c75ad
                               at /home/barbarossa/spot/src/main.rs:54:15
  18:     0x558c5d23a30c - spot::main::h151af790995fc8bb
                               at /home/barbarossa/spot/src/main.rs:19:5
  19:     0x558c5d21cf6b - core::ops::function::FnOnce::call_once::hd74b7030723ffbc4
                               at /build/rust/src/rustc-1.50.0-src/library/core/src/ops/function.rs:227:5
  20:     0x558c5d382dde - std::sys_common::backtrace::__rust_begin_short_backtrace::h4067052d650c56ea
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/sys_common/backtrace.rs:125:18
  21:     0x558c5d33fe11 - std::rt::lang_start::{{closure}}::h736c908f18ab0bbb
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/rt.rs:66:18
  22:     0x558c5e70c517 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h5a27e92186d531b9
                               at /build/rust/src/rustc-1.50.0-src/library/core/src/ops/function.rs:259:13
  23:     0x558c5e70c517 - std::panicking::try::do_call::h8d3a36b2860fc4e2
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/panicking.rs:379:40
  24:     0x558c5e70c517 - std::panicking::try::hefdcf6df93f20790
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/panicking.rs:343:19
  25:     0x558c5e70c517 - std::panic::catch_unwind::h36ddc1c42bb74870
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/panic.rs:396:14
  26:     0x558c5e70c517 - std::rt::lang_start_internal::ha6cc4bb09c664b1a
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/rt.rs:51:25
  27:     0x558c5d33fde7 - std::rt::lang_start::h1a064a3b694e24e5
                               at /build/rust/src/rustc-1.50.0-src/library/std/src/rt.rs:65:5
  28:     0x558c5d23a97a - main
  29:     0x7f4be5b97b25 - __libc_start_main
  30:     0x558c5d1d30be - _start
  31:                0x0 - <unknown>

Additional context Can this only be used for Gnome? I'm trying to build/run it on Qtile

Bumps tokio from 1.17.0 to 1.24.1.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

I'm not a gnome developer, so I wouldn't estimate the amount of work it would take, but the ability to synchronize local files would be very useful. Spot is very nice to use and not being constrained to the spotify catalog would make it THE music player.

Thank you for taking the time to read this issue, I have some basic rust if you take the time to work on it I would be happy to participate

Hey, I really like the interface and usage of spot. Could it be possible to add an alternative YouTube Music backend? In this case you don't need any registered account or premium membership. There's already a gtk youtube music client over here https://github.com/misterhat/youtube-music-gtk

Best regards Jonas

Bumps gio from 0.15.7 to 0.16.7.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps gdk-pixbuf from 0.15.6 to 0.16.7.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.