Re: https://github.com/clap-rs/clap/issues/4510

Considering is_terminal is seen as direct migration from atty -

When people are migrating off atty they will get this error under wasm32-u-u if there is callpath to is_terminal:

  --> .cargo/registry/src/github.com-1ecc6299db9ec823/errno-0.2.8/src/lib.rs:33:1
   |
33 | mod sys;
   | ^^^^^^^^
   |
   = help: to create the module `sys`, create file ".cargo/registry/src/github.com-1ecc6299db9ec823/errno-0.2.8/src/sys.rs" or ".cargo/registry/src/github.com-1ecc6299db9ec823/errno-0.2.8/src/sys/mod.rs"

error[E0425]: cannot find function `errno` in module `sys`
   --> .cargo/registry/src/github.com-1ecc6299db9ec823/errno-0.2.8/src/lib.rs:101:10
    |
101 |     sys::errno()
    |          ^^^^^ not found in `sys`

error[E0425]: cannot find function `set_errno` in module `sys`
   --> .cargo/registry/src/github.com-1ecc6299db9ec823/errno-0.2.8/src/lib.rs:106:10
    |
106 |     sys::set_errno(err)
    |          ^^^^^^^^^ not found in `sys`

Would it be feasible to stub out wasm32-u-u that it still builds and provides false to is_terminal ?

Or at least if the dependency is there it does not try to build stuff in wasm32-u-u that will fail to compile ?

Considering the below -

Even if one stamps out the calls to is_terminal then io-lifetimes doesn't build at all if it's present in the dependencies

Sometimes the dependencies come via default features as in case of clap which made it pretty complicated to remove -

Yeah I know wasm32-u-u doesn't have terminal but would it be feasible to provide stubs for it to ease migration ?

Or at least cfg gate some of it out @ target_family = "wasm", target_os = "unknown" ?

Cheers

There are two issues in the current implementation of the msys_tty_on function. Firstly, the size returned by the GetFileInformationByHandleEx function is the size in bytes not in characters. Secondly, the path can exceed the MAX_PATH constant.

I stumbled upon this issue when some of our tests begin to fail on Windows after the update to the env_logger 0.10 version which switches to the is-terminal crate.

The current badge image URI returns 404 Not Found as it points to a workflow named "CI". This fixes it by renaming the workflow to "CI" instead of "Continuous integration"

I'm trying to use is_terminal as a dependency in my project but it doesn't compile on Windows, complaining that the module windows_sys::Win32::Storage doesn't exist. Modifying is_terminal's Cargo.toml like this makes it work:

[target.'cfg(windows)'.dependencies.windows-sys]
version = "0.42.0"
features = [
    "Win32_Foundation",
+   "Win32_Storage_FileSystem",
    "Win32_System_Console",
]

So the fix should be straightforward, however, I'm not really sure how all those other people who presumably use this crate on Windows managed to get it to compile without this feature flag?