To the best of my understanding of C99, this implements partial initialization (previous discussion), dealing with zeroing and out of order fields.

struct grade {
  float percentage;
  int failing;
};
struct student {
  struct student *friends;
  int age;
  struct grade marks;
};

void f() {
  struct student s;
  s = (struct student) { };
  s = (struct student) { .age = 9 };
  s = (struct student) { .age = 9, { 0.45, 1 } };
  s = (struct student) { .age = 9, { .percentage = 0.45, .failing = 1 } };
  s = (struct student) { 0, 9, { 0.45, 1 } };
  s = (struct student) { .marks = { 0.45, 1 }, .age = 9 };
}

compiles to

#[derive(Clone, Copy)]
#[repr(C)]
pub struct grade {
    pub percentage : f32,
    pub failing : i32,
}

#[derive(Clone, Copy)]
#[repr(C)]
pub struct student {
    pub friends : *mut student,
    pub age : i32,
    pub marks : grade,
}

#[no_mangle]
pub unsafe fn f() {
    let mut s : student;
    s = student {
            friends: 0 as (*mut student),
            age: 0i32,
            marks: grade { percentage: 0f32, failing: 0i32 }
        };
    s = student {
            friends: 0 as (*mut student),
            age: 9i32,
            marks: grade { percentage: 0f32, failing: 0i32 }
        };
    s = student {
            friends: 0 as (*mut student),
            age: 9i32,
            marks: grade { percentage: 0.45f64 as (f32), failing: 1i32 }
        };
    s = student {
            friends: 0 as (*mut student),
            age: 9i32,
            marks: grade { percentage: 0.45f64 as (f32), failing: 1i32 }
        };
    s = student {
            friends: 0i32 as (*mut student),
            age: 9i32,
            marks: grade { percentage: 0.45f64 as (f32), failing: 1i32 }
        };
    s = student {
            friends: 0 as (*mut student),
            age: 9i32,
            marks: grade { percentage: 0.45f64 as (f32), failing: 1i32 }
        };
}

And code that has too many initializers or designators that do not correspond to fields or non-member designators is dealt with via badSource.

One thing that isn't clear to me from the C99 spec on initialization (6.7.8) - when does it make sense to have multiple designators for a given initializer? Seems like point 18 addresses this, and I think this means I am rejecting valid code, since I currently assume that an initializer can have at most one designator (and it must be a member designator)...

extern int printf (const char *format, ...);
extern int getchar(void);

int main(void)
{
    int n=0;
    printf("input a string ：\n");
loop: if(getchar()!='\n')
      {
          n++;
          goto loop;
      }
      printf("length is %d\n",n);
}

corrode: ("goto.c": line 10): Corrode doesn't handle this yet:
    loop:
        if (getchar() != '\n')
        {
            n++;
            goto loop;
        }

The CWhile constructor of CExpression is currently only translated if its Bool flag is False, meaning this is a regular while-loop which tests the loop condition before entering the loop.

If that flag is True, then we need a different translation plan. Since Rust doesn't have do-while loops, we'll have to translate these like this:

loop {
    ...
    if !cond { break; }
}

But like for loops, it's a little trickier than that if the loop contains any continue statements. The same strategy we use on for loops should work here, though:

'breakTo: loop {
    'continueTo: loop {
        ...
        break;
    }
    if !cond { break; }
}

Like with for loops, break and continue statements should be translated to break 'breakTo and break 'continueTo, respectively.

I get the following error running cabal install or stack install in the project root:

cabal install output:

Resolving dependencies...
Configuring corrode-0.1.0.0...
Building corrode-0.1.0.0...
Failed to install corrode-0.1.0.0
Build log ( C:\Users\crame\AppData\Roaming\cabal\logs\corrode-0.1.0.0.log ):
Building corrode-0.1.0.0...
Preprocessing library corrode-0.1.0.0...

src\Language\Rust\Corrode\C.lhs:1:1: error:
    File name does not match module name:
    Saw: `Main'
    Expected: `Language.Rust.Corrode.C'
cabal: Leaving directory '.'
cabal: Error: some packages failed to install:
corrode-0.1.0.0

stack install output:

corrode-0.1.0.0: build
Preprocessing library corrode-0.1.0.0...

C:\Users\crame\rustiness\corrode\src\Language\Rust\Corrode\C.lhs:1:1:
    File name does not match module name:
    Saw: `Main'
    Expected: `Language.Rust.Corrode.C'

--  While building package corrode-0.1.0.0 using:
      C:\Users\crame\AppData\Roaming\stack\setup-exe-cache\x86_64-windows\setup-Simple-Cabal-1.22.5.0-ghc-7.10.3.exe --builddir=.stack-work\dist\2672c1f3 build lib:corrode exe:corrode --ghc-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1

This occurs on 64 bit Windows after a fresh install of the Haskell Platform.

C's enum types are pretty easy to translate except for the fact that C allows arbitrary integer values to be used where an enum variant is expected. Rust's enums don't allow that (as far as I know).

So step one is: Figure out what we can translate C enums to in Rust that will allow valid C programs to be translated (even if they use values outside the range of the enum), while ideally preserving all uses of the names of the enum variants.

This simple code does not produce the correct output

    for (int i = 0;i < num_clusters;++i) {
        if (clusters[i] == best_index) {
            fake_memmove(&clusters[i],
                    &clusters[i+1],
                    (num_clusters - i- 1)* sizeof(clusters[0]));
            break;
        }
    }

the break is omitted from the output code

    let mut i : i32 = 0i32;
    'loop1: loop {
        if i < num_clusters {
            if clusters[i as (usize)] == best_index {
                fake_memmove(
                    &mut clusters[
                             i as (usize)
                         ] as (*mut u32) as (*mut ::std::os::raw::c_void),
                    &mut clusters[
                             (i + 1i32) as (usize)
                         ] as (*mut u32) as (*mut ::std::os::raw::c_void),
                    ((num_clusters - i - 1i32) as (usize)).wrapping_mul(
                        ::std::mem::size_of::<u32>()
                    )
                );
            } else {
                i = i + 1;
                continue 'loop1;
            }
        } else {
            break 'loop1;
        }
    }

A fix would be appreciated: I've been using corrode to translate the brotli encoder and I'm worried I've hit this situation more than once

Everything that I try and translate seems to result it pub unsafe fn main() -> i32 { 0i32 } or something similar (depending on the types used in the c program). Why is this?

The CSizeofExpr and CAlignofExpr constructors of CExpression should be translated almost identically to the CSizeofType and CAlignofType constructors, respectively, except that the expression needs to be translated using interpretExpr.

However, I'm not sure about the exact translation. There are two possibilities:

1. If the expression is supposed to have its side effects evaluated, then we should pass a borrow of the resulting expression to std::mem::size_of_val.
2. Otherwise, if side effects are not supposed to be evaluated, we should just use the resultType from translating the expression, throwing away the expression itself, and proceed just like CSizeofType/CAlignofType.

Before trying to implement this, we need a citation to C99 or C11 which clarifies whether the expression should actually be evaluated.

Clang will convert some instances of calls to memcpy to __builtin_memcpy_chk.

I believe that passing -fno-builtin along should address this, but I'm not sure.

This results in an error like:

("rectset.c": line 50): illegal undefined variable; check whether a real C compiler
    accepts this:
    __builtin___memcpy_chk

from this C:

  memcpy(rects, trs->rects, n * sizeof(trs->rects[0]));

Now that I can at least partially read Haskell, I'm going to try out a (potentially) easy first change: Translate __FUNCTION__. It's currently regarded as badSource:

("shared_types_gen.h": line 19): illegal undefined variable; check whether a real C compiler accepts this:
    __FUNCTION__

Would it be correct and appropriate to add __FUNCTION__ to getSymbolIdent's list of builtin symbols?

Properly translating this to Rust depends on rust-lang/rfcs/pull/1719, but for now, I could look up the current function name in the symbol environment.

I could then follow up by translating __FILE__ and __LINE__ to Rust's file! and line! macros respectively, which is arguably slightly simpler, but __FUNCTION__ is first in my sights.

• https://docs.travis-ci.com/user/languages/haskell
• https://ghc.haskell.org/trac/ghc/wiki/Travis

probably test against 8.x and 7.10 so that things like #39 would get caught sooner

src/Language/Rust/AST.hs:29:36: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 29 | pPrint (Lifetime s) = text "'" <> text s | ^^

src/Language/Rust/AST.hs:89:32: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 89 | pPrint (Stmt e) = pPrint e <> text ";" | ^^

src/Language/Rust/AST.hs:94:11: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 94 | ] <> text ";" | ^^

src/Language/Rust/AST.hs:96:21: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 96 | [ text "#[" <> text attr <> text "]" | Attribute attr <- attrs ] ++ [pPrint k] | ^^

src/Language/Rust/AST.hs:96:34: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 96 | [ text "#[" <> text attr <> text "]" | Attribute attr <- attrs ] ++ [pPrint k] | ^^

src/Language/Rust/AST.hs:112:21: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 112 | [ text "#[" <> text attr <> text "]" | Attribute attr <- attrs ] ++ | ^^ src/Language/Rust/AST.hs:112:34: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 112 | [ text "#[" <> text attr <> text "]" | Attribute attr <- attrs ] ++ | ^^
src/Language/Rust/AST.hs:113:66: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 113 | [(if vis == Public then zeroWidthText "pub " else empty) <> pPrint k] | ^^ src/Language/Rust/AST.hs:136:11: error: Precedence parsing error cannot mix ‘<+>’ [infixl 6] and ‘Prelude.<>’ [infixr 6] in the same infix expression | 136 | [ hsep (map pPrint attrs) <+> text "fn" <+> text nm <> text "(" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/Language/Rust/AST.hs:136:61: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 136 | [ hsep (map pPrint attrs) <+> text "fn" <+> text nm <> text "(" | ^^ src/Language/Rust/AST.hs:145:11: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 145 | ] <> text ";" | ^^
src/Language/Rust/AST.hs:148:24: error: Precedence parsing error cannot mix ‘<+>’ [infixl 6] and ‘Prelude.<>’ [infixr 6] in the same infix expression | 148 | nest 4 (vcat [ text "pub" <+> text field <+> text ":" <+> pPrint ty <> text "," | (field, ty) <- fields ]) $+$ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/Language/Rust/AST.hs:148:77: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 148 | nest 4 (vcat [ text "pub" <+> text field <+> text ":" <+> pPrint ty <> text "," | (field, ty) <- fields ]) $+$ | ^^
src/Language/Rust/AST.hs:155:25: error: Precedence parsing error cannot mix ‘<+>’ [infixl 6] and ‘Prelude.<>’ [infixr 6] in the same infix expression | 155 | pPrint (Use path) = text "use" <+> text path <> text ";" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Language/Rust/AST.hs:155:50: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 155 | pPrint (Use path) = text "use" <+> text path <> text ";" | ^^
src/Language/Rust/AST.hs:158:36: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 158 | nest 4 (vcat [ pPrint enum <> text "," | enum <- enums ]) $+$ | ^^ src/Language/Rust/AST.hs:164:32: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 164 | , text "clone" <> parens (text "&self") | ^^
src/Language/Rust/AST.hs:180:11: error: Precedence parsing error cannot mix ‘<+>’ [infixl 6] and ‘Prelude.<>’ [infixr 6] in the same infix expression | 180 | [ text "fn" <+> text nm <> text "(" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Language/Rust/AST.hs:180:33: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 180 | [ text "fn" <+> text nm <> text "(" | ^^
src/Language/Rust/AST.hs:185:11: error: Precedence parsing error cannot mix ‘<+>’ [infixl 6] and ‘Prelude.<>’ [infixr 6] in the same infix expression | 185 | , text ")" <+> (if ret == TypeName "()" then empty else text "->" <+> pPrint ret) <> text ";" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Language/Rust/AST.hs:185:91: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 185 | , text ")" <+> (if ret == TypeName "()" then empty else text "->" <+> pPrint ret) <> text ";" | ^^ src/Language/Rust/AST.hs:193:11: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 193 | ] <> text ";" | ^^
src/Language/Rust/AST.hs:305:62: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 305 | go pos _ (Index arr idx) = cat [go (left pos) 13 arr <> text "[", nest 4 (go RightExpr 0 idx), text "]"] | ^^
src/Language/Rust/AST.hs:311:40: error: Precedence parsing error cannot mix ‘Prelude.<>’ [infixr 6] and ‘<+>’ [infixl 6] in the same infix expression | 311 | go _ _ (RepeatArray el size) = text "[" <> go RightExpr 0 el <> text ";" <+> go RightExpr 0 size <> text "]" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Language/Rust/AST.hs:311:40: error: Precedence parsing error cannot mix ‘<+>’ [infixl 6] and ‘Prelude.<>’ [infixr 6] in the same infix expression | 311 | go _ _ (RepeatArray el size) = text "[" <> go RightExpr 0 el <> text ";" <+> go RightExpr 0 size <> text "]" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
src/Language/Rust/AST.hs:311:49: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 311 | go _ _ (RepeatArray el size) = text "[" <> go RightExpr 0 el <> text ";" <+> go RightExpr 0 size <> text "]" | ^^
src/Language/Rust/AST.hs:311:70: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 311 | go _ _ (RepeatArray el size) = text "[" <> go RightExpr 0 el <> text ";" <+> go RightExpr 0 size <> text "]" | ^^
src/Language/Rust/AST.hs:311:106: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 311 | go _ _ (RepeatArray el size) = text "[" <> go RightExpr 0 el <> text ";" <+> go RightExpr 0 size <> text "]" | ^^ src/Language/Rust/AST.hs:314:47: error: Precedence parsing error cannot mix ‘Prelude.<>’ [infixr 6] and ‘<+>’ [infixl 6] in the same infix expression | 314 | : punctuate (text ",") ([ nest 4 (text name <> text ":" <+> go RightExpr 0 val) | (name, val) <- fields ] ++ maybe [] (\b -> [ text ".." <> go RightExpr 0 b ]) base) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ src/Language/Rust/AST.hs:314:57: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 314 | : punctuate (text ",") ([ nest 4 (text name <> text ":" <+> go RightExpr 0 val) | (name, val) <- fields ] ++ maybe [] (\b -> [ text ".." <> go RightExpr 0 b ]) base) | ^^ src/Language/Rust/AST.hs:314:150: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 314 | : punctuate (text ",") ([ nest 4 (text name <> text ":" <+> go RightExpr 0 val) | (name, val) <- fields ] ++ maybe [] (\b -> [ text ".." <> go RightExpr 0 b ]) base) | ^^ src/Language/Rust/AST.hs:318:34: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 318 | ( go (left pos) 14 f <> text "(" | ^^ src/Language/Rust/AST.hs:323:37: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 323 | ( go (left pos) 13 self <> text "." <> pPrint f <> text "(" | ^^

src/Language/Rust/AST.hs:323:49: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 323 | ( go (left pos) 13 self <> text "." <> pPrint f <> text "(" | ^^ src/Language/Rust/AST.hs:323:61: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 323 | ( go (left pos) 13 self <> text "." <> pPrint f <> text "(" | ^^
src/Language/Rust/AST.hs:329:16: error: Precedence parsing error cannot mix ‘Prelude.<>’ [infixr 6] and ‘<+>’ [infixl 6] in the same infix expression | 329 | in text "|" <> args' <> text "|" <+> go RightExpr 0 body | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/Language/Rust/AST.hs:329:25: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 329 | in text "|" <> args' <> text "|" <+> go RightExpr 0 body | ^^
src/Language/Rust/AST.hs:329:34: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 329 | in text "|" <> args' <> text "|" <+> go RightExpr 0 body | ^^
src/Language/Rust/AST.hs:330:82: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 330 | go pos d (Member obj field) = maybeParens (d > 13) (go (left pos) 13 obj <> text "." <> pPrint field) | ^^

src/Language/Rust/AST.hs:330:94: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 330 | go pos d (Member obj field) = maybeParens (d > 13) (go (left pos) 13 obj <> text "." <> pPrint field) | ^^ src/Language/Rust/AST.hs:378:57: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 378 | optLabel = maybe empty (\ label -> pPrint label <> text ":") | ^^ src/Language/Rust/AST.hs:380:55: error: Ambiguous occurrence ‘<>’ It could refer to either ‘Prelude.<>’, imported from ‘Prelude’ at src/Language/Rust/AST.hs:1:8-24 (and originally defined in ‘GHC.Base’) or ‘Text.PrettyPrint.HughesPJClass.<>’, imported from ‘Text.PrettyPrint.HughesPJClass’ at src/Language/Rust/AST.hs:5:1-37 (and originally defined in ‘Text.PrettyPrint.HughesPJ’) | 380 | unary d n op e = maybeParens (d > n) (text op <> go RightExpr n e) | ^^ cabal: Leaving directory '.' cabal: Error: some packages failed to install: corrode-0.1.0.0-7JByiBhjcJ4AiUKajiokjH failed during the building phase. The exception was: ExitFailure 1

Hi,

I am trying to build corrode on OpenSUSE/Tumbleweed (constantly updated) with these packages installed:

corrode@stitny (master *%)$ rpm -qa cabal\* ghc\*|sort
cabal-install-3.2.0.0-3.3.x86_64
ghc-array-devel-0.5.4.0-3.1.x86_64
ghc-array-0.5.4.0-3.1.x86_64
ghc-base-devel-4.14.1.0-3.1.x86_64
ghc-base-4.14.1.0-3.1.x86_64
ghc-binary-devel-0.8.8.0-3.1.x86_64
ghc-binary-0.8.8.0-3.1.x86_64
ghc-bytestring-devel-0.10.10.0-3.1.x86_64
ghc-bytestring-0.10.10.0-3.1.x86_64
ghc-Cabal-devel-3.2.0.0-3.1.x86_64
ghc-Cabal-3.2.0.0-3.1.x86_64
ghc-compiler-8.10.2-3.1.x86_64
ghc-containers-devel-0.6.2.1-3.1.x86_64
ghc-containers-0.6.2.1-3.1.x86_64
ghc-deepseq-devel-1.4.4.0-3.1.x86_64
ghc-deepseq-1.4.4.0-3.1.x86_64
ghc-directory-devel-1.3.6.0-3.1.x86_64
ghc-directory-1.3.6.0-3.1.x86_64
ghc-exceptions-devel-0.10.4-3.1.x86_64
ghc-exceptions-0.10.4-3.1.x86_64
ghc-filepath-devel-1.4.2.1-3.1.x86_64
ghc-filepath-1.4.2.1-3.1.x86_64
ghc-ghc-boot-devel-8.10.2-3.1.x86_64
ghc-ghc-boot-th-devel-8.10.2-3.1.x86_64
ghc-ghc-boot-th-8.10.2-3.1.x86_64
ghc-ghc-boot-8.10.2-3.1.x86_64
ghc-ghc-compact-devel-0.1.0.0-3.1.x86_64
ghc-ghc-compact-0.1.0.0-3.1.x86_64
ghc-ghc-devel-8.10.2-3.1.x86_64
ghc-ghc-heap-devel-8.10.2-3.1.x86_64
ghc-ghc-heap-8.10.2-3.1.x86_64
ghc-ghci-devel-8.10.2-3.1.x86_64
ghc-ghci-8.10.2-3.1.x86_64
ghc-ghc-8.10.2-3.1.x86_64
ghc-haskeline-devel-0.8.0.1-3.1.x86_64
ghc-haskeline-0.8.0.1-3.1.x86_64
ghc-hpc-devel-0.6.1.0-3.1.x86_64
ghc-hpc-0.6.1.0-3.1.x86_64
ghc-language-c-0.9-1.2.x86_64
ghc-libiserv-devel-8.10.2-3.1.x86_64
ghc-libiserv-8.10.2-3.1.x86_64
ghc-libraries-8.10.2-3.1.x86_64
ghc-mtl-devel-2.2.2-3.1.x86_64
ghc-mtl-2.2.2-3.1.x86_64
ghc-parsec-devel-3.1.14.0-3.1.x86_64
ghc-parsec-3.1.14.0-3.1.x86_64
ghc-pretty-devel-1.1.3.6-3.1.x86_64
ghc-pretty-1.1.3.6-3.1.x86_64
ghc-process-devel-1.6.9.0-3.1.x86_64
ghc-process-1.6.9.0-3.1.x86_64
ghc-stm-devel-2.5.0.0-3.1.x86_64
ghc-stm-2.5.0.0-3.1.x86_64
ghc-syb-0.7.1-4.2.x86_64
ghc-template-haskell-devel-2.16.0.0-3.1.x86_64
ghc-template-haskell-2.16.0.0-3.1.x86_64
ghc-terminfo-devel-0.4.1.4-3.1.x86_64
ghc-terminfo-0.4.1.4-3.1.x86_64
ghc-text-devel-1.2.3.2-3.1.x86_64
ghc-text-1.2.3.2-3.1.x86_64
ghc-time-devel-1.9.3-3.1.x86_64
ghc-time-1.9.3-3.1.x86_64
ghc-transformers-devel-0.5.6.2-3.1.x86_64
ghc-transformers-0.5.6.2-3.1.x86_64
ghc-unix-devel-2.7.2.2-3.1.x86_64
ghc-unix-2.7.2.2-3.1.x86_64
ghc-xhtml-devel-3000.2.2.1-3.1.x86_64
ghc-xhtml-3000.2.2.1-3.1.x86_64
ghc-8.10.2-3.1.x86_64
corrode@stitny (master *%)$ 

I had to also install markdown-unlit directly via cabal install (I have version 0.5.0), but when I try to run cabal build (with few changes in https://github.com/mcepl/corrode/tree/build_opensuse) I get tons of erros and build fails.

Complete stdout/stderr of cabal build --verbose

Hi @jameysharp ,

I find this project interesting. Would you be willing to include these continuous integration and Docker image improvements?

This pull request considers PRs #147, #145 and #161: if you merge this PR without squashing or rebasing, those shall get closed automatically by GitHub.

I see there are some useful open pull requests, though there has not been much activity in the master branch in the last couple of years. It would be nice to get most of those changes reviewed and merged to a common branch that can be based upon. I started such an effort in the following branch:

https://github.com/lucafavatella/corrode/commits/develop-2019

(Deletion of that ^^^ branch planned for end of year 2019.)

I started from non-invasive tests (reflected in this PR), I may in the following months continue with including changes in other PRs. Though before doing so I wanted to check the activity in this repo hence this PR.

__builtin functions currently aren't accepted by corrode

On macos:

("/usr/include/math.h": line 205): illegal undefined variable; check whether a real C compiler accepts this:
    __builtin_fabsf

A good deal of people would install cabal and friends just to have corrode, better add another step so they won't be surprised if they dare to paste the commands and leave it unattended.