I am using Firefox 90.0.2 64bit on win10. I was on https://docs.rs/object/0.26.0/object/ and couldn't go to the top of the page, it just scrolls down again. After uninstalling the extension (or going private mode) it fixes itself.

• I type rs and space/tab into the address bar.
• "Rust Search Extension | " appears.
• I start typing, but it immediately goes back to the default Google search.

It was working fine the last time I used it ~2 weeks ago. I've tried restarting Chrome, disabling and reenabling the extension.

Google Chrome 88.0.4324.96 (Official Build) (x86_64) macOS Catalina 10.15.7 (19H114)

Every time I open chrome, the rust -search-extension is opening the https://rust.extension.sh/update page in a tab, regardless of any tabs(including itself) that were open on last chrome launch.

Steps to reproduce:

1. Install chrome
2. Install rust-search extension
3. Toggle Auto-update to On
4. Close all browser windows
5. Re-open Chrome
6. See a https://rust.extension.sh/update tab
7. Repeat steps 4-6 to witness issue persist

OS: Ubuntu 20.04 x64(Linux) Browser: Chrome Version 87.0.4280.141 (Official Build) (64-bit)

It'd be nice if you didn't need to explicitly click the "⊕ to Rust Search Extension" button on a crate's docs.rs page in order to search for items inside it.

Expected Behaviour

If you enter rs @itertools::XXX it would first try to find the corresponding page if already added and indexed, falling back to opening the search page (https://docs.rs/itertools/?search=XXX).

Actual Behaviour

Typing rs @itertools::Itertools and hitting <enter> just clears the search box and does nothing.

Typing rs !itertools::Itertools will navigate to https://docs.rs/releases/search?query=itertools%3A%3AItertools, i.e. it tries to find the itertools::Itertools crate in docs.rs.

Hi, it looks like there are some books that seem to be missing from the extension search which might be useful to add. Is this the complete list of supported books? https://github.com/huhu/rust-search-extension/blob/master/rust/src/tasks/books.json

From looking at https://www.rust-lang.org/learn :

• Rustdoc book: https://doc.rust-lang.org/rustdoc/index.html
• Rustc book: https://doc.rust-lang.org/rustc/index.html
• Command-line application book: https://rust-cli.github.io/book/index.html

If you'd be interested, I could open a PR to add these to the extension, in particular I think I would find the rustc book helpful to have easily searchable.

Currently, we have to use special prefix(~) to search external crates, it would be great if this extension would search both std docs and external crates by default (or at least provide a setting).

Hi,

since recently the extension does not work anymore for me. Entering "rs something" in the address bar and pressing enter results in the address bar being cleared but nothing else is happening.

Sebastian

I am using Firefox 84.0.1 on Manjaro and have rust-docs installed. I enabled offline mode and set the path to file:///usr/share/doc/rust/html/. Search itself works fine: for example, when I type "rs result" into the search box, it shows me a bunch of results with correct local paths, such as file:///usr/share/doc/rust/html/std/fmt/type.Result.html. But when I hit Enter, nothing happens. I tried the same with Chromium and everything works fine.

Hey. I got sent here when I removed the extension again. The feature I'm looking for is to search e.g. Tokio or futures docs for a certain term. I currently have firefox search bookmarks that allow this, but they just show the search results, and don't jump directly to the item, which is what I hoped this would allow me to do.

usually on docs.rs, when you visit an outdated version docs page of a crate, we get this orange colored warning "Go to latest version" button on top left.

but this extension moves the features dropdown button to the left of that yellow warning button. this happens after the page loads, so when i see the warning and try to click the "Go to latest version" link, I accidentally click the features button often.

this happens because of the delay between the page loading and the extension doing its magic.

this happens very often and frustrates me every time :(

Ideally, it would keep the features button where it already is, so that the orange Go to latest version button doesn't get pushed around.

Crates with hyphens have their version extracted from the DOM (when viewing the latest version of a crate and adding it to the extension's index) incorrectly.

For example, adding the latest embedded-hal release to the extension's index results in this:

This in turn causes the extension to produce invalid docs.rs links.

This snippet (which itself addressed fallout from rustdoc changing its version output) is the problematic bit:

https://github.com/huhu/rust-search-extension/blob/599b1c9a312751e3cfeef02e5f39d393aa091ba3/extension/script/add-search-index.js#L12-L15

Updating this to take the last element after splitting on - instead of the second fixes this case but I think this leaves other edge cases unhandled.

For example, cargo and friends allow for pre-release versions which are allowed to have hyphens (i.e. 0.0.1-my-extremely-unstable-release). While it's unlikely that the docs.rs "latest" link for a crate will redirect to one of these, it is still possible – docsrs will search stable, unyanked releases first but will fall back to pre-releases.

The wasi crate is one such example of this (no "stable" releases as of this writing, pre-release version has a hyphen in it: 0.11.0+wasi-snapshot-preview1).

Reverting to the previous method (grabbing the version from the sidebar) and changing the query to 'nav.sidebar .version' is general enough to support pages generated before and after the rustdoc version change without being too general (and potentially picking up things in user-added HTML snippets) I think. This is the change I have implemented.

The downside to this approach is that it doesn't work on rustdoc output that predates the addition of the version in the sidebar; since docs.rs doesn't rebuild docs for older releases this can be a real concern for older stable crates that haven't had a release in a while.

Another approach is to snoop through some of the relative links on the page and to extract the version from the relative URLs there. There doesn't seem to be an obvious thing in the DOM to go after and we're definitely still susceptible to changes in rustdoc this way; I'm not sure if this is worth doing.

Yet another option is to pick an approach based on the rustdoc version in rustdoc-vars (i.e. document.querySelector("#rustdoc-vars").getAttribute("data-rustdoc-version")). This could help a little but it's worth noting that it itself is a relatively recent addition to the rustdoc HTML output, I think.

If either of the above or some other approach are preferable, please let me know; I'm happy to update this PR.

I'm using Firefox 108.0.1 and the most recent version of the add-on, which is 1.9.1. The experience in Firefox with the add-on has always inferior to the experience in Chrome for me (search results sometimes not showing up properly, pressing Enter on a search result sometimes just leads you to a different page?, etc.), but generally it's been working fine. Since today it's not showing me any search results anymore though. When I type in the rs prefix, it's still showing me the rust search extension suggestion, but it doesn't seem to actually find the proper link:

Even actions that don't require any actual querying don't work:

(When I press enter on the highlighted suggestion, nothing happens)

I haven't changed any configuration/settings, and I don't think my Firefox had any updates. The search extension is also still working just fine in Chrome.

(Sidenote, but is it possible to set up the search extension as a Firefox search engine somehow, so that you can just press Tab after typing the rs prefix and then only get rust search results? It's doing that by default in Chrome for me, but not in Firefox)

https://rust.extension.sh contains useful information on how to use this extension so it would be nice to be able to navigate there easily without remembering the url.

Perhaps a link on the main page of the extension?

Hello, thanks in advance for this extension!

However, I find that this extension does not work in the similar way like other search extensions on Firefox.

For example, this is the one for GitHub.

And we can customize the keywords for it in the browser preference.

However, for this rust-search extension.

1. We cannot customize the keywords.
2. type rs and tab in the address tab bar does not work. rs and space still works.

It might be due to different manifest keywords between Firefox and Chromium browsers? (I have not created a chrome extension before).

The following is some search extension for Amazon I wrote for Firefox before. Not sure this extension works in similar ways.

{
    "manifest_version": 2,
    "name": "Amazon Smile Search",
    "description": "Add Amazon Smile to your search engine. ",
    "version": "1.0",
    "chrome_settings_overrides": {
        "search_provider": {
            "name": "Amazon Smile",
            "search_url": "https://smile.amazon.com/s?k={searchTerms}",
            "keyword": "@amazon",
            "favicon_url": "https://smile.amazon.com/favicon.ico",
            "is_default": false,
            "encoding": "UTF-8"
        }
    }
}

Firefox version: Firefox Developer Edition (107.0b8)

When I'm on a type's doc page and it has a lot of methods, it's tedious to scroll the sidebar to Trait implementations or other sections (could also ctrl+F, but that's also not that convenient).

It would be useful to add the links to these sections to the Table of Content widget.

Expected Behaviour

1. I type in rs Eq.
2. I hit enter.
3. I am taken to the docs for std::cmp::Eq.

Actual Behaviour (on Firefox for me at least)

1. I type in rs Eq.
2. I hit enter.
3. I am taken to the docs for std::ptr::eq.

This seems undesirable.