Summary of Bug

Pedersen Hash Improper Configuration

Version

This tutorial's configuration of pedersen hash window (https://github.com/arkworks-rs/r1cs-tutorial/blob/main/merkle_tree_example/src/common.rs#L18):

pub type TwoToOneHash = PedersenCRHCompressor<EdwardsProjective, TECompressor, TwoToOneWindow>;
#[derive(Clone, PartialEq, Eq, Hash)]
pub struct TwoToOneWindow;

// `WINDOW_SIZE * NUM_WINDOWS` = 2 * 256 bits = enough for hashing two outputs.
impl pedersen::Window for TwoToOneWindow {
    const WINDOW_SIZE: usize = 128;
    const NUM_WINDOWS: usize = 4;
}

pub type LeafHash = PedersenCRHCompressor<EdwardsProjective, TECompressor, LeafWindow>;

#[derive(Clone, PartialEq, Eq, Hash)]
pub struct LeafWindow;

// `WINDOW_SIZE * NUM_WINDOWS` = 2 * 256 bits = enough for hashing two outputs.
impl pedersen::Window for LeafWindow {
    const WINDOW_SIZE: usize = 144;
    const NUM_WINDOWS: usize = 4;
}

Which configure the window_size to N, and the num_windows to 4. This is not consistent with the arkworks test: (https://github.com/arkworks-rs/crypto-primitives/blob/main/src/merkle_tree/mod.rs#L463).

From my understanding, this will introduce a potential security vulnerability.

Happy to create a PR if this is confirmed by arkworks devs.

Steps to Reproduce

Description

When working on the exercises I encountered two annoying things:

• cargo was continually complaining about some small problems (even after completing exercise)
• 2nd exercise ('Verifying a single transaction') couldn't have been tested separately from the 3rd one

This PR:

• calms down cargo clippy as much as possible (i.e. after completing the exercises, there should be no warnings)
• introduces UnaryRollup which is a simplified version of Rollup - this one serves for testing 2nd exercise
• adds a unit test for the 2nd exercise using UnaryRollup
• fixes rendering of some READMEs

Checklist:

• [x] Targeted PR against correct branch (main)
• [x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
• [ ] Wrote unit tests (n/a - typos and unit test itself)
• [x] Updated relevant documentation in the code
• [ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md (n/a - seems to be unmaintained)
• [x] Re-reviewed Files changed in the Github PR explorer

The whole project cannot be compiled, due to ark-crypto-primitives is always going to pull the latest commit from github. But it compiled while I used specified commit

Platform: rust: 1.52.1 os: ubuntu 20.04

Perhaps that Cargo.lock file can avoid this situation.

In Merkle tree example, the error shows the 'leaf_bytes' didn't implement 'ToBytesGadget'. But the 'leaf_bytes' is the default value. So how can I deal with it?

Description

Test of transaction with the wrong signing key in single_tx_validity_test fails without a new temp_state. Seems pretty self-explanatory.

closes: NA

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

• [x] Targeted PR against correct branch (main)
• [x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
• [x] ~~Wrote unit tests~~
• [x] ~~Updated relevant documentation in the code)~~
• [x] ~~Added a relevant changelog entry to the Pending section in CHANGELOG.md~~
• [x] Re-reviewed Files changed in the Github PR explorer

Description

corrects internal links and moves README to link correctly. Fixes some 404s on github (and local nav)

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

• [x] Targeted PR against correct branch (main)
• [x] ~~Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.~~
• [x] ~~Wrote unit tests~~
• [x] Updated relevant documentation in the code
• [x] ~~Added a relevant changelog entry to the Pending section in CHANGELOG.md~~
• [x] Re-reviewed Files changed in the Github PR explorer

Description

@Dengjianping pointed out that the current Cargo.toml has used dependencies that are in conflict with each other. This PR cleans out these issues.

closes: #4

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

• [x] Targeted PR against correct branch (master)
• [x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
• [x] Re-reviewed Files changed in the Github PR explorer

N/A:

• [ ] Wrote unit tests
• [ ] Updated relevant documentation in the code

Discuss later:

• [ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md

(Our current CHANGELOG is empty. We need to create one. )

Description

This PR changes the window size of Pedersen to be more standard, as Shumo (@shechu) pointed out.

This PR also does cargo fmt. ~Note that some tests in rollup seem not successful, which may need some attention.~ Just realize that they are intentional.

closes: #2

Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.

• [x] Targeted PR against correct branch (master)
• [x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
• [x] Updated relevant documentation in the code
• [x] Re-reviewed Files changed in the Github PR explorer

We may also need to clean up the CHANGELOG sometimes.