I think it'd be nice to be able to run RustScan on multiple IPs, either through:

• stdin (comma-separated IPs?)
• a file (as in nmap's iL flag).

Thanks for the nice tool! 🙏

Hi.

I added a number of tries to scan_socket, by default the number of try is 1 but it can be set with command line option --tries. This should close #38.

I am not a Rust expert, so please let me know if I wrote something wrong or not elegant. Moreover, I am not sure of my code for the Config part, so this part needs to be reviewed.

Best regards.

Hey! This should close #213.

The solution was pretty straightforward. I was wondering whether it would be nicer to have a flag that outputs the results as JSON to the console so they could be piped into another process or get redirected to a file. I also left a TODO at the merge_required part, because I was not sure whether I had to add something there.

Let me know what you think!

Closes #89

Hi!

I had a look at the link you shared the other day (which rendered poorly on my end too) and found the original source for the snippet.

It seems possible to get it running without too much hassle. My pull request adds the after_success phase to .travis.yml and I believe the proper URL for the GitHub pages documentation to the README.md.

You will need to generate a token with a public_repo scope.

Then store and encrypt the token in an environment variable called GITHUB_TOKEN with the command below.

travis encrypt GITHUB_TOKEN=<THE_TOKEN> --add env.global

This should have added the proper variable to .travis.yml and after committing to this pull request the environment variable should now get populated and the cargo doc will get triggered on master.

Let me know if there are any issues!

Hey there, it's me again :D

I just saw that the clippy lints are run, but the annotations cannot be added to forked repos, so PR diffs cannot be annotated. To enforce the lints, I propose the following changes:

1. Project-wide deny(clippy::all): This will have clippy error if any of the default warnings is emitted
2. Project-wide warn(clippy::pedantic) with whitelisting: This will nit-pick things, which is why these are just warnings. Still, I would rather allow specific lints (like I did already) where needed if it is reasonable.
3. Finally, make the clippy workflow a required pass, so that no new code that doesn't pass the default lints can be merged (I haven't figured out how to do this yet, is this some maintainer setting?)

I think 1) and 3) are needed, 2) is maybe a bit radical. Still, I think it would be a nice addition. Because the annotations are still there for code that is already on this repository, these lints can be fixed when someone is already working on the affected code. Let me know what you think!

Describe the bug Rustcan is missing open ports (80 sometimes and 443 all the times for hackerone.com for instance) Nmap doesn't

To Reproduce

Using hackerone.com for the test

host hackerone.com
hackerone.com has address 104.16.100.52
hackerone.com has address 104.16.99.52
....

nmap -p80,443 104.16.99.52 -sV                                             
Starting Nmap 7.80 ( https://nmap.org ) at 2020-08-05 21:45 CEST          
Nmap scan report for 104.16.99.52                                            
Host is up (0.025s latency).                                                 
                                                                             
PORT    STATE SERVICE   VERSION                                              
80/tcp  open  http      cloudflare                                           
443/tcp open  ssl/https cloudflare                                           
2 services unrecognized despite returning data. If you know the service/version, please submit the following fingerprints at https://nmap.org/cgi-bin/subm
it.cgi?new-service :                                                                                                                                      
==============NEXT SERVICE FINGERPRINT (SUBMIT INDIVIDUALLY)==============
SF-Port80-TCP:V=7.80%I=7%D=8/5%Time=5F2B0C5D%P=x86
...

rustscan -b 500 -t 10000 104.16.99.52

     _____           _    _____
    |  __ \         | |  / ____|
    | |__) |   _ ___| |_| (___   ___ __ _ _ __
    |  _  / | | / __| __|\___ \ / __/ _` | '_ \
    | | \ \ |_| \__ \ |_ ____) | (_| (_| | | | |
    |_|  \_\__,_|___/\__|_____/ \___\__,_|_| |_|
    Faster nmap scanning with rust.

The config file is expected to be at "/home/bob/.config/rustscan/config.toml"

Your file descriptor limit is higher than the batch size. You can potentially increase the speed by increasing the batch size, but this may cause harm to sensitive servers. Your limit is 1024, try batch size 1023.

The batch size is 500

Scanning ports from 104.16.99.52

Open 80
Open 2052
Open 2053
...

Expected behavior Report of port 80 and 443 open

Context rustscan v1.6.0

Here's a simple multi-stage docker file with the bare minimum.

It probably needs a bit of tweaking and testing, though it seems to find things locally :)

Something that adapts to the user's host is an awesome idea! :)

It can also learn or allow a config file for default commands in the future, things like:

• Amount of parallel nmap processes (assuming we go through this route)
• Only TCP or UDP
• Saving these scans to a default location and so on.

Originally posted by @bernardoamc in https://github.com/brandonskerritt/RustScan/issues/69#issuecomment-663894135

I think the best way would be to use the ulimit syscall to read the value and then set it automatically depending on what is available 👍

And then, notify the user about this "The current FD limit is too small, increase is blah blah".

Originally posted by @SakiiR in https://github.com/brandonskerritt/RustScan/issues/21#issuecomment-662915856

Problem

RustScan is designed to be fast, and to do this we need to benchmark our program.

Solution

https://github.com/bheisler/criterion.rs

Criterion is a Rust library for benchmarking code using a test.

Things you need to know

• The address you should scan is rustscan.cmnatic.co.uk.
• The batch size and ulimit should be fixed (pick anything you want).
• It should scan all ports.

To use RustScan, observe one of the tests in the scanner directory. This is from mod.rs

    fn scanner_runs() {
        // Makes sure the program still runs and doesn't panic
        let addrs = vec!["127.0.0.1".parse::<IpAddr>().unwrap()];
        let range = PortRange {
            start: 1,
            end: 1_000,
        };
        let strategy = PortStrategy::pick(Some(range), None, ScanOrder::Serial);
        let scanner = Scanner::new(&addrs, 10, Duration::from_millis(100), true, strategy, true);
        block_on(scanner.run());
        // if the scan fails, it wouldn't be able to assert_eq! as it panicked!
        assert_eq!(1, 1);
    }

If you have any questions, please get in touch! :)

The current PKGBUILD file is:

# Maintainer: Bee <[email protected]>
pkgname=rustscan-bin
pkgver=1.2.0
pkgrel=1
pkgdesc="Faster Nmap Scanning with Rust"
url="https://github.com/brandonskerritt/rustscan"
license=("MIT")
arch=("x86_64")
provides=("rustscan")
depends=('rustup')

package() {
	rustup toolchain install stable && cargo install rustscan
}

This is not located in this repository. Instead, I cloned the AUR version to get the file.

I know very little about publishing to the AUR.

This isn't a nice solution, at least I don't believe it to be, because it simply installs Rust and then uses Rust's Cargo to install RustScan.

With the Homebrew version, it downloads the tar file and builds the binary. https://github.com/brandonskerritt/homebrew-rustscan/blob/master/Formula/rustscan.rb

Can someone with more Arch experience than I please make the PKGBUILD better, or help suggest how to make the install easier?

For reference, here is a list of related issues: https://github.com/brandonskerritt/RustScan/issues/49 https://github.com/brandonskerritt/RustScan/issues/17

Bumps cidr-utils from 0.5.6 to 0.5.10.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Scanning with --no-nmap --ulimit 65535

rustscan/rustscan:1.10.0 ***.***.*. --no-nmap --ulimit 65535

show result

Open *...:22 Open ***...**:38172

Scanning with -- -A --ulimit 65535

rustscan/rustscan:1.10.0 ***.***.*. -- -A --ulimit 65535

show result

Open *...:9100 Open ***...**:38172

[~] Starting Nmap [>] The Nmap command to be run is nmap -A --ulimit 65535 -vvv -p 9100,38172 ***.***.*.

PORT STATE SERVICE REASON VERSION 9100/tcp open jetdirect? syn-ack 38172/tcp open unknown syn-ack

is there a way to make the RustScan show the service of the without using -A in nmap? make it show like this result on one line

Open *...:9100- jetdirect? syn-ack Open ***...**:38172- unknown syn-ack

Bumps gcd from 2.1.0 to 2.2.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps log from 0.4.16 to 0.4.17.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps dirs from 3.0.2 to 4.0.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.