Upgrading from 7.1.2 to 7.2.0 caused a memory leak in my application. We use snappy heavily to compress/decompress (synchronously) massive amount of data.

I can enable/disable leak by changing snappy version and nothing else. Will slowly eat memory until app crashes in 7.2.0, while will continue forever in 7.1.2

Hi!

Are you interested in taking over the snappy-package on npm?

snappy is the first serious npm module I ever published, so I gotta be honest that it'll be a bit difficult to let it go, but since this project is snappier than mine, I think it would make sense.

My suggestion would be that I add you as a maintainer to the snappy package and that you publish a new version of it (as version 7.0.0 so that no existing installations of snappy are affected). I would than also deprecate my repo on github, sending them your way instead.

Let me know what you think about my suggestion, I think it would be a cool thing to do.

Hi! The package @napi-rs/snappy-darwin-x64 is not derived after the installation of the latest snappy. What may be the reason? Can not load bindings also appears until the latter is installed.

$ npm -v
7.11.2

Test code (executed as: npx electron index.js):

const {compress} = require("snappy");
const {randomBytes} = require("crypto");
const {writeFile} = require("fs/promises");

(async () => {
    await writeFile(
        `./snappy-archive-${Date.now()}.bin`,
        await compress(
            randomBytes(/*1 KB:*/1024 * 100),
        ),
    );
    process.exit(0);
})();

SIGSEGV error:

[28878:1001/195712.022506:ERROR:node_bindings.cc(146)] Fatal error in V8: v8_ArrayBuffer_NewBackingStore When the V8 Sandbox is enabled, ArrayBuffer backing stores must be allocated inside the sandbox address space. Please use an appropriate ArrayBuffer::Allocator to allocate these buffers.
[28915:0100/000000.927082:ERROR:broker_posix.cc(43)] Invalid node channel message

Possibly related issue: https://github.com/nodejs/abi-stable-node/issues/441.

I get the following crash on NixOS:

Error: ENOENT: no such file or directory, open '/usr/bin/ldd'

On NixOS, ldd is in an exotic location:

> which ldd
/run/current-system/sw/bin/ldd

Hello, I see in the release 7.1.1 snappy has an increase in performance of 2-3 times. But I did some local tests and I don't note the difference in performance between version 7.0.5 and7.1.1. I note that you have changed the computer for the benchmarks, is it possible you have compared results of different hardware?

Hello,

I'm having an error with version 7.1.0 of snappy.

Steps to reproduce:

mkdir test && cd test
npm init -y
npm i [email protected]
node -e "require('snappy')"

Error:

Error: Cannot find module 'snappy-linux-x64-gnu'
Require stack:
- /tmp/node_modules/snappy/index.js
- /tmp/[eval]
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:93:18)
    at Object.<anonymous> (/tmp/node_modules/snappy/index.js:135:31)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Module.require (internal/modules/cjs/loader.js:974:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '/tmp/node_modules/snappy/index.js', '/tmp/[eval]' ]
}

Environment:

• node 14.18.2
• npm 6.14.15
• Linux 5.15.10-arch1-1 x86_64 GNU/Linux

Is this a bug or I'm missing something? Thanks

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | legacy-snappy | 6 -> 7 | | | | |

Release Notes

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

I deployed this in production yesterday for usage with MongoDB driver. I was using version 6.x before. When I deployed, memory usage continually kept going up. I am almost certain that this package caused it.

Let me know what information I can give to track it down.

This PR contains the following updates:

| Package | Type | Update | Change | |---|---|---|---| | @napi-rs/snappy-darwin-arm64 | optionalDependencies | rollback | ^7.0.0 -> ^1.0.2 |

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

This PR contains the following updates:

| Package | Type | Update | Change | |---|---|---|---| | @napi-rs/snappy-android-arm64 | optionalDependencies | rollback | ^7.0.0 -> ^1.0.2 |

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

• [ ] If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.