Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUSL build for Linux x64 #128

Closed
valeriansaliou opened this issue Apr 15, 2019 · 8 comments
Closed

MUSL build for Linux x64 #128

valeriansaliou opened this issue Apr 15, 2019 · 8 comments
Assignees
Labels
tooling Issue related to the project tooling
Milestone

Comments

@valeriansaliou
Copy link
Owner

We should now be able to perform a MUSL build for Linux x64.

Check this is now possible, and update PACKAGING.md accordingly.

@valeriansaliou valeriansaliou added the tooling Issue related to the project tooling label Apr 15, 2019
@valeriansaliou valeriansaliou added this to the v1.2.0 milestone Apr 15, 2019
@valeriansaliou valeriansaliou self-assigned this Apr 15, 2019
@valeriansaliou
Copy link
Owner Author

Looks like jemalloc cannot be compiled on MUSL.

@valeriansaliou
Copy link
Owner Author

Okay, that's a definitive no-go. RocksDB does not compile on MUSL, but there is a pending PR to allow that: facebook/rocksdb#3143

@Mstrodl
Copy link

Mstrodl commented Jan 11, 2020

@valeriansaliou The PR you were referring to merged a few months ago. Does that mean this is possible now?

@valeriansaliou
Copy link
Owner Author

valeriansaliou commented Jan 12, 2020

@Mstrodl oh, that would be cool yes. Do you have the reference to this PR in RocksDB? (edit: dumb me, the link is above) I think I'll need to update the Rust rocksdb adapter from rocksdb C++ upstream then.

@Kerollmops
Copy link

Kerollmops commented Jan 12, 2020

Notice that if you bump the RocksDB dependency you will probably create a breaking change as the RocksDB disk format could have changed and become incompatible.

@valeriansaliou
Copy link
Owner Author

Hey @Kerollmops ! Thanks for the heads up, I have a local RocksDB database running on the "old" version, which I'll heavily test upon bumping it. I'll follow up there.

@valeriansaliou
Copy link
Owner Author

valeriansaliou commented Jun 25, 2020

Attempted in 961bab9 ; still need to validate this.

@valeriansaliou
Copy link
Owner Author

MUSL is currently not possible still; a glibc cross-compile build script has been added instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issue related to the project tooling
Projects
None yet
Development

No branches or pull requests

3 participants