Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raymarch render.frag on MacOS #1

Merged
merged 1 commit into from Sep 6, 2021
Merged

Conversation

bschwind
Copy link
Member

@bschwind bschwind commented Sep 6, 2021

@slightknack please review

I tried running every demo on an intel macbook (MacOS 11.5.2). Only the raymarch demo didn't work but it only required a few changes to work.

  • A #version 140 was needed at the top of render.frag
  • out vec4 out_color; is used instead of gl_FragColor
  • A local variable box was defined, which clobbered the box function and gave compiler errors when trying to call box() further down the line.

@slightknack
Copy link
Contributor

Looks good to me, I'll merge it!

@slightknack slightknack merged commit 5ab8c52 into master Sep 6, 2021
@slightknack slightknack deleted the raymarch-fixups branch September 6, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants