This repository has been archived by the owner on May 20, 2022. It is now read-only.
Moves private helper types into deserialize impl #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That’s neat - didn’t know you could do that. Now that I look at those structs, though, there’s an obvious parallelism that could be abstracted into a generic in the same way that GPOSGSUB is. |
|
feel free to close this if you go that route. |
|
(or would you like me to make that change?) |
|
I’m probably overthinking it for not much actual gain. Let’s do it this way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to close if this doesn't make sense, but I find it helpful when doing this to just declare the types in the method where they're used.