consider moving off of nightly #37
Comments
I’m not sure we need nightly for any of the code in here (we shouldn’t), but I have a feeling we link to crates which need it. I’m happy to get that fixed if possible. |
(cargo test on stable is passing.) |
yea, playing around more I think this may be a non-issue. I did need to use nightly to run fontcrunch, though? I'm a bit surprised if we have any deps that are nightly-only, there just aren't that many of those out there anymore, as more and more stuff has come to stable over the years. |
So I just tried this in a VM. fonttools doesn't compile on rustc 1.4.7 because fixed 1.9.0 uses Which makes it a bit of a mystery why the CI build is passing... |
I believe that's stable as of |
And Ubuntu groovy ships 1.47. So they’ll need to futz with rustup anyway. Man, I hate this stuff. |
I guess it depends who our users are? I don't think it's unreasonable to expect folks to be on the latest |
I've just run |
Confirm. Moot-ish point now, but in case it comes up again I don't know of any reason not to expect the very latest stable compiler to be available. I'm sure someday that will change, but to date the way the Rust ecosystem moves including distro packaging, the very latest stable tag compiler is an expected thing to have available. Not requiring nightly is a good thing especially for distro packagers, but holding anything back to maintain old compiler compatiblity is not necessary. |
There aren't a lot of great reasons to require nightly rust anymore, and it will be a major barrier to the adoption of this crate elsewhere in the ecosystem. Unless there's a really compelling reason to require nightly, I think it probably makes sense to try and move off of it sooner rather than later, as it will become harder the more nightly features end up being used.
Any thoughts on this? Last I checked nightly was only being used to improve diagnostics in some derive macros, and there are reasonable workarounds there. Are there any other major motivations?
It's worth keeping in mind that we can still conditionally use nightly features, enabling them only when we're on a nightly compiler.
The text was updated successfully, but these errors were encountered: