This repository has been archived by the owner on May 20, 2022. It is now read-only.
fontcrunch: Replace Rc<Option> with Option<Rc> #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us avoid an allocation in the None case. Profiling allocations on a sample font, this cuts the total number of allocations by ~60%.
|
I don't have a good sense of how much this helps with runtime performance; I've timed it a bunch and the data is pretty noisy, but it doesn't seem huge? It shouldn't really hurt, though. |
|
Nice, thank you! |
|
I'm also going to dig into actually getting rid of the linked list, will let you know how that goes. |
|
I ran flamegraph and the real hotspot is the numerical integration stuff - arclength and error measuring. So much so that adding “#[inline]” to the functors gained a 10% improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us avoid an allocation in the None case.
Profiling allocations on a sample font, this cuts the
total number of allocations by ~60%.