Skip to content
This repository has been archived by the owner on May 20, 2022. It is now read-only.

Calculate unicode ranges #34

Closed
wants to merge 2 commits into from
Closed

Conversation

m4rc1e
Copy link
Contributor

@m4rc1e m4rc1e commented Jun 8, 2021

Super wip. My implementation is loosely based on https://github.com/fonttools/fonttools/blob/main/Lib/fontTools/ttLib/tables/O_S_2f_2.py. The fonttools version uses python's built in bisect module in order to achieve a good run time. I don't think Rust has this so I've opted roll my own custom binary search instead.

Note this is still super wip. Before I plumb it together, I'll ask for a review. It should be ready for a first look tomorrow.

@simoncozens
Copy link
Owner

simoncozens commented Jun 8, 2021

There's a built-in binary_search_by method on a Vec that may be useful...

@m4rc1e
Copy link
Contributor Author

m4rc1e commented Jun 25, 2021

Apologies for the snail's pace on this pr. I've been busy with some ci/gftools stuff.

I almost have the draft implementation in place. I've created a new data structured, BitInt which I also plan to use when I refactor the fsSelection and codePage bits as well. I'll ping once I've made this more idiomatic.

@simoncozens
Copy link
Owner

I implemented this (using a lot of code from this PR) in 9466ce1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants