Skip to content
This repository has been archived by the owner on May 20, 2022. It is now read-only.

Add ttf-add-smooth-gasp #11

Merged
merged 2 commits into from May 13, 2021
Merged

Add ttf-add-smooth-gasp #11

merged 2 commits into from May 13, 2021

Conversation

m4rc1e
Copy link
Contributor

@m4rc1e m4rc1e commented May 4, 2021

At GF, we like to release unhinted fonts which have their gasp tables set to smooth for all sizes.

Keep this open since our FB check seems a bit strange. The check wants a single range with all the flags enabled which imo feel wrong, or there's some magic going on which is undocumented. I'm just confirming why we made this decision with Felipe.

I'd maybe keep this open for a week or so. I only started playing with Rust yesterday so most likely this is shockingly bad.

@m4rc1e
Copy link
Contributor Author

m4rc1e commented May 6, 2021

@simoncozens functionality wise, this is now matches gftools fix_unhinted_font.

If this pr is merged, fonttools-rs should be able to build a basic unhinted font which will pass the googlefonts fontbakery profile since dummy DSIG generation also exists.

Regarding this script, I wonder if it would make sense to also remove any hinting instructions which may be lurking in the glyf table and also drop the VTT tables?

@m4rc1e m4rc1e marked this pull request as ready for review May 13, 2021 14:25
@m4rc1e
Copy link
Contributor Author

m4rc1e commented May 13, 2021

This is also ready. Np if you don't fancy merging this.

@simoncozens simoncozens merged commit 32a3010 into simoncozens:main May 13, 2021
@simoncozens
Copy link
Owner

Thank you! We'll do drop-hinting as a different script.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants