Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for fully qualified names? #2074

Closed
JeremyRubin opened this issue Aug 16, 2021 · 2 comments
Closed

support for fully qualified names? #2074

JeremyRubin opened this issue Aug 16, 2021 · 2 comments

Comments

@JeremyRubin
Copy link

One thing that has come up in some of my work is that the rename options do not have a way to automatically include e.g. the full module path. Example:

struct A;
mod B {
struct A;
}

In this example the struct name for both B::A and A would be the same, unless it's somehow overriden. This becomes more of an issue when working with structs from e.g. different crates.

This is related to previously discussed issues:

but much more specific since it's just a case of needing crate/module unique identifiers.

@dtolnay
Copy link
Member

dtolnay commented Jan 23, 2022

I'd prefer not to build something dedicated to this into this crate, but either of the issues you linked is still a possibility so I'll close in favor of those.

@dtolnay dtolnay closed this as completed Jan 23, 2022
@JeremyRubin
Copy link
Author

I think where this is unique is in applying the rename to the base struct name, rather than a field-level rename (which doesn't work nicely for things like Vec).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants