In Configurations.md demonstrate both cases for noop selections #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
changed the title
|
ready for review now! |
calebcartwright
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from discussion in #4948
This PR improves both the idempotentency test and the users comprehension of the documentation.
condense_wildcard_suffixes is an example where this approach is already used.
I'm not sure if the new code added to the noop cases should also be added to the non-noop cases as well. condense_wildcard_suffixes doesnt do that, so I did the same. Let me know if I should change that though.
I havent touched configuration that sorts elements into alphabetical order, as the unsorted elements in the noop case should demonstrate that its not touched by rustfmt just fine.
brace_style: SameLineWheredoesn't seem to fit its own description , so I just skipped that one...