Add One option to group_imports #4966
Conversation
|
Thank you for the PR! Won't have a chance to give this a thorough review for a while, but I do think the variant you've suggested is reasonable and definitely something we'll consider |
There was a problem hiding this comment.
I was initially surprised by how simple this and felt like something had to be missing 😄
The implementation LGTM, but I do want to rename the variant for consistency. I started applying inline suggestions to reflect the name change but decided against trying to do it for each one since the change is pretty clear.
Same here! I was prepared to put a lot more time in, but it started working as soon as I had added the option and it was only after looking at the code some more that I understood why. 😅 I changed the name of the option to One as requested. edit: Oops, I neglected to rename the test files. Everything should be good now. |
Heliozoa
changed the title
I gave a go at implementing my feature request at #4962, an option to group imports into one group. I mostly just copied the StdExternalCrate implementation.