Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reexport alloc::task::Wake #2494

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

reexport alloc::task::Wake #2494

wants to merge 5 commits into from

Conversation

ibraheemdev
Copy link
Member

Per #2207.

@ibraheemdev
Copy link
Member Author

Should it be re-exported as ArcWake to avoid breakage?

@taiki-e
Copy link
Member

taiki-e commented Jan 4, 2022

Should it be re-exported as ArcWake to avoid breakage?

Since the default methods for Wake and ArcWake are different, this is breaking change anyway, and the re-export as ArcWake is not needed.

@taiki-e taiki-e added this to the futures-0.4, futures-core-1.0 milestone Jan 4, 2022
@taiki-e taiki-e added the A-task Area: futures::task label Jan 4, 2022
@ebkalderon ebkalderon mentioned this pull request Feb 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e Awaiting requested review from taiki-e

Assignees
No one assigned
Labels
A-task Area: futures::task
Projects
None yet
Milestone
futures-0.4, futures-core-1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibraheemdev @taiki-e