Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile under Rust 1.0.0 Alpha #133

Closed
zrneely opened this issue Jan 12, 2015 · 30 comments
Closed

Does not compile under Rust 1.0.0 Alpha #133

zrneely opened this issue Jan 12, 2015 · 30 comments

Comments

@zrneely
Copy link

zrneely commented Jan 12, 2015

The library doesn't compile in 1.0.0 alpha. The errors are too long to post here, but I can create a pastebin if necessary.

@SimonTeixidor
Copy link
Member

There's a lot of breakage in our dependencies, so it's not only nickel that needs to be fixed. I'll take a look at this after my exams are done, unless someone else fixes it earlier.

@rgs1
Copy link
Contributor

rgs1 commented Jan 18, 2015

FWIW, I got rust-mustache working: nickel-org/rust-mustache#3. I'll check the other deps tomorrow.

@rgs1
Copy link
Contributor

rgs1 commented Jan 19, 2015

FWIW, I almost got groupable working: nickel-org/groupable-rs#1

@rgs1
Copy link
Contributor

rgs1 commented Jan 20, 2015

Got groupable-rs building now: nickel-org/groupable-rs#1

I'll check other deps to see if they are good. Cc: @SimonPersson

@rgs1
Copy link
Contributor

rgs1 commented Jan 20, 2015

This is needed to build: https://github.com/nickel-org/nickel.rs/pull/134/commits (though it's still not building for me)

@rgs1
Copy link
Contributor

rgs1 commented Jan 20, 2015

So with PR #134 it dies because of badly generated code in build/http-315cbfc4b189544c/out/read_method.rs: https://gist.github.com/rgs1/131bc407fe53ea321854.

I'll dig into what generates that file.

@SimonTeixidor
Copy link
Member

I don't know why you get an error there. rust-http builds fine for me. Have you run cargo update? I can't seem to make the regex! macro work though, not even the example in their documentation.

@rgs1
Copy link
Contributor

rgs1 commented Jan 20, 2015

yeah regex! is gone, I have more changes coming (one of them is using Regex::new(r).unwrap()). I got past that error after cargo clean. Will post an update commit later today unless you get to having it build first :-)

@rgs1
Copy link
Contributor

rgs1 commented Jan 21, 2015

More progress here: #135

@SimonTeixidor
Copy link
Member

Haha, it was building for a few hours at least! Broken again with the current nightly...

@rgs1
Copy link
Contributor

rgs1 commented Jan 30, 2015

Heh, yeah just saw that. Anymap is the first dep that I see broken, will get to it in a bit!

@SimonTeixidor
Copy link
Member

I fixed it up last night, then it was broken again this morning. It seams as if we should expect daily breakage for the moment :)

@rgs1
Copy link
Contributor

rgs1 commented Jan 30, 2015

Ah so Chris Morgan on #rust pointed me to: rust-lang/rust#21745 which apparently is what broke anymap

@SimonTeixidor
Copy link
Member

And now it builds again.

@cburgdorf
Copy link
Member

👍 Wohooooo! Thanks for all your awesome work on the project everyone!

@SimonTeixidor
Copy link
Member

rust-http broke with the latest nightly. Are you working on changing to hyper, @Ryman? I'm wondering if it is worth fixing rust-http or if your work on hyper is close to usable already?

@Ryman
Copy link
Member

Ryman commented Feb 4, 2015

@SimonPersson I don't think it'll be anytime in the next week at least, haven't had a chance to rebase properly yet

@ninjabear
Copy link
Contributor

You're really close on the latest nightly (rustc 1.0.0-nightly (dfc5c0f1e 2015-02-18) (built 2015-02-19))

I'm using msys2/win, getting this error,

$ cargo build --release
   Compiling http v0.1.0-pre (https://github.com/nickel-org/rust-http.git#4fde95fd)
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\common.rs:182:5: 188:7 error: `concat_idents` is not stable enough for use and is subject to change
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\common.rs:182     test_reads!(http_version,
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\common.rs:183                 "HTTP/25.17\0" => Some((25, 17)),
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\common.rs:184                 "http/1.0\0" => Some((1, 0)),
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\common.rs:185                 "http 1.0\0" => None,
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\common.rs:186                 "HTTP/1.0.\0" => None,
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\common.rs:187                 "HTTP/1.0.\0" => None

loads more in the same vein, then

                                                                                          ...
error: aborting due to 32 previous errors
Could not compile `http`.

applies to cargo build & cargo build --release the same

@ninjabear
Copy link
Contributor

it's a fork of rust-http, are there plans to remove this in favour of hyper or whatever? They look like just tests, can we comment them out for the time being?

@SimonTeixidor
Copy link
Member

Take a look at the pull requests, we have a solution on the way! :)

Yes, rust-http is going to be replaced soon, there is ongoing work to replace it with Hyper.

@ninjabear
Copy link
Contributor

ah yeah sorry as I finished posting that I noticed there were some open pull reqs, sorry!

@Ryman
Copy link
Member

Ryman commented Feb 19, 2015

@ninjabear Should be working now?

@ninjabear
Copy link
Contributor

Will have to check later - openssl libs for rust/cygwin not talking to each other now

@ninjabear
Copy link
Contributor

but yeah - the original problem has gone now :) don't think this is specific to nickel

@ninjabear
Copy link
Contributor

New error now, after cargo clean / update + pull;

rustc 1.0.0-nightly (dfc5c0f1e 2015-02-18) (built 2015-02-19)

cargo build --verbose

*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:2:15: 2:16 help: did you mean to close this delimiter?
*\http-315cbfc4b189544c\out\read_method.rs:2 pub mod dummy {
                                                                                                            ^
*\http-315cbfc4b189544c\out\read_method.rs:11:83: 11:84 help: did you mean to close this delimiter?
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:11 pub fn read_method<S: Stream>(stream: &mut BufferedStream<S>) -> IoResult<Method> {
                                                                                                                                                                                 ^
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:12:51: 12:52 help: did you mean to close this delimiter?
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:12     let (s, next_byte) = match stream.read_byte() {
                                                                                                                                                 ^
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:175:46: 175:47 help: did you mean to close this delimiter?
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:175         Ok(b'P') => match stream.read_byte() {
                                                                                                                                             ^
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:176:50: 176:51 help: did you mean to close this delimiter?
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:176             Ok(b'A') => match stream.read_byte() {
                                                                                                                                                 ^
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:194:19: 194:20 error: this file contains an un-closed delimiter
*\nickel\target\build\http-315cbfc4b189544c\out\read_method.rs:194                 },
                                                                                                                  ^
Build failed, waiting for other jobs to finish...
Could not compile `http`.

and cargo build --release gives something else

$ cargo build --release
   Compiling http v0.1.0-pre (https://github.com/nickel-org/rust-http.git#82084c61)
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\server\request.rs:128:21: 128:75 error: couldn't read "*\\nickel\\target\\release\\build\\http-315cbfc4b189544c\\out\\read_method.rs": couldn't open path as file (file not found (The system cannot find the file specified.
); path=*\nickel\target\release\build\http-315cbfc4b189544c\out\read_method.rs; mode=open; access=read)
*\.cargo\git\checkouts\rust-http-1c297591e92637fa\master\src\http\server\request.rs:128         mod dummy { include!(concat!(env!("OUT_DIR"), "/read_method.rs")); }

Not quite sure what I'm seeing aside from it really doesn't like that file in rust-http

@Ryman
Copy link
Member

Ryman commented Feb 20, 2015

Travis jumped a nightly, so looks like more failures on the latest nightly, I'll rustup and deal with it.

@Ryman
Copy link
Member

Ryman commented Feb 21, 2015

Dependencies are fixed up now and everythings passing on Travis.

@ninjabear you might want to try a full git pull && cargo clean && cargo update && cargo test.

@ninjabear
Copy link
Contributor

I tried with the latest, clean pull etc, still same.

I think its windows/cygwin related - something to do with the path for the include. I'll try to work it out and let you know.

@ninjabear
Copy link
Contributor

Something else is broken with rust-http now, looking at the promising work with hyper I doubt its worth fixing. Also this issue I guess is supposed to cover rust-1.0.0alpha, the nightlies are way ahead now, no point supporting rust-alpha imho!

if you replace "transwarp beaming" with "developing rust libs":

https://www.youtube.com/watch?v=jxzYTDX8bIg

:D

@Ryman
Copy link
Member

Ryman commented Apr 16, 2015

Closing as we're now 'stable' on beta :)

@Ryman Ryman closed this as completed Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants