Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish on crates.io #120

Closed
cburgdorf opened this issue Nov 21, 2014 · 18 comments
Closed

Publish on crates.io #120

cburgdorf opened this issue Nov 21, 2014 · 18 comments

Comments

@cburgdorf
Copy link
Member

In order to get nickel listed on cargo.io, we need to release a first version. Any hesitations to release a 0.1.0 from current master? @Ryman @simonpersson ?

@SimonTeixidor
Copy link
Member

No hesitation from me. Better release before someone steals our name :)

@Ryman
Copy link
Member

Ryman commented Nov 22, 2014

AFAIK, to publish you can't have mixed dependencies, we'd have to ensure all dependencies are in cargo.io already and not have any git references.

We should probably push something to reserve the name at least, not sure what to do about managing pre rust 1.0 releases though, it could be troublesome for a project with so many dependencies (not allowing git references)? I guess we'll just have to live with having broken builds published :/

@thehydroimpulse
Copy link

Pre rust 1.0 releases for a project should obviously keep it 0.x.x so the project shouldn't be 1.0 if rust isn't. The git thing is kinda annoying especially when a build is broken by a dependency and you have to wait for the author to push it up.

@hjr3
Copy link
Contributor

hjr3 commented Jan 4, 2015

This is blocking me from using postgres with nickel. The same openssl library is being sourced from crates.io and directly from a git repository. This is creating a build error.

Cargo.toml

[package]

name = "example"
version = "0.1.0"

[[bin]]

name = "example"
path = "src/main.rs"

[dependencies.nickel]

git = "https://github.com/nickel-org/nickel.rs.git"

[dependencies.postgres]

git = "https://github.com/sfackler/rust-postgres.git"

Output:

$ cargo update
    Updating git repository `https://github.com/nickel-org/nickel.rs.git`
    Updating git repository `https://github.com/sfackler/rust-postgres.git`
    Updating git repository `https://github.com/reem/rust-plugin`
    Updating git repository `https://github.com/nickel-org/rust-url.git`
    Updating git repository `https://github.com/rust-lang/time`
    Updating git repository `https://github.com/nickel-org/rust-http.git`
    Updating git repository `https://github.com/nickel-org/groupable-rs`
    Updating registry `https://github.com/rust-lang/crates.io-index`
    Updating git repository `https://github.com/nickel-org/rust-mustache.git`
    Updating git repository `https://github.com/nickel-org/anymap.git`
    Updating git repository `https://github.com/sfackler/rust-openssl.git`
$ cargo build
 Downloading phf_mac v0.4.4
 Downloading time v0.1.7
 Downloading regex v0.1.6
 Downloading typemap v0.0.6
 Downloading phf v0.4.4
 Downloading gcc v0.1.3
 Downloading phf_shared v0.4.4
 Downloading log v0.1.7
 Downloading openssl v0.2.11
 Downloading openssl-sys v0.2.11
 Downloading uuid v0.1.4
 Downloading pkg-config v0.1.3
 Downloading rustc-serialize v0.2.2
 Downloading unsafe-any v0.2.0
native library `openssl` is being linked to by more than one package, and can only be linked to by one package

  openssl-sys v0.2.11
  openssl-sys v0.2.11 (https://github.com/sfackler/rust-openssl.git#df9a7357)

@rgs1
Copy link
Contributor

rgs1 commented Feb 20, 2015

I guess the big blocker here would be moving out of rust-http (no longer maintained) and onto hyper?

@ninjabear
Copy link
Contributor

I think a lot of the tougher to solve problems with compiling have come out of rust-http, 2 cents

@Ryman
Copy link
Member

Ryman commented Feb 20, 2015

@rgs1 @ninjabear Yep, in progress, sorry for the delay on that front!

@cburgdorf
Copy link
Member Author

Now that we switched to hyper, we should revisit this issue. What's the state of groupable.rs and rust-mustache. There's a rust-mustache on crates.io that we could probably switch to. However, groupable.rs isn't on crates.io yet but since it's maintained by @Ryman it shouldn't be a big issue to publish it on crates.io, right?

@SimonTeixidor
Copy link
Member

Unfortunately, the mustache on crates.io is not updated. Our fork is many,
many commits ahead of the upstream repo as pull requests were not merged
when it stopped compiling in December.

I suppose we could publish our fork on crates.io, but that doesn't seem so
nice toward the original developer.
On 31 Mar 2015 11:51, "Christoph Burgdorf" notifications@github.com wrote:

Now that we switched to hyper, we should revisit this issue. What's the
state of groupable.rs and rust-mustache. There's a rust-mustache on
crates.io https://crates.io/crates/rust-mustache that we could probably
switch to. However, groupable.rs isn't on crates.io yet but since it's
maintained by @Ryman https://github.com/Ryman it shouldn't be a big
issue to publish it on crates.io, right?


Reply to this email directly or view it on GitHub
#120 (comment)
.

@cburgdorf
Copy link
Member Author

Ah, thanks for clarifying. I know @erickt once tried to consolidate the situation about rust-mustache but I can't find the gh issue anymore. @erickt do you mind leaving a comment here?

@erickt
Copy link

erickt commented Apr 1, 2015

Sadly I made no progress on it. I've been focusing on serialization and haven't yet gotten to mustache. Does anyone here want to be made a contributor and help maintain it?

@rgs1
Copy link
Contributor

rgs1 commented Apr 1, 2015

@erickt I have a few cycles to help!

@Ryman
Copy link
Member

Ryman commented Apr 1, 2015

@erickt If you're looking for multiple, I can also volunteer.

Also @cburgdorf, can we look at org permissions, it would be good to remove some of the old repos, potentially add more repos in the near future, and adding people such as @rgs1 as a member (assuming they wanted).

I'll look to to publishing groupable later tonight :)

@cburgdorf
Copy link
Member Author

@Ryman sure thing, I upgraded both of you to owners of the organization :)

@erickt
Copy link

erickt commented Apr 1, 2015

How about this. Since the nickle.org fork is the most well maintained, I've added the three of you to the owners list for the mustache crate. I'll retire my https://github.com/erickt/rust-mustache fork, and redirect folks here. How's that sound?

@cburgdorf
Copy link
Member Author

Ok, sounds good! This should set us in a position where we can soon publish and maintain nickel on crates.io, too. Very much looking forward to it.

@Ryman
Copy link
Member

Ryman commented Apr 2, 2015

@cburgdorf Cheers!

@erickt Sounds good, I don't personally mind either we point people to here or add a few more collaborators in the repo in your namespace. Either should work out :) Thanks either way!

@cburgdorf
Copy link
Member Author

It's on! https://crates.io/crates/nickel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants