Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply bigdecimal feature to sqlparser-rs #337

Closed
panarch opened this issue Sep 3, 2021 · 1 comment
Closed

Apply bigdecimal feature to sqlparser-rs #337

panarch opened this issue Sep 3, 2021 · 1 comment
Assignees
@devgony

Comments

@panarch
Copy link
Member

panarch commented Sep 3, 2021

sqlparser-rs provides bigdecimal as an optional feature.
Currently, bigdecimal is not being used in here.
So Literal::Number contains String, but it would be better to use bigdecimal.
Then, we don't need to parse String to i64 or f64 in execution layer.

In https://github.com/gluesql/gluesql/blob/main/src/data/literal.rs
We can clean up all binary operations between number values.
@devgony
Copy link
Collaborator

devgony commented Sep 8, 2021

Let me try it!

@devgony devgony mentioned this issue Oct 11, 2021
Merged
@panarch panarch closed this as completed Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devgony devgony

Labels
None yet
Projects
GlueSQL
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@panarch @devgony