Looks like I already had a draft PR.

What needs to be added before merge?
Sorry it has been sitting here for so long.

@panarch thoughts on what to do about this check error?

@KyGost It would be the issue of your editor. cargo fmt doesn't solve this? then.. I think editing those files in github.com web editor might work.

@panarch rustfmt worked this time but the tests failed because of the example code, have a look at the fail details.

@KyGost Ok, I think I got it if.. you are using Windows.

Can you try cargo fmt again after adding file with rustfmt.toml to the root of the repository?

In rustfmt.toml,

newline_style = "Unix"

Or... it might be related to the cargo version.
I'm using 1.50.0 (2021-02-04) and when I run cargo fmt using your branch, then it shows that cargo fmt fixes EOL.

I used Linux (Ubuntu 18.04) for this.

The issue coming up when I check the error on the commit is:

error[E0432]: unresolved imports `gluesql::Glue`, `gluesql::SledStorage`
 --> examples/hello_world.rs:1:22
  |
1 | use gluesql::{parse, Glue, Payload, SledStorage, Value};
  |                      ^^^^           ^^^^^^^^^^^ no `SledStorage` in the root
  |                      |
  |                      no `Glue` in the root
  |                      help: a similar name exists in the module: `glue`

The EOL issue is annoying too, I'll play around with some settings and try to fix that at some point.

Looks like the main issue however is that one references glue differently externally to how it is referenced internally.
This seems to be causing the issue here, the tester is for some reason testing the example code.

How can I get the tester to ignore the examples?
@panarch

@KyGost ok, I can say what's going on in here.

The issue coming up when I check the error on the commit is:

error[E0432]: unresolved imports `gluesql::Glue`, `gluesql::SledStorage`
 --> examples/hello_world.rs:1:22
  |
1 | use gluesql::{parse, Glue, Payload, SledStorage, Value};
  |                      ^^^^           ^^^^^^^^^^^ no `SledStorage` in the root
  |                      |
  |                      no `Glue` in the root
  |                      help: a similar name exists in the module: `glue`

gluesql::Glue and gluesql::SledStorage are exported only if sled_storage feature is enabled.
These are optional because it is not required for making a custom storage, only useful for standalone use.

In Cargo.toml,

For convenience, I enabled sled_storage feature by default.
So, someone who simply wants to use GlueSQL like SQLite, they can import and use it based on SledStorage. They don't need to care anything about features.
However, for custom storage makers who doesn't need SledStorage, they can import gluesql with sled_storage disabled.

And tests should work both with features & without features.
In .github/workflows/rust.yml

I included several cargo test cases.
without features, using sled_storage, using alter_table, and using both sled_storage and alter_table.

Your examples require sled_storage feature, so you need to use cfg macro.

Style is up to you.
If you change your example file like this below, then it will not make noise.
https://gist.github.com/panarch/48bf217c46938ca6484eea9f6d649956
or you can see examples/api_usage.rs or examples/using_config.rs.

@panarch ahhh okay, thank you very much.

Something different seems to have failed now though...? :-(

@KyGost 👍
I think your last commit will also fail.
#[cfg(feature = "sled-storage")] this is only applied to the next line.

fyi. https://doc.rust-lang.org/reference/attributes.html

So, in examples/hello_world.rs

#[cfg(feature = "sled-storage")]
use gluesql::{parse, Glue, Payload, SledStorage, Value};	use gluesql::{parse, Glue, Payload, SledStorage, Value};

It only excludes use line but those are used in fn main() { ... } so it cannot be compiled.

Oh I see, I need to use

#[cfg(feature = "sled-storage")]
mod sled_multi_threaded {
...
}

Thanks

@panarch it should work now but now includes needless items in the book. How can we avoid this? Is there a way to add the rules to the file outside of the file?

Looks like it failed again....

Was the strictness increased recently?
Looks like it is failing on other ~/executor/ things, which haven't been changed in this PR and should have passed previously.

Looks like it failed again....

Was the strictness increased recently?
Looks like it is failing on other ~/executor/ things, which haven't been changed in this PR and should have passed previously.

Oh, I just tested and found that. I'm simply using the default setting of clippy, it looks like it is because of recent cargo updates.
I'll take this and make it lint-clean again till tomorrow, then I'll merge to main then please merge this to this branch. Then GitHub Action cargo clippy will pass.

@panarch it should work now but now includes needless items in the book. How can we avoid this? Is there a way to add the rules to the file outside of the file?

That make sense.
I also need to figure out the way to make it better.

We might solve this by editing Cargo.toml.
If we can make cargo to ignore examples/ when sled_storage feature is disabled, then it would be cool.

Let me know you found something, I'll also try to figure out.

@KyGost #142
Tomorrow is too far from now.
Now main branch is clippy clean :)
Please merge and try again 👍

@KyGost #142
Tomorrow is too far from now.
Now main branch is clippy clean :)
Please merge and try again 👍

Awesome! I'll rebase.

@panarch woohoo! Tests passed.